RegexOp - Code Metrics - consolidation/filter-via-dot-access-data - Measure and Improve Code Quality continuously with Scrutinizer

RegexOp A
last analyzed 2020-07-13 04:44 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	1
dl	31
loc	31
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	5	5	1
A	test()	5	5	1
A	__toString()	4	4	1

How to fix Duplicated Code

<?php
namespace Consolidation\Filter\Operators;

use Consolidation\Filter\OperatorInterface;
use Dflydev\DotAccessData\Data;

/**
 * Test for equality
 */
class RegexOp implements OperatorInterface

{
    protected $key;
    protected $comparitor;

    public function __construct($key, $comparitor)
    {
        $this->key = $key;
        $this->comparitor = $comparitor;
    }

    /**
     * Test the provided value to see if it matches our criteria.
     *
     * @param mixed $value
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return bool
     */
    public function test(Data $row)
    {
        $value = $row->get($this->key);
        return preg_match($this->comparitor, $value);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Return a string representation of this operator
     */
    public function __toString()
    {
        return "{$this->key}~={$this->comparitor}";
    }
}


1		<?php
2		namespace Consolidation\Filter\Operators;
3
4		use Consolidation\Filter\OperatorInterface;
5		use Dflydev\DotAccessData\Data;
6
7		/**
8		* Test for equality
9		*/
10	View Code Duplication	class RegexOp implements OperatorInterface
		0 ignored issues – show Duplication introduced 2018-07-18 19:24 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		protected $key;
13		protected $comparitor;
14
15		public function __construct($key, $comparitor)
16		{
17		$this->key = $key;
18		$this->comparitor = $comparitor;
19		}
20
21		/**
22		* Test the provided value to see if it matches our criteria.
23		*
24		* @param mixed $value
		0 ignored issues – show Bug introduced 2018-07-18 19:24 UTC by Report Bug Copy Issue Report There is no parameter named `$value`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
25		* @return bool
26		*/
27		public function test(Data $row)
28		{
29		$value = $row->get($this->key);
30		return preg_match($this->comparitor, $value);
		0 ignored issues – show Bug Best Practice introduced 2018-07-18 19:24 UTC by Report Bug Copy Issue Report The return type of `return preg_match($this->comparitor, $value);` (`integer`) is incompatible with the return type declared by the interface `Consolidation\Filter\OperatorInterface::test` of type `boolean`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
31		}
32
33		/**
34		* Return a string representation of this operator
35		*/
36		public function __toString()
37		{
38		return "{$this->key}~={$this->comparitor}";
39		}
40		}
41

consolidation / filter-via-dot-access-data

RegexOp A last analyzed 2020-07-13 04:44 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

RegexOp A
last analyzed 2020-07-13 04:44 UTC