LogicalAndOp - Code Metrics - consolidation/filter-via-dot-access-data - Measure and Improve Code Quality continuously with Scrutinizer

LogicalAndOp A
last analyzed 2020-07-13 04:44 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	30
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	0
dl	30
loc	30
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	5	5	1
A	test()	4	4	2
A	__toString()	4	4	1

How to fix Duplicated Code

<?php
namespace Consolidation\Filter\Operators;

use Consolidation\Filter\OperatorInterface;
use Dflydev\DotAccessData\Data;

/**
 * Test for equality
 */
class LogicalAndOp implements OperatorInterface

{
    protected $lhs;
    protected $rhs;

    public function __construct($lhs, $rhs)
    {
        $this->lhs = $lhs;
        $this->rhs = $rhs;
    }

    /**
     * Test the provided value to see if it matches our criteria.
     *
     * @param mixed $value
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return bool
     */
    public function test(Data $row)
    {
        return $this->lhs->test($row) && $this->rhs->test($row);
    }

    /**
     * Return a string representation of this operator
     */
    public function __toString()
    {
        return "{$this->lhs}&&{$this->rhs}";
    }
}


1		<?php
2		namespace Consolidation\Filter\Operators;
3
4		use Consolidation\Filter\OperatorInterface;
5		use Dflydev\DotAccessData\Data;
6
7		/**
8		* Test for equality
9		*/
10	View Code Duplication	class LogicalAndOp implements OperatorInterface
		0 ignored issues – show Duplication introduced 2018-07-18 19:24 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		protected $lhs;
13		protected $rhs;
14
15		public function __construct($lhs, $rhs)
16		{
17		$this->lhs = $lhs;
18		$this->rhs = $rhs;
19		}
20
21		/**
22		* Test the provided value to see if it matches our criteria.
23		*
24		* @param mixed $value
		0 ignored issues – show Bug introduced 2018-07-18 19:24 UTC by Report Bug Copy Issue Report There is no parameter named `$value`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
25		* @return bool
26		*/
27		public function test(Data $row)
28		{
29		return $this->lhs->test($row) && $this->rhs->test($row);
30		}
31
32		/**
33		* Return a string representation of this operator
34		*/
35		public function __toString()
36		{
37		return "{$this->lhs}&&{$this->rhs}";
38		}
39		}
40

consolidation / filter-via-dot-access-data

LogicalAndOp A last analyzed 2020-07-13 04:44 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

LogicalAndOp A
last analyzed 2020-07-13 04:44 UTC