Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like BespokeDocBlockParser often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use BespokeDocBlockParser, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 12 | class BespokeDocBlockParser |
||
| 13 | { |
||
| 14 | protected $fqcnCache; |
||
| 15 | |||
| 16 | /** |
||
| 17 | * @var array |
||
| 18 | */ |
||
| 19 | protected $tagProcessors = [ |
||
| 20 | 'command' => 'processCommandTag', |
||
| 21 | 'name' => 'processCommandTag', |
||
| 22 | 'arg' => 'processArgumentTag', |
||
| 23 | 'param' => 'processArgumentTag', |
||
| 24 | 'return' => 'processReturnTag', |
||
| 25 | 'option' => 'processOptionTag', |
||
| 26 | 'default' => 'processDefaultTag', |
||
| 27 | 'aliases' => 'processAliases', |
||
| 28 | 'usage' => 'processUsageTag', |
||
| 29 | 'description' => 'processAlternateDescriptionTag', |
||
| 30 | 'desc' => 'processAlternateDescriptionTag', |
||
| 31 | ]; |
||
| 32 | |||
| 33 | public function __construct(CommandInfo $commandInfo, \ReflectionMethod $reflection, $fqcnCache = null) |
||
| 39 | |||
| 40 | /** |
||
| 41 | * Parse the docBlock comment for this command, and set the |
||
| 42 | * fields of this class with the data thereby obtained. |
||
| 43 | */ |
||
| 44 | public function parse() |
||
| 49 | |||
| 50 | /** |
||
| 51 | * Save any tag that we do not explicitly recognize in the |
||
| 52 | * 'otherAnnotations' map. |
||
| 53 | */ |
||
| 54 | protected function processGenericTag($tag) |
||
| 58 | |||
| 59 | /** |
||
| 60 | * Set the name of the command from a @command or @name annotation. |
||
| 61 | */ |
||
| 62 | View Code Duplication | protected function processCommandTag($tag) |
|
| 73 | |||
| 74 | /** |
||
| 75 | * The @description and @desc annotations may be used in |
||
| 76 | * place of the synopsis (which we call 'description'). |
||
| 77 | * This is discouraged. |
||
| 78 | * |
||
| 79 | * @deprecated |
||
| 80 | */ |
||
| 81 | protected function processAlternateDescriptionTag($tag) |
||
| 85 | |||
| 86 | /** |
||
| 87 | * Store the data from a @arg annotation in our argument descriptions. |
||
| 88 | */ |
||
| 89 | View Code Duplication | protected function processArgumentTag($tag) |
|
| 99 | |||
| 100 | /** |
||
| 101 | * Store the data from an @option annotation in our option descriptions. |
||
| 102 | */ |
||
| 103 | View Code Duplication | protected function processOptionTag($tag) |
|
| 110 | |||
| 111 | protected function addOptionOrArgumentTag($tag, DefaultsWithDescriptions $set, $name, $description) |
||
| 117 | |||
| 118 | /** |
||
| 119 | * Store the data from a @default annotation in our argument or option store, |
||
| 120 | * as appropriate. |
||
| 121 | */ |
||
| 122 | View Code Duplication | protected function processDefaultTag($tag) |
|
| 138 | |||
| 139 | /** |
||
| 140 | * Store the data from a @usage annotation in our example usage list. |
||
| 141 | */ |
||
| 142 | protected function processUsageTag($tag) |
||
| 152 | |||
| 153 | /** |
||
| 154 | * Process the comma-separated list of aliases |
||
| 155 | */ |
||
| 156 | protected function processAliases($tag) |
||
| 160 | |||
| 161 | /** |
||
| 162 | * Store the data from a @return annotation in our argument descriptions. |
||
| 163 | */ |
||
| 164 | View Code Duplication | protected function processReturnTag($tag) |
|
| 174 | |||
| 175 | protected function findFullyQualifiedClass($className) |
||
| 183 | |||
| 184 | private function parseDocBlock($doc) |
||
| 211 | |||
| 212 | protected function processDescriptionAndHelp($lines) |
||
| 235 | |||
| 236 | protected function nextLineIsNotEmpty($lines) |
||
| 245 | |||
| 246 | View Code Duplication | protected function processAllTags($tags) |
|
| 257 | |||
| 258 | View Code Duplication | protected function lastParameterName() |
|
| 267 | |||
| 268 | /** |
||
| 269 | * Return the name of the last parameter if it holds the options. |
||
| 270 | */ |
||
| 271 | View Code Duplication | public function optionParamName() |
|
| 285 | |||
| 286 | View Code Duplication | protected function interpretDefaultValue($defaultValue) |
|
| 302 | |||
| 303 | /** |
||
| 304 | * Given a list that might be 'a b c' or 'a, b, c' or 'a,b,c', |
||
| 305 | * convert the data into the last of these forms. |
||
| 306 | */ |
||
| 307 | protected static function convertListToCommaSeparated($text) |
||
| 311 | |||
| 312 | /** |
||
| 313 | * Take a multiline description and convert it into a single |
||
| 314 | * long unbroken line. |
||
| 315 | */ |
||
| 316 | protected static function removeLineBreaks($text) |
||
| 320 | } |
||
| 321 |
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: