AAA_RunnerErrorTest::testErrorIsHandled() - Code Metrics - Inspection of "Add configuration features to inject values into c..." - consolidation/robo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5e7886...331704 )

by Greg

created 2017-03-31 15:44 UTC

AAA_RunnerErrorTest::testErrorIsHandled() B

↳ Parent: AAA_RunnerErrorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	34
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	34
rs	8.8571
c	0
b	0
f	0
cc	1
eloc	18
nc	1
nop	0

<?php
use Robo\Robo;

use Robo\Config\ConfigProcessor;
use Robo\Config\YamlConfigLoader;

/**
 * This test must run first. :(
 */
class AAA_RunnerErrorTest extends \Codeception\TestCase\Test
namespace YourVendor;

class YourClass { }
{
    /**
     * @var \Robo\Runner
     */
    private $runner;

    /**
     * @var \CodeGuy
     */
    protected $guy;

    public function _before()
    {
        $this->runner = new \Robo\Runner('\Robo\RoboFileFixture');
    }

    public function testHandleError()
    {
        $tmpLevel = error_reporting();

        $this->assertFalse($this->runner->handleError());
        error_reporting(0);
        $this->assertTrue($this->runner->handleError());

        error_reporting($tmpLevel);
    }

    public function testErrorIsHandled()
    {
        $tmpLevel = error_reporting();

        // Set error_get_last to a known state.  Note that it can never be
        // reset; see http://php.net/manual/en/function.error-get-last.php
        @trigger_error('control');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        $error_description = error_get_last();
        $this->assertEquals('control', $error_description['message']);
        @trigger_error('');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        $error_description = error_get_last();
        $this->assertEquals('', $error_description['message']);

        // Set error_reporting to a non-zero value.  In this instance,
        // 'trigger_error' would abort our test script, so we use
        // @trigger_error so that execution will continue.  With our
        // error handler in place, the value of error_get_last() does
        // not change.
        error_reporting(E_USER_ERROR);
        set_error_handler(array($this->runner, 'handleError'));
        @trigger_error('test error', E_USER_ERROR);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        $error_description = error_get_last();
        $this->assertEquals('', $error_description['message']);

        // Set error_reporting to zero.  Now, even 'trigger_error'
        // does not abort execution.  The value of error_get_last()
        // still does not change.
        error_reporting(0);
        trigger_error('test error 2', E_USER_ERROR);
        $error_description = error_get_last();
        $this->assertEquals('', $error_description['message']);

        error_reporting($tmpLevel);
    }
}


1			<?php
2			use Robo\Robo;
3
4			use Robo\Config\ConfigProcessor;
5			use Robo\Config\YamlConfigLoader;
6
7			/**
8			* This test must run first. :(
9			*/
10			class AAA_RunnerErrorTest extends \Codeception\TestCase\Test
			0 ignored issues – show Coding Style Compatibility introduced 2017-03-29 17:03 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12			/**
13			* @var \Robo\Runner
14			*/
15			private $runner;
16
17			/**
18			* @var \CodeGuy
19			*/
20			protected $guy;
21
22			public function _before()
23			{
24			$this->runner = new \Robo\Runner('\Robo\RoboFileFixture');
25			}
26
27			public function testHandleError()
28			{
29			$tmpLevel = error_reporting();
30
31			$this->assertFalse($this->runner->handleError());
32			error_reporting(0);
33			$this->assertTrue($this->runner->handleError());
34
35			error_reporting($tmpLevel);
36			}
37
38			public function testErrorIsHandled()
39			{
40			$tmpLevel = error_reporting();
41
42			// Set error_get_last to a known state. Note that it can never be
43			// reset; see http://php.net/manual/en/function.error-get-last.php
44			@trigger_error('control');
			0 ignored issues – show Security Best Practice introduced 2016-09-13 23:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
45			$error_description = error_get_last();
46			$this->assertEquals('control', $error_description['message']);
47			@trigger_error('');
			0 ignored issues – show Security Best Practice introduced 2016-09-13 23:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
48			$error_description = error_get_last();
49			$this->assertEquals('', $error_description['message']);
50
51			// Set error_reporting to a non-zero value. In this instance,
52			// 'trigger_error' would abort our test script, so we use
53			// @trigger_error so that execution will continue. With our
54			// error handler in place, the value of error_get_last() does
55			// not change.
56			error_reporting(E_USER_ERROR);
57			set_error_handler(array($this->runner, 'handleError'));
58			@trigger_error('test error', E_USER_ERROR);
			0 ignored issues – show Security Best Practice introduced 2016-09-13 23:47 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
59			$error_description = error_get_last();
60			$this->assertEquals('', $error_description['message']);
61
62			// Set error_reporting to zero. Now, even 'trigger_error'
63			// does not abort execution. The value of error_get_last()
64			// still does not change.
65			error_reporting(0);
66			trigger_error('test error 2', E_USER_ERROR);
67			$error_description = error_get_last();
68			$this->assertEquals('', $error_description['message']);
69
70			error_reporting($tmpLevel);
71			}
72			}
73

consolidation / robo

Push — master ( 5e7886...331704 )

AAA_RunnerErrorTest::testErrorIsHandled() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like