RevisionPrinter::setCurrentRevision() - Code Metrics - Inspection of "Highlight working copy revision row in `log` comma..." - console-helpers/svn-buddy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fb09c0...db5833 )

by Alexander

created 2016-06-05 14:08 UTC

RevisionPrinter::setCurrentRevision() A

↳ Parent: RevisionPrinter

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	0
cts	3
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php
/**
 * This file is part of the SVN-Buddy library.
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 *
 * @copyright Alexander Obuhovich <[email protected]>
 * @link      https://github.com/console-helpers/svn-buddy
 */

namespace ConsoleHelpers\SVNBuddy\Repository\RevisionLog;


use ConsoleHelpers\SVNBuddy\Helper\DateHelper;
use ConsoleHelpers\SVNBuddy\Helper\OutputHelper;
use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Helper\TableCell;
use Symfony\Component\Console\Helper\TableSeparator;
use Symfony\Component\Console\Output\OutputInterface;

class RevisionPrinter
{

	const COLUMN_DETAILS = 1;

	const COLUMN_SUMMARY = 2;

	const COLUMN_REFS = 3;

	const COLUMN_MERGE_ORACLE = 4;

	const COLUMN_MERGE_STATUS = 5;

	/**
	 * Date helper.
	 *
	 * @var DateHelper
	 */
	private $_dateHelper;

	/**
	 * Output helper.
	 *
	 * @var OutputHelper
	 */
	private $_outputHelper;

	/**
	 * Columns.
	 *
	 * @var array
	 */
	private $_columns = array();

	/**
	 * Merge conflict regexps.
	 *
	 * @var array
	 */
	private $_mergeConflictRegExps = array();

	/**
	 * Log message limit.
	 *
	 * @var integer
	 */
	private $_logMessageLimit = 68;

	/**
	 * Current revision (e.g. in a working copy).
	 *
	 * @var integer|null
	 */
	private $_currentRevision;

	/**
	 * Creates instance of revision printer.
	 *
	 * @param DateHelper   $date_helper   Date helper.
	 * @param OutputHelper $output_helper Output helper.
	 */
	public function __construct(DateHelper $date_helper, OutputHelper $output_helper)
	{
		$this->_dateHelper = $date_helper;
		$this->_outputHelper = $output_helper;

		$this->_resetState();
	}

	/**
	 * Resets state.
	 *
	 * @return void
	 */
	private function _resetState()
	{
		$this->_columns = array();
		$this->_mergeConflictRegExps = array();
		$this->_logMessageLimit = 68;
	}

	/**
	 * Adds column to the output.
	 *
	 * @param integer $column Column.
	 *
	 * @return self
	 */
	public function withColumn($column)
	{
		$this->_columns[] = $column;

		return $this;
	}

	/**
	 * Sets merge conflict regexps.
	 *
	 * @param array $merge_conflict_regexps Merge conflict regexps.
	 *
	 * @return void
	 */
	public function setMergeConflictRegExps(array $merge_conflict_regexps)
	{
		$this->_mergeConflictRegExps = $merge_conflict_regexps;
	}

	/**
	 * Sets log message limit.
	 *
	 * @param integer $log_message_limit Log message limit.
	 *
	 * @return void
	 */
	public function setLogMessageLimit($log_message_limit)
	{
		$this->_logMessageLimit = $log_message_limit;
	}

	/**
	 * Sets current revision.
	 *
	 * @param integer $revision Revision.
	 *
	 * @return void
	 */
	public function setCurrentRevision($revision)
	{
		$this->_currentRevision = $revision;
	}

	/**
	 * Prints revisions.
	 *
	 * @param RevisionLog     $revision_log Revision log.
	 * @param array           $revisions    Revisions.
	 * @param OutputInterface $output       Output.
	 *
	 * @return void
	 */
	public function printRevisions(RevisionLog $revision_log, array $revisions, OutputInterface $output)
	{
		$table = new Table($output);
		$headers = array('Revision', 'Author', 'Date', 'Bug-ID', 'Log Message');

		$with_details = in_array(self::COLUMN_DETAILS, $this->_columns);

		// Add "Summary" header.
		$with_summary = in_array(self::COLUMN_SUMMARY, $this->_columns);

		if ( $with_summary ) {
			$headers[] = 'Summary';
		}

		// Add "Refs" header.
		$with_refs = in_array(self::COLUMN_REFS, $this->_columns);

		if ( $with_refs ) {
			$headers[] = 'Refs';
		}

		$with_merge_oracle = in_array(self::COLUMN_MERGE_ORACLE, $this->_columns);

		// Add "M.O." header.
		if ( $with_merge_oracle ) {
			$headers[] = 'M.O.';
		}

		// Add "Merged Via" header.
		$with_merge_status = in_array(self::COLUMN_MERGE_STATUS, $this->_columns);

		if ( $with_merge_status ) {
			$headers[] = 'Merged Via';
		}

		$table->setHeaders($headers);

		$prev_bugs = null;
		$last_color = 'yellow';
		$last_revision = end($revisions);

		$project_path = $revision_log->getProjectPath();

		$bugs_per_row = $with_details ? 1 : 3;

		$revisions_data = $revision_log->getRevisionsData('summary', $revisions);
		$revisions_paths = $revision_log->getRevisionsData('paths', $revisions);
		$revisions_bugs = $revision_log->getRevisionsData('bugs', $revisions);
		$revisions_refs = $revision_log->getRevisionsData('refs', $revisions);

		if ( $with_merge_status ) {
			$revisions_merged_via = $revision_log->getRevisionsData('merges', $revisions);
			$revisions_merged_via_refs = $revision_log->getRevisionsData(
				'refs',
				call_user_func_array('array_merge', $revisions_merged_via)
			);
		}

		foreach ( $revisions as $revision ) {
			$revision_data = $revisions_data[$revision];

			$new_bugs = $revisions_bugs[$revision];

			if ( isset($prev_bugs) && $new_bugs !== $prev_bugs ) {
				$last_color = $last_color == 'yellow' ? 'magenta' : 'yellow';
			}

			$row = array(
				$revision,
				$revision_data['author'],
				$this->_dateHelper->getAgoTime($revision_data['date']),
				$this->_outputHelper->formatArray($new_bugs, $bugs_per_row, $last_color),
				$this->_generateLogMessageColumn($with_details, $revision_data),
			);

			$revision_paths = $revisions_paths[$revision];

			// Add "Summary" column.
			if ( $with_summary ) {
				$row[] = $this->_generateSummaryColumn($revision_paths);
			}

			// Add "Refs" column.
			if ( $with_refs ) {
				$row[] = $this->_outputHelper->formatArray(
					$revisions_refs[$revision],
					1
				);
			}

			// Add "M.O." column.
			if ( $with_merge_oracle ) {
				$merge_conflict_prediction = $this->_getMergeConflictPrediction($revision_paths);
				$row[] = $merge_conflict_prediction ? '<error>' . count($merge_conflict_prediction) . '</error>' : '';
			}
			else {
				$merge_conflict_prediction = array();
			}

			// Add "Merged Via" column.
			if ( $with_merge_status ) {
				$row[] = $this->_generateMergedViaColumn($revisions_merged_via[$revision], $revisions_merged_via_refs);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
			}

			if ( $revision === $this->_currentRevision ) {
				foreach ( $row as $index => $cell ) {
					$row[$index] = sprintf('<fg=white;options=bold>%s</>', $cell);
				}
			}

			$table->addRow($row);

			if ( $with_details ) {
				$details = $this->_generateDetailsRowContent(
					$revision,
					$revisions_refs,
					$revision_paths,
					$merge_conflict_prediction,
					$project_path
				);

				$table->addRow(new TableSeparator());
				$table->addRow(array(
					new TableCell($details, array('colspan' => count($headers))),
				));

				if ( $revision != $last_revision ) {
					$table->addRow(new TableSeparator());
				}
			}

			$prev_bugs = $new_bugs;
		}

		$table->render();

		$this->_resetState();
	}

	/**
	 * Returns log message.
	 *
	 * @param boolean $with_details  With details.
	 * @param array   $revision_data Revision data.
	 *
	 * @return string
	 */
	private function _generateLogMessageColumn($with_details, array $revision_data)
	{
		if ( $with_details ) {
			// When details requested don't transform commit message except for word wrapping.
			// FIXME: Not UTF-8 safe solution.
			$log_message = wordwrap($revision_data['msg'], $this->_logMessageLimit);

			return $log_message;
		}
		else {
			// When details not requested only operate on first line of commit message.
			list($log_message,) = explode(PHP_EOL, $revision_data['msg']);
			$log_message = preg_replace('/^\[fixes:.*?\]/s', "\xE2\x9C\x94", $log_message);

			if ( strpos($revision_data['msg'], PHP_EOL) !== false
				|| mb_strlen($log_message) > $this->_logMessageLimit
			) {
				$log_message = mb_substr($log_message, 0, $this->_logMessageLimit - 3) . '...';

				return $log_message;
			}

			return $log_message;
		}
	}

	/**
	 * Generates change summary for a revision.
	 *
	 * @param array $revision_paths Revision paths.
	 *
	 * @return string
	 */
	private function _generateSummaryColumn(array $revision_paths)
	{
		$summary = array('added' => 0, 'changed' => 0, 'removed' => 0);

		foreach ( $revision_paths as $path_data ) {
			$path_action = $path_data['action'];

			if ( $path_action == 'A' ) {
				$summary['added']++;
			}
			elseif ( $path_action == 'D' ) {
				$summary['removed']++;
			}
			else {
				$summary['changed']++;
			}
		}

		if ( $summary['added'] ) {
			$summary['added'] = '<fg=green>+' . $summary['added'] . '</>';
		}

		if ( $summary['removed'] ) {
			$summary['removed'] = '<fg=red>-' . $summary['removed'] . '</>';
		}

		return implode(' ', array_filter($summary));
	}

	/**
	 * Returns merge conflict path predictions.
	 *
	 * @param array $revision_paths Revision paths.
	 *
	 * @return array
	 */
	private function _getMergeConflictPrediction(array $revision_paths)
	{
		if ( !$this->_mergeConflictRegExps ) {
			return array();
		}

		$conflict_paths = array();

		foreach ( $revision_paths as $revision_path ) {
			foreach ( $this->_mergeConflictRegExps as $merge_conflict_regexp ) {
				if ( preg_match($merge_conflict_regexp, $revision_path['path']) ) {
					$conflict_paths[] = $revision_path['path'];
				}
			}
		}

		return $conflict_paths;
	}

	/**
	 * Generates content for "Merged Via" cell content.
	 *
	 * @param array $merged_via                Merged Via.
	 * @param array $revisions_merged_via_refs Merged Via Refs.
	 *
	 * @return string
	 */
	private function _generateMergedViaColumn(array $merged_via, array $revisions_merged_via_refs)
	{
		if ( !$merged_via ) {
			return '';
		}

		$merged_via_enhanced = array();

		foreach ( $merged_via as $merged_via_revision ) {
			$merged_via_revision_refs = $revisions_merged_via_refs[$merged_via_revision];

			if ( $merged_via_revision_refs ) {
				$merged_via_enhanced[] = $merged_via_revision . ' (' . implode(',', $merged_via_revision_refs) . ')';
			}
			else {
				$merged_via_enhanced[] = $merged_via_revision;
			}
		}

		return $this->_outputHelper->formatArray($merged_via_enhanced, 1);
	}

	/**
	 * Generates details row content.
	 *
	 * @param integer $revision                  Revision.
	 * @param array   $revisions_refs            Refs.
	 * @param array   $revision_paths            Revision paths.
	 * @param array   $merge_conflict_prediction Merge conflict prediction.
	 * @param string  $project_path              Project path.
	 *
	 * @return string
	 */
	private function _generateDetailsRowContent(
		$revision,
		array $revisions_refs,
		array $revision_paths,
		array $merge_conflict_prediction,
		$project_path
	) {
		$details = '<fg=white;options=bold>Changed Paths:</>';
		$path_cut_off_regexp = $this->getPathCutOffRegExp($project_path, $revisions_refs[$revision]);

		foreach ( $revision_paths as $path_data ) {
			$path_action = $path_data['action'];
			$relative_path = $this->_getRelativeLogPath($path_data, 'path', $path_cut_off_regexp);

			$details .= PHP_EOL . ' * ';

			if ( $path_action == 'A' ) {
				$color_format = 'fg=green';
			}
			elseif ( $path_action == 'D' ) {
				$color_format = 'fg=red';
			}
			else {
				$color_format = in_array($path_data['path'], $merge_conflict_prediction) ? 'error' : '';
			}

			$to_colorize = array($path_action . '    ' . $relative_path);

			if ( isset($path_data['copyfrom-path']) ) {
				// TODO: When copy happened from different ref/project, then relative path = absolute path.
				$copy_from_rev = $path_data['copyfrom-rev'];
				$copy_from_path = $this->_getRelativeLogPath($path_data, 'copyfrom-path', $path_cut_off_regexp);
				$to_colorize[] = '        (from ' . $copy_from_path . ':' . $copy_from_rev . ')';
			}

			if ( $color_format ) {
				$details .= '<' . $color_format . '>';
				$details .= implode('</>' . PHP_EOL . '<' . $color_format . '>', $to_colorize);
				$details .= '</>';
			}
			else {
				$details .= implode(PHP_EOL, $to_colorize);
			}
		}

		return $details;
	}

	/**
	 * Returns path cut off regexp.
	 *
	 * @param string $project_path Project path.
	 * @param array  $refs         Refs.
	 *
	 * @return string
	 */
	protected function getPathCutOffRegExp($project_path, array $refs)

	{
		$ret = array();

		// Remove ref from path only for single-ref revision.
		/*if ( count($refs) === 1 ) {
			$ret[] = $project_path . reset($refs) . '/';
		}*/

		// Always remove project path.
		$ret[] = $project_path;

		return '#^(' . implode('|', array_map('preg_quote', $ret)) . ')#';
	}

	/**
	 * Returns relative path to "svn log" returned path.
	 *
	 * @param array  $path_data           Path data.
	 * @param string $path_key            Path key.
	 * @param string $path_cut_off_regexp Path cut off regexp.
	 *
	 * @return string
	 */
	private function _getRelativeLogPath(array $path_data, $path_key, $path_cut_off_regexp)
	{
		$ret = preg_replace($path_cut_off_regexp, '', $path_data[$path_key], 1);

		if ( $ret === '' ) {
			$ret = '.';
		}

		return $ret;
	}

}


Push — master ( fb09c0...db5833 )

RevisionPrinter::setCurrentRevision() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1		<?php
2		/**
3		* This file is part of the SVN-Buddy library.
4		* For the full copyright and license information, please view
5		* the LICENSE file that was distributed with this source code.
6		*
7		* @copyright Alexander Obuhovich <[email protected]>
8		* @link https://github.com/console-helpers/svn-buddy
9		*/
10
11		namespace ConsoleHelpers\SVNBuddy\Repository\RevisionLog;
12
13
14		use ConsoleHelpers\SVNBuddy\Helper\DateHelper;
15		use ConsoleHelpers\SVNBuddy\Helper\OutputHelper;
16		use Symfony\Component\Console\Helper\Table;
17		use Symfony\Component\Console\Helper\TableCell;
18		use Symfony\Component\Console\Helper\TableSeparator;
19		use Symfony\Component\Console\Output\OutputInterface;
20
21		class RevisionPrinter
22		{
23
24		const COLUMN_DETAILS = 1;
25
26		const COLUMN_SUMMARY = 2;
27
28		const COLUMN_REFS = 3;
29
30		const COLUMN_MERGE_ORACLE = 4;
31
32		const COLUMN_MERGE_STATUS = 5;
33
34		/**
35		* Date helper.
36		*
37		* @var DateHelper
38		*/
39		private $_dateHelper;
40
41		/**
42		* Output helper.
43		*
44		* @var OutputHelper
45		*/
46		private $_outputHelper;
47
48		/**
49		* Columns.
50		*
51		* @var array
52		*/
53		private $_columns = array();
54
55		/**
56		* Merge conflict regexps.
57		*
58		* @var array
59		*/
60		private $_mergeConflictRegExps = array();
61
62		/**
63		* Log message limit.
64		*
65		* @var integer
66		*/
67		private $_logMessageLimit = 68;
68
69		/**
70		* Current revision (e.g. in a working copy).
71		*
72		* @var integer\|null
73		*/
74		private $_currentRevision;
75
76		/**
77		* Creates instance of revision printer.
78		*
79		* @param DateHelper $date_helper Date helper.
80		* @param OutputHelper $output_helper Output helper.
81		*/
82	1	public function __construct(DateHelper $date_helper, OutputHelper $output_helper)
83		{
84	1	$this->_dateHelper = $date_helper;
85	1	$this->_outputHelper = $output_helper;
86
87	1	$this->_resetState();
88	1	}
89
90		/**
91		* Resets state.
92		*
93		* @return void
94		*/
95	1	private function _resetState()
96		{
97	1	$this->_columns = array();
98	1	$this->_mergeConflictRegExps = array();
99	1	$this->_logMessageLimit = 68;
100	1	}
101
102		/**
103		* Adds column to the output.
104		*
105		* @param integer $column Column.
106		*
107		* @return self
108		*/
109		public function withColumn($column)
110		{
111		$this->_columns[] = $column;
112
113		return $this;
114		}
115
116		/**
117		* Sets merge conflict regexps.
118		*
119		* @param array $merge_conflict_regexps Merge conflict regexps.
120		*
121		* @return void
122		*/
123		public function setMergeConflictRegExps(array $merge_conflict_regexps)
124		{
125		$this->_mergeConflictRegExps = $merge_conflict_regexps;
126		}
127
128		/**
129		* Sets log message limit.
130		*
131		* @param integer $log_message_limit Log message limit.
132		*
133		* @return void
134		*/
135		public function setLogMessageLimit($log_message_limit)
136		{
137		$this->_logMessageLimit = $log_message_limit;
138		}
139
140		/**
141		* Sets current revision.
142		*
143		* @param integer $revision Revision.
144		*
145		* @return void
146		*/
147		public function setCurrentRevision($revision)
148		{
149		$this->_currentRevision = $revision;
150		}
151
152		/**
153		* Prints revisions.
154		*
155		* @param RevisionLog $revision_log Revision log.
156		* @param array $revisions Revisions.
157		* @param OutputInterface $output Output.
158		*
159		* @return void
160		*/
161		public function printRevisions(RevisionLog $revision_log, array $revisions, OutputInterface $output)
162		{
163		$table = new Table($output);
164		$headers = array('Revision', 'Author', 'Date', 'Bug-ID', 'Log Message');
165
166		$with_details = in_array(self::COLUMN_DETAILS, $this->_columns);
167
168		// Add "Summary" header.
169		$with_summary = in_array(self::COLUMN_SUMMARY, $this->_columns);
170
171		if ( $with_summary ) {
172		$headers[] = 'Summary';
173		}
174
175		// Add "Refs" header.
176		$with_refs = in_array(self::COLUMN_REFS, $this->_columns);
177
178		if ( $with_refs ) {
179		$headers[] = 'Refs';
180		}
181
182		$with_merge_oracle = in_array(self::COLUMN_MERGE_ORACLE, $this->_columns);
183
184		// Add "M.O." header.
185		if ( $with_merge_oracle ) {
186		$headers[] = 'M.O.';
187		}
188
189		// Add "Merged Via" header.
190		$with_merge_status = in_array(self::COLUMN_MERGE_STATUS, $this->_columns);
191
192		if ( $with_merge_status ) {
193		$headers[] = 'Merged Via';
194		}
195
196		$table->setHeaders($headers);
197
198		$prev_bugs = null;
199		$last_color = 'yellow';
200		$last_revision = end($revisions);
201
202		$project_path = $revision_log->getProjectPath();
203
204		$bugs_per_row = $with_details ? 1 : 3;
205
206		$revisions_data = $revision_log->getRevisionsData('summary', $revisions);
207		$revisions_paths = $revision_log->getRevisionsData('paths', $revisions);
208		$revisions_bugs = $revision_log->getRevisionsData('bugs', $revisions);
209		$revisions_refs = $revision_log->getRevisionsData('refs', $revisions);
210
211		if ( $with_merge_status ) {
212		$revisions_merged_via = $revision_log->getRevisionsData('merges', $revisions);
213		$revisions_merged_via_refs = $revision_log->getRevisionsData(
214		'refs',
215		call_user_func_array('array_merge', $revisions_merged_via)
216		);
217		}
218
219		foreach ( $revisions as $revision ) {
220		$revision_data = $revisions_data[$revision];
221
222		$new_bugs = $revisions_bugs[$revision];
223
224		if ( isset($prev_bugs) && $new_bugs !== $prev_bugs ) {
225		$last_color = $last_color == 'yellow' ? 'magenta' : 'yellow';
226		}
227
228		$row = array(
229		$revision,
230		$revision_data['author'],
231		$this->_dateHelper->getAgoTime($revision_data['date']),
232		$this->_outputHelper->formatArray($new_bugs, $bugs_per_row, $last_color),
233		$this->_generateLogMessageColumn($with_details, $revision_data),
234		);
235
236		$revision_paths = $revisions_paths[$revision];
237
238		// Add "Summary" column.
239		if ( $with_summary ) {
240		$row[] = $this->_generateSummaryColumn($revision_paths);
241		}
242
243		// Add "Refs" column.
244		if ( $with_refs ) {
245		$row[] = $this->_outputHelper->formatArray(
246		$revisions_refs[$revision],
247		1
248		);
249		}
250
251		// Add "M.O." column.
252		if ( $with_merge_oracle ) {
253		$merge_conflict_prediction = $this->_getMergeConflictPrediction($revision_paths);
254		$row[] = $merge_conflict_prediction ? '<error>' . count($merge_conflict_prediction) . '</error>' : '';
255		}
256		else {
257		$merge_conflict_prediction = array();
258		}
259
260		// Add "Merged Via" column.
261		if ( $with_merge_status ) {
262		$row[] = $this->_generateMergedViaColumn($revisions_merged_via[$revision], $revisions_merged_via_refs);
		0 ignored issues – show Bug introduced 2016-05-15 09:45 UTC by Report Bug Copy Issue Report The variable `$revisions_merged_via` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug introduced 2016-05-15 09:45 UTC by Report Bug Copy Issue Report The variable `$revisions_merged_via_refs` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
263		}
264
265		if ( $revision === $this->_currentRevision ) {
266		foreach ( $row as $index => $cell ) {
267		$row[$index] = sprintf('<fg=white;options=bold>%s</>', $cell);
268		}
269		}
270
271		$table->addRow($row);
272
273		if ( $with_details ) {
274		$details = $this->_generateDetailsRowContent(
275		$revision,
276		$revisions_refs,
277		$revision_paths,
278		$merge_conflict_prediction,
279		$project_path
280		);
281
282		$table->addRow(new TableSeparator());
283		$table->addRow(array(
284		new TableCell($details, array('colspan' => count($headers))),
285		));
286
287		if ( $revision != $last_revision ) {
288		$table->addRow(new TableSeparator());
289		}
290		}
291
292		$prev_bugs = $new_bugs;
293		}
294
295		$table->render();
296
297		$this->_resetState();
298		}
299
300		/**
301		* Returns log message.
302		*
303		* @param boolean $with_details With details.
304		* @param array $revision_data Revision data.
305		*
306		* @return string
307		*/
308		private function _generateLogMessageColumn($with_details, array $revision_data)
309		{
310		if ( $with_details ) {
311		// When details requested don't transform commit message except for word wrapping.
312		// FIXME: Not UTF-8 safe solution.
313		$log_message = wordwrap($revision_data['msg'], $this->_logMessageLimit);
314
315		return $log_message;
316		}
317		else {
318		// When details not requested only operate on first line of commit message.
319		list($log_message,) = explode(PHP_EOL, $revision_data['msg']);
320		$log_message = preg_replace('/^\[fixes:.*?\]/s', "\xE2\x9C\x94", $log_message);
321
322		if ( strpos($revision_data['msg'], PHP_EOL) !== false
323		\|\| mb_strlen($log_message) > $this->_logMessageLimit
324		) {
325		$log_message = mb_substr($log_message, 0, $this->_logMessageLimit - 3) . '...';
326
327		return $log_message;
328		}
329
330		return $log_message;
331		}
332		}
333
334		/**
335		* Generates change summary for a revision.
336		*
337		* @param array $revision_paths Revision paths.
338		*
339		* @return string
340		*/
341		private function _generateSummaryColumn(array $revision_paths)
342		{
343		$summary = array('added' => 0, 'changed' => 0, 'removed' => 0);
344
345		foreach ( $revision_paths as $path_data ) {
346		$path_action = $path_data['action'];
347
348		if ( $path_action == 'A' ) {
349		$summary['added']++;
350		}
351		elseif ( $path_action == 'D' ) {
352		$summary['removed']++;
353		}
354		else {
355		$summary['changed']++;
356		}
357		}
358
359		if ( $summary['added'] ) {
360		$summary['added'] = '<fg=green>+' . $summary['added'] . '</>';
361		}
362
363		if ( $summary['removed'] ) {
364		$summary['removed'] = '<fg=red>-' . $summary['removed'] . '</>';
365		}
366
367		return implode(' ', array_filter($summary));
368		}
369
370		/**
371		* Returns merge conflict path predictions.
372		*
373		* @param array $revision_paths Revision paths.
374		*
375		* @return array
376		*/
377		private function _getMergeConflictPrediction(array $revision_paths)
378		{
379		if ( !$this->_mergeConflictRegExps ) {
380		return array();
381		}
382
383		$conflict_paths = array();
384
385		foreach ( $revision_paths as $revision_path ) {
386		foreach ( $this->_mergeConflictRegExps as $merge_conflict_regexp ) {
387		if ( preg_match($merge_conflict_regexp, $revision_path['path']) ) {
388		$conflict_paths[] = $revision_path['path'];
389		}
390		}
391		}
392
393		return $conflict_paths;
394		}
395
396		/**
397		* Generates content for "Merged Via" cell content.
398		*
399		* @param array $merged_via Merged Via.
400		* @param array $revisions_merged_via_refs Merged Via Refs.
401		*
402		* @return string
403		*/
404		private function _generateMergedViaColumn(array $merged_via, array $revisions_merged_via_refs)
405		{
406		if ( !$merged_via ) {
407		return '';
408		}
409
410		$merged_via_enhanced = array();
411
412		foreach ( $merged_via as $merged_via_revision ) {
413		$merged_via_revision_refs = $revisions_merged_via_refs[$merged_via_revision];
414
415		if ( $merged_via_revision_refs ) {
416		$merged_via_enhanced[] = $merged_via_revision . ' (' . implode(',', $merged_via_revision_refs) . ')';
417		}
418		else {
419		$merged_via_enhanced[] = $merged_via_revision;
420		}
421		}
422
423		return $this->_outputHelper->formatArray($merged_via_enhanced, 1);
424		}
425
426		/**
427		* Generates details row content.
428		*
429		* @param integer $revision Revision.
430		* @param array $revisions_refs Refs.
431		* @param array $revision_paths Revision paths.
432		* @param array $merge_conflict_prediction Merge conflict prediction.
433		* @param string $project_path Project path.
434		*
435		* @return string
436		*/
437		private function _generateDetailsRowContent(
438		$revision,
439		array $revisions_refs,
440		array $revision_paths,
441		array $merge_conflict_prediction,
442		$project_path
443		) {
444		$details = '<fg=white;options=bold>Changed Paths:</>';
445		$path_cut_off_regexp = $this->getPathCutOffRegExp($project_path, $revisions_refs[$revision]);
446
447		foreach ( $revision_paths as $path_data ) {
448		$path_action = $path_data['action'];
449		$relative_path = $this->_getRelativeLogPath($path_data, 'path', $path_cut_off_regexp);
450
451		$details .= PHP_EOL . ' * ';
452
453		if ( $path_action == 'A' ) {
454		$color_format = 'fg=green';
455		}
456		elseif ( $path_action == 'D' ) {
457		$color_format = 'fg=red';
458		}
459		else {
460		$color_format = in_array($path_data['path'], $merge_conflict_prediction) ? 'error' : '';
461		}
462
463		$to_colorize = array($path_action . ' ' . $relative_path);
464
465		if ( isset($path_data['copyfrom-path']) ) {
466		// TODO: When copy happened from different ref/project, then relative path = absolute path.
467		$copy_from_rev = $path_data['copyfrom-rev'];
468		$copy_from_path = $this->_getRelativeLogPath($path_data, 'copyfrom-path', $path_cut_off_regexp);
469		$to_colorize[] = ' (from ' . $copy_from_path . ':' . $copy_from_rev . ')';
470		}
471
472		if ( $color_format ) {
473		$details .= '<' . $color_format . '>';
474		$details .= implode('</>' . PHP_EOL . '<' . $color_format . '>', $to_colorize);
475		$details .= '</>';
476		}
477		else {
478		$details .= implode(PHP_EOL, $to_colorize);
479		}
480		}
481
482		return $details;
483		}
484
485		/**
486		* Returns path cut off regexp.
487		*
488		* @param string $project_path Project path.
489		* @param array $refs Refs.
490		*
491		* @return string
492		*/
493		protected function getPathCutOffRegExp($project_path, array $refs)
		0 ignored issues – show Unused Code introduced 2016-05-18 16:24 UTC by Report Bug Copy Issue Report The parameter `$refs` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
494		{
495		$ret = array();
496
497		// Remove ref from path only for single-ref revision.
498		/*if ( count($refs) === 1 ) {
499		$ret[] = $project_path . reset($refs) . '/';
500		}*/
501
502		// Always remove project path.
503		$ret[] = $project_path;
504
505		return '#^(' . implode('\|', array_map('preg_quote', $ret)) . ')#';
506		}
507
508		/**
509		* Returns relative path to "svn log" returned path.
510		*
511		* @param array $path_data Path data.
512		* @param string $path_key Path key.
513		* @param string $path_cut_off_regexp Path cut off regexp.
514		*
515		* @return string
516		*/
517		private function _getRelativeLogPath(array $path_data, $path_key, $path_cut_off_regexp)
518		{
519		$ret = preg_replace($path_cut_off_regexp, '', $path_data[$path_key], 1);
520
521		if ( $ret === '' ) {
522		$ret = '.';
523		}
524
525		return $ret;
526		}
527
528		}
529

console-helpers / svn-buddy

Push — master ( fb09c0...db5833 )

RevisionPrinter::setCurrentRevision() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like