BugsPlugin::doDetectBugs() - Code Metrics - Inspection of "Makes test suite compatible with PHPUnit 6" - console-helpers/svn-buddy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#114)

by Alexander

created 2018-01-08 09:48 UTC

BugsPlugin::doDetectBugs() B

↳ Parent: BugsPlugin

Complexity

Conditions	5
Paths	3

Size

Total Lines	23
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	5

Importance

Changes

Metric	Value
dl	0
loc	23
ccs	13
cts	13
cp	1
rs	8.5906
c	0
b	0
f	0
cc	5
eloc	12
nc	3
nop	3
crap	5

<?php
/**
 * This file is part of the SVN-Buddy library.
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 *
 * @copyright Alexander Obuhovich <[email protected]>
 * @link      https://github.com/console-helpers/svn-buddy
 */

namespace ConsoleHelpers\SVNBuddy\Repository\RevisionLog\Plugin;


use Aura\Sql\ExtendedPdoInterface;
use Aura\Sql\Iterator\AllIterator;
use ConsoleHelpers\SVNBuddy\Repository\Connector\Connector;
use ConsoleHelpers\SVNBuddy\Repository\Parser\LogMessageParserFactory;
use ConsoleHelpers\SVNBuddy\Repository\RevisionLog\RepositoryFiller;

class BugsPlugin extends AbstractDatabaseCollectorPlugin
{

	const STATISTIC_BUG_ADDED_TO_COMMIT = 'bug_added_to_commit';

	/**
	 * Repository url.
	 *
	 * @var string
	 */
	private $_repositoryUrl;

	/**
	 * Repository connector.
	 *
	 * @var Connector
	 */
	private $_repositoryConnector;

	/**
	 * Log message parser factory.
	 *
	 * @var LogMessageParserFactory
	 */
	private $_logMessageParserFactory;

	/**
	 * Create bugs revision log plugin.
	 *
	 * @param ExtendedPdoInterface    $database                   Database.
	 * @param RepositoryFiller        $repository_filler          Repository filler.
	 * @param string                  $repository_url             Repository url.
	 * @param Connector               $repository_connector       Repository connector.
	 * @param LogMessageParserFactory $log_message_parser_factory Log message parser.
	 */
	public function __construct(
		ExtendedPdoInterface $database,
		RepositoryFiller $repository_filler,
		$repository_url,
		Connector $repository_connector,
		LogMessageParserFactory $log_message_parser_factory
	) {
		parent::__construct($database, $repository_filler);

		$this->_repositoryUrl = $repository_url;
		$this->_repositoryConnector = $repository_connector;
		$this->_logMessageParserFactory = $log_message_parser_factory;
	}

	/**
	 * Returns plugin name.
	 *
	 * @return string
	 */
	public function getName()
	{
		return 'bugs';
	}

	/**
	 * Defines parsing statistic types.
	 *
	 * @return array
	 */
	public function defineStatisticTypes()
	{
		return array(
			self::STATISTIC_BUG_ADDED_TO_COMMIT,
		);
	}

	/**
	 * Processes data.
	 *
	 * @param integer $from_revision From revision.
	 * @param integer $to_revision   To revision.
	 *
	 * @return void
	 */
	public function doProcess($from_revision, $to_revision)
	{
		$this->populateMissingBugRegExp();

		$last_revision = $this->getLastRevision();

		if ( $to_revision > $last_revision ) {
			$this->detectBugs($last_revision + 1, $to_revision);
			$this->setLastRevision($to_revision);
		}
	}

	/**
	 * Populate "BugRegExp" column for projects without it.
	 *
	 * @return void
	 */
	protected function populateMissingBugRegExp()
	{
		$projects = $this->getProjects('BugRegExp IS NULL');

		if ( !$projects ) {
			$this->advanceProgressBar();

			return;
		}

		foreach ( $projects as $project_data ) {
			$bug_regexp = $this->detectProjectBugTraqRegEx(
				$project_data['Path'],
				$project_data['RevisionLastSeen'],
				(bool)$project_data['IsDeleted']
			);

			$this->repositoryFiller->setProjectBugRegexp($project_data['Id'], $bug_regexp);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
			$this->advanceProgressBar();
		}
	}

	/**
	 * Determines project bug tracking regular expression.
	 *
	 * @param string  $project_path    Project project_path.
	 * @param integer $revision        Revision.
	 * @param boolean $project_deleted Project is deleted.
	 *
	 * @return string
	 */
	protected function detectProjectBugTraqRegEx($project_path, $revision, $project_deleted)
	{
		$ref_paths = $this->getLastChangedRefPaths($project_path);

		if ( !$ref_paths ) {
			return '';
		}

		foreach ( $ref_paths as $ref_path ) {
			$logregex = $this->_repositoryConnector
				->withCache('1 year')
				->getProperty(
					'bugtraq:logregex',
					$this->_repositoryUrl . $ref_path . ($project_deleted ? '@' . $revision : '')
				);

			if ( strlen($logregex) ) {
				return $logregex;
			}
		}

		return '';
	}

	/**
	 * Returns given project refs, where last changed are on top.
	 *
	 * @param string $project_path Path.
	 *
	 * @return array
	 */
	protected function getLastChangedRefPaths($project_path)
	{
		$own_nesting_level = substr_count($project_path, '/') - 1;

		$where_clause = array(
			'Path LIKE :parent_path',
			'PathNestingLevel BETWEEN :from_level AND :to_level',
			'RevisionDeleted IS NULL',
		);

		$sql = 'SELECT Path, RevisionLastSeen
				FROM Paths
				WHERE (' . implode(') AND (', $where_clause) . ')';
		$paths = $this->database->fetchPairs($sql, array(
			'parent_path' => $project_path . '%',
			'from_level' => $own_nesting_level + 1,
			'to_level' => $own_nesting_level + 2,
		));

		// No sub-folders.
		if ( !$paths ) {
			return array();
		}

		$filtered_paths = array();

		foreach ( $paths as $path => $revision ) {
			if ( $this->isRef($path) ) {
				$filtered_paths[$path] = $revision;
			}
		}

		// None of sub-folders matches a ref.
		if ( !$filtered_paths ) {
			return array();
		}

		arsort($filtered_paths, SORT_NUMERIC);

		return array_keys($filtered_paths);
	}

	/**
	 * Detects if given project_path is known project root.
	 *
	 * @param string $path Path.
	 *
	 * @return boolean
	 */
	protected function isRef($path)
	{
		// Not a folder.
		if ( substr($path, -1, 1) !== '/' ) {
			return false;
		}

		return $this->_repositoryConnector->isRefRoot($path);
	}

	/**
	 * Detects bugs, associated with each commit from a given revision range.
	 *
	 * @param integer $from_revision From revision.
	 * @param integer $to_revision   To revision.
	 *
	 * @return void
	 */
	protected function detectBugs($from_revision, $to_revision)
	{
		$bug_regexp_mapping = $this->getProjectBugRegExps();

		if ( !$bug_regexp_mapping ) {
			$this->advanceProgressBar();

			return;
		}

		$range_start = $from_revision;

		while ( $range_start <= $to_revision ) {
			$range_end = min($range_start + 999, $to_revision);

			$this->doDetectBugs($range_start, $range_end, $bug_regexp_mapping);
			$this->advanceProgressBar();

			$range_start = $range_end + 1;
		}
	}

	/**
	 * Returns "BugRegExp" field associated with every project.
	 *
	 * @return array
	 */
	protected function getProjectBugRegExps()
	{
		$projects = $this->getProjects("BugRegExp != ''");

		if ( !$projects ) {
			return array();
		}

		$ret = array();

		foreach ( $projects as $project_data ) {
			$ret[$project_data['Id']] = $project_data['BugRegExp'];
		}

		return $ret;
	}

	/**
	 * Detects bugs, associated with each commit from a given revision range.
	 *
	 * @param integer $from_revision      From revision.
	 * @param integer $to_revision        To revision.
	 * @param array   $bug_regexp_mapping Mapping between project and it's "BugRegExp" field.
	 *
	 * @return void
	 */
	protected function doDetectBugs($from_revision, $to_revision, array $bug_regexp_mapping)
	{
		$commits_by_project = $this->getCommitsGroupedByProject($from_revision, $to_revision);

		foreach ( $commits_by_project as $project_id => $project_commits ) {
			if ( !isset($bug_regexp_mapping[$project_id]) ) {
				continue;
			}

			$log_message_parser = $this->_logMessageParserFactory->getLogMessageParser(
				$bug_regexp_mapping[$project_id]
			);

			foreach ( $project_commits as $revision => $log_message ) {
				$bugs = $log_message_parser->parse($log_message);

				if ( $bugs ) {
					$this->repositoryFiller->addBugsToCommit($bugs, $revision);
					$this->recordStatistic(self::STATISTIC_BUG_ADDED_TO_COMMIT, count($bugs));
				}
			}
		}
	}

	/**
	 * Returns commits grouped by project.
	 *
	 * @param integer $from_revision From revision.
	 * @param integer $to_revision   To revision.
	 *
	 * @return array
	 */
	protected function getCommitsGroupedByProject($from_revision, $to_revision)
	{
		$sql = 'SELECT cp.Revision, c.Message, cp.ProjectId
				FROM CommitProjects cp
				JOIN Commits c ON c.Revision = cp.Revision
				WHERE cp.Revision BETWEEN :from_revision AND :to_revision';
		$commits = new AllIterator($this->database->perform($sql, array(
			'from_revision' => $from_revision,
			'to_revision' => $to_revision,
		)));

		$ret = array();
		$processed_revisions = array();

		foreach ( $commits as $commit_data ) {
			$revision = $commit_data['Revision'];

			// Don't process revision more then once (e.g. when commit belongs to different projects).
			if ( isset($processed_revisions[$revision]) ) {
				continue;
			}

			$project_id = $commit_data['ProjectId'];

			if ( !isset($ret[$project_id]) ) {
				$ret[$project_id] = array();
			}

			$ret[$project_id][$revision] = $commit_data['Message'];
			$processed_revisions[$revision] = true;
		}

		return $ret;
	}

	/**
	 * Find revisions by collected data.
	 *
	 * @param array  $criteria     Criteria.
	 * @param string $project_path Project path.
	 *
	 * @return array
	 */
	public function find(array $criteria, $project_path)
	{
		if ( !$criteria ) {
			return array();
		}

		$project_id = $this->getProject($project_path);

		$sql = 'SELECT DISTINCT cb.Revision
				FROM CommitBugs cb
				JOIN CommitProjects cp ON cp.Revision = cb.Revision
				WHERE cp.ProjectId = :project_id AND cb.Bug IN (:bugs)';
		$bug_revisions = $this->database->fetchCol($sql, array('project_id' => $project_id, 'bugs' => $criteria));

		sort($bug_revisions, SORT_NUMERIC);

		return $bug_revisions;
	}

	/**
	 * Returns information about revisions.
	 *
	 * @param array $revisions Revisions.
	 *
	 * @return array
	 */
	public function getRevisionsData(array $revisions)
	{
		$results = array();

		$sql = 'SELECT Revision, Bug
				FROM CommitBugs
				WHERE Revision IN (:revisions)';
		$revisions_data = $this->database->fetchAll($sql, array('revisions' => $revisions));

		foreach ( $revisions_data as $revision_data ) {
			$revision = $revision_data['Revision'];
			$bug = $revision_data['Bug'];

			if ( !isset($results[$revision]) ) {
				$results[$revision] = array();
			}

			$results[$revision][] = $bug;
		}

		return $this->addMissingResults($revisions, $results);
	}

}


1		<?php
2		/**
3		* This file is part of the SVN-Buddy library.
4		* For the full copyright and license information, please view
5		* the LICENSE file that was distributed with this source code.
6		*
7		* @copyright Alexander Obuhovich <[email protected]>
8		* @link https://github.com/console-helpers/svn-buddy
9		*/
10
11		namespace ConsoleHelpers\SVNBuddy\Repository\RevisionLog\Plugin;
12
13
14		use Aura\Sql\ExtendedPdoInterface;
15		use Aura\Sql\Iterator\AllIterator;
16		use ConsoleHelpers\SVNBuddy\Repository\Connector\Connector;
17		use ConsoleHelpers\SVNBuddy\Repository\Parser\LogMessageParserFactory;
18		use ConsoleHelpers\SVNBuddy\Repository\RevisionLog\RepositoryFiller;
19
20		class BugsPlugin extends AbstractDatabaseCollectorPlugin
21		{
22
23		const STATISTIC_BUG_ADDED_TO_COMMIT = 'bug_added_to_commit';
24
25		/**
26		* Repository url.
27		*
28		* @var string
29		*/
30		private $_repositoryUrl;
31
32		/**
33		* Repository connector.
34		*
35		* @var Connector
36		*/
37		private $_repositoryConnector;
38
39		/**
40		* Log message parser factory.
41		*
42		* @var LogMessageParserFactory
43		*/
44		private $_logMessageParserFactory;
45
46		/**
47		* Create bugs revision log plugin.
48		*
49		* @param ExtendedPdoInterface $database Database.
50		* @param RepositoryFiller $repository_filler Repository filler.
51		* @param string $repository_url Repository url.
52		* @param Connector $repository_connector Repository connector.
53		* @param LogMessageParserFactory $log_message_parser_factory Log message parser.
54		*/
55	19	public function __construct(
56		ExtendedPdoInterface $database,
57		RepositoryFiller $repository_filler,
58		$repository_url,
59		Connector $repository_connector,
60		LogMessageParserFactory $log_message_parser_factory
61		) {
62	19	parent::__construct($database, $repository_filler);
63
64	19	$this->_repositoryUrl = $repository_url;
65	19	$this->_repositoryConnector = $repository_connector;
66	19	$this->_logMessageParserFactory = $log_message_parser_factory;
67	19	}
68
69		/**
70		* Returns plugin name.
71		*
72		* @return string
73		*/
74	13	public function getName()
75		{
76	13	return 'bugs';
77		}
78
79		/**
80		* Defines parsing statistic types.
81		*
82		* @return array
83		*/
84	19	public function defineStatisticTypes()
85		{
86		return array(
87	19	self::STATISTIC_BUG_ADDED_TO_COMMIT,
88		);
89		}
90
91		/**
92		* Processes data.
93		*
94		* @param integer $from_revision From revision.
95		* @param integer $to_revision To revision.
96		*
97		* @return void
98		*/
99	9	public function doProcess($from_revision, $to_revision)
100		{
101	9	$this->populateMissingBugRegExp();
102
103	9	$last_revision = $this->getLastRevision();
104
105	9	if ( $to_revision > $last_revision ) {
106	7	$this->detectBugs($last_revision + 1, $to_revision);
107	7	$this->setLastRevision($to_revision);
108		}
109	9	}
110
111		/**
112		* Populate "BugRegExp" column for projects without it.
113		*
114		* @return void
115		*/
116	9	protected function populateMissingBugRegExp()
117		{
118	9	$projects = $this->getProjects('BugRegExp IS NULL');
119
120	9	if ( !$projects ) {
121	5	$this->advanceProgressBar();
122
123	5	return;
124		}
125
126	4	foreach ( $projects as $project_data ) {
127	4	$bug_regexp = $this->detectProjectBugTraqRegEx(
128	4	$project_data['Path'],
129	4	$project_data['RevisionLastSeen'],
130	4	(bool)$project_data['IsDeleted']
131		);
132
133	4	$this->repositoryFiller->setProjectBugRegexp($project_data['Id'], $bug_regexp);
		0 ignored issues – show Bug introduced 2016-05-13 18:26 UTC by Report Bug Copy Issue Report It seems like `$bug_regexp` defined by `$this->detectProjectBugT...ject_data['IsDeleted'])` on line `127` can also be of type `object<SimpleXMLElement>`; however, `ConsoleHelpers\SVNBuddy\...::setProjectBugRegexp()` does only seem to accept `string\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
134	4	$this->advanceProgressBar();
135		}
136	4	}
137
138		/**
139		* Determines project bug tracking regular expression.
140		*
141		* @param string $project_path Project project_path.
142		* @param integer $revision Revision.
143		* @param boolean $project_deleted Project is deleted.
144		*
145		* @return string
146		*/
147	4	protected function detectProjectBugTraqRegEx($project_path, $revision, $project_deleted)
148		{
149	4	$ref_paths = $this->getLastChangedRefPaths($project_path);
150
151	4	if ( !$ref_paths ) {
152	2	return '';
153		}
154
155	2	foreach ( $ref_paths as $ref_path ) {
156	2	$logregex = $this->_repositoryConnector
157	2	->withCache('1 year')
158	2	->getProperty(
159	2	'bugtraq:logregex',
160	2	$this->_repositoryUrl . $ref_path . ($project_deleted ? '@' . $revision : '')
161		);
162
163	2	if ( strlen($logregex) ) {
164	2	return $logregex;
165		}
166		}
167
168		return '';
169		}
170
171		/**
172		* Returns given project refs, where last changed are on top.
173		*
174		* @param string $project_path Path.
175		*
176		* @return array
177		*/
178	4	protected function getLastChangedRefPaths($project_path)
179		{
180	4	$own_nesting_level = substr_count($project_path, '/') - 1;
181
182		$where_clause = array(
183	4	'Path LIKE :parent_path',
184		'PathNestingLevel BETWEEN :from_level AND :to_level',
185		'RevisionDeleted IS NULL',
186		);
187
188		$sql = 'SELECT Path, RevisionLastSeen
189		FROM Paths
190	4	WHERE (' . implode(') AND (', $where_clause) . ')';
191	4	$paths = $this->database->fetchPairs($sql, array(
192	4	'parent_path' => $project_path . '%',
193	4	'from_level' => $own_nesting_level + 1,
194	4	'to_level' => $own_nesting_level + 2,
195		));
196
197		// No sub-folders.
198	4	if ( !$paths ) {
199	1	return array();
200		}
201
202	3	$filtered_paths = array();
203
204	3	foreach ( $paths as $path => $revision ) {
205	3	if ( $this->isRef($path) ) {
206	3	$filtered_paths[$path] = $revision;
207		}
208		}
209
210		// None of sub-folders matches a ref.
211	3	if ( !$filtered_paths ) {
212	1	return array();
213		}
214
215	2	arsort($filtered_paths, SORT_NUMERIC);
216
217	2	return array_keys($filtered_paths);
218		}
219
220		/**
221		* Detects if given project_path is known project root.
222		*
223		* @param string $path Path.
224		*
225		* @return boolean
226		*/
227	3	protected function isRef($path)
228		{
229		// Not a folder.
230	3	if ( substr($path, -1, 1) !== '/' ) {
231	2	return false;
232		}
233
234	3	return $this->_repositoryConnector->isRefRoot($path);
235		}
236
237		/**
238		* Detects bugs, associated with each commit from a given revision range.
239		*
240		* @param integer $from_revision From revision.
241		* @param integer $to_revision To revision.
242		*
243		* @return void
244		*/
245	7	protected function detectBugs($from_revision, $to_revision)
246		{
247	7	$bug_regexp_mapping = $this->getProjectBugRegExps();
248
249	7	if ( !$bug_regexp_mapping ) {
250	3	$this->advanceProgressBar();
251
252	3	return;
253		}
254
255	4	$range_start = $from_revision;
256
257	4	while ( $range_start <= $to_revision ) {
258	4	$range_end = min($range_start + 999, $to_revision);
259
260	4	$this->doDetectBugs($range_start, $range_end, $bug_regexp_mapping);
261	4	$this->advanceProgressBar();
262
263	4	$range_start = $range_end + 1;
264		}
265	4	}
266
267		/**
268		* Returns "BugRegExp" field associated with every project.
269		*
270		* @return array
271		*/
272	7	protected function getProjectBugRegExps()
273		{
274	7	$projects = $this->getProjects("BugRegExp != ''");
275
276	7	if ( !$projects ) {
277	3	return array();
278		}
279
280	4	$ret = array();
281
282	4	foreach ( $projects as $project_data ) {
283	4	$ret[$project_data['Id']] = $project_data['BugRegExp'];
284		}
285
286	4	return $ret;
287		}
288
289		/**
290		* Detects bugs, associated with each commit from a given revision range.
291		*
292		* @param integer $from_revision From revision.
293		* @param integer $to_revision To revision.
294		* @param array $bug_regexp_mapping Mapping between project and it's "BugRegExp" field.
295		*
296		* @return void
297		*/
298	4	protected function doDetectBugs($from_revision, $to_revision, array $bug_regexp_mapping)
299		{
300	4	$commits_by_project = $this->getCommitsGroupedByProject($from_revision, $to_revision);
301
302	4	foreach ( $commits_by_project as $project_id => $project_commits ) {
303	4	if ( !isset($bug_regexp_mapping[$project_id]) ) {
304	1	continue;
305		}
306
307	4	$log_message_parser = $this->_logMessageParserFactory->getLogMessageParser(
308	4	$bug_regexp_mapping[$project_id]
309		);
310
311	4	foreach ( $project_commits as $revision => $log_message ) {
312	4	$bugs = $log_message_parser->parse($log_message);
313
314	4	if ( $bugs ) {
315	3	$this->repositoryFiller->addBugsToCommit($bugs, $revision);
316	4	$this->recordStatistic(self::STATISTIC_BUG_ADDED_TO_COMMIT, count($bugs));
317		}
318		}
319		}
320	4	}
321
322		/**
323		* Returns commits grouped by project.
324		*
325		* @param integer $from_revision From revision.
326		* @param integer $to_revision To revision.
327		*
328		* @return array
329		*/
330	4	protected function getCommitsGroupedByProject($from_revision, $to_revision)
331		{
332	4	$sql = 'SELECT cp.Revision, c.Message, cp.ProjectId
333		FROM CommitProjects cp
334		JOIN Commits c ON c.Revision = cp.Revision
335		WHERE cp.Revision BETWEEN :from_revision AND :to_revision';
336	4	$commits = new AllIterator($this->database->perform($sql, array(
337	4	'from_revision' => $from_revision,
338	4	'to_revision' => $to_revision,
339		)));
340
341	4	$ret = array();
342	4	$processed_revisions = array();
343
344	4	foreach ( $commits as $commit_data ) {
345	4	$revision = $commit_data['Revision'];
346
347		// Don't process revision more then once (e.g. when commit belongs to different projects).
348	4	if ( isset($processed_revisions[$revision]) ) {
349	1	continue;
350		}
351
352	4	$project_id = $commit_data['ProjectId'];
353
354	4	if ( !isset($ret[$project_id]) ) {
355	4	$ret[$project_id] = array();
356		}
357
358	4	$ret[$project_id][$revision] = $commit_data['Message'];
359	4	$processed_revisions[$revision] = true;
360		}
361
362	4	return $ret;
363		}
364
365		/**
366		* Find revisions by collected data.
367		*
368		* @param array $criteria Criteria.
369		* @param string $project_path Project path.
370		*
371		* @return array
372		*/
373	5	public function find(array $criteria, $project_path)
374		{
375	5	if ( !$criteria ) {
376	1	return array();
377		}
378
379	4	$project_id = $this->getProject($project_path);
380
381	3	$sql = 'SELECT DISTINCT cb.Revision
382		FROM CommitBugs cb
383		JOIN CommitProjects cp ON cp.Revision = cb.Revision
384		WHERE cp.ProjectId = :project_id AND cb.Bug IN (:bugs)';
385	3	$bug_revisions = $this->database->fetchCol($sql, array('project_id' => $project_id, 'bugs' => $criteria));
386
387	3	sort($bug_revisions, SORT_NUMERIC);
388
389	3	return $bug_revisions;
390		}
391
392		/**
393		* Returns information about revisions.
394		*
395		* @param array $revisions Revisions.
396		*
397		* @return array
398		*/
399	1	public function getRevisionsData(array $revisions)
400		{
401	1	$results = array();
402
403	1	$sql = 'SELECT Revision, Bug
404		FROM CommitBugs
405		WHERE Revision IN (:revisions)';
406	1	$revisions_data = $this->database->fetchAll($sql, array('revisions' => $revisions));
407
408	1	foreach ( $revisions_data as $revision_data ) {
409	1	$revision = $revision_data['Revision'];
410	1	$bug = $revision_data['Bug'];
411
412	1	if ( !isset($results[$revision]) ) {
413	1	$results[$revision] = array();
414		}
415
416	1	$results[$revision][] = $bug;
417		}
418
419	1	return $this->addMissingResults($revisions, $results);
420		}
421
422		}
423

console-helpers / svn-buddy

Pull Request — master (#114)

BugsPlugin::doDetectBugs() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like