@@ -369,7 +369,7 @@ |
||
369 | 369 | /** |
370 | 370 | * Returns list of config settings. |
371 | 371 | * |
372 | - * @return AbstractConfigSetting[] |
|
372 | + * @return PathsConfigSetting[] |
|
373 | 373 | */ |
374 | 374 | public function getConfigSettings() |
375 | 375 | { |
@@ -317,8 +317,7 @@ discard block |
||
317 | 317 | |
318 | 318 | if ( $all_working_copies_count != $working_copies_count ) { |
319 | 319 | $ignored_suffix = ' (' . ($all_working_copies_count - $working_copies_count) . ' ignored)'; |
320 | - } |
|
321 | - else { |
|
320 | + } else { |
|
322 | 321 | $ignored_suffix = ''; |
323 | 322 | } |
324 | 323 | |
@@ -357,8 +356,7 @@ discard block |
||
357 | 356 | |
358 | 357 | if ( $this->repositoryConnector->isWorkingCopy($sub_folder) ) { |
359 | 358 | $working_copies[] = $sub_folder; |
360 | - } |
|
361 | - else { |
|
359 | + } else { |
|
362 | 360 | $working_copies = array_merge($working_copies, $this->getWorkingCopiesRecursive($sub_folder)); |
363 | 361 | } |
364 | 362 | } |
@@ -203,7 +203,7 @@ |
||
203 | 203 | * |
204 | 204 | * @param mixed $value Value. |
205 | 205 | * |
206 | - * @return mixed |
|
206 | + * @return string |
|
207 | 207 | */ |
208 | 208 | protected function openEditor($value) |
209 | 209 | { |
@@ -185,8 +185,7 @@ discard block |
||
185 | 185 | $value = $this->openEditor($value); |
186 | 186 | $config_setting->setValue($value, $this->getScopeFilter()); |
187 | 187 | $this->io->writeln('Setting <info>' . $setting_name . '</info> was edited.'); |
188 | - } |
|
189 | - catch ( \InvalidArgumentException $e ) { |
|
188 | + } catch ( \InvalidArgumentException $e ) { |
|
190 | 189 | $this->io->writeln(array('<error>' . $e->getMessage() . '</error>', '')); |
191 | 190 | |
192 | 191 | if ( $this->io->askConfirmation('Retry editing', false) ) { |
@@ -250,8 +249,7 @@ discard block |
||
250 | 249 | |
251 | 250 | if ( $this->isGlobal() ) { |
252 | 251 | $this->io->writeln('Showing global settings' . $extra_title . ':'); |
253 | - } |
|
254 | - else { |
|
252 | + } else { |
|
255 | 253 | $this->io->writeln( |
256 | 254 | 'Showing settings' . $extra_title . ' for <info>' . $this->getWorkingCopyPath() . '</info> path:' |
257 | 255 | ); |
@@ -549,7 +549,7 @@ |
||
549 | 549 | /** |
550 | 550 | * Returns list of config settings. |
551 | 551 | * |
552 | - * @return AbstractConfigSetting[] |
|
552 | + * @return StringConfigSetting[] |
|
553 | 553 | */ |
554 | 554 | public function getConfigSettings() |
555 | 555 | { |
@@ -178,12 +178,10 @@ discard block |
||
178 | 178 | |
179 | 179 | if ( $this->shouldMergeAll($revisions) ) { |
180 | 180 | $revisions = $this->_unmergedRevisions; |
181 | - } |
|
182 | - else { |
|
181 | + } else { |
|
183 | 182 | if ( $revisions ) { |
184 | 183 | $revisions = $this->getDirectRevisions($revisions, $source_url); |
185 | - } |
|
186 | - elseif ( $bugs ) { |
|
184 | + } elseif ( $bugs ) { |
|
187 | 185 | $revisions = $this->getRevisionLog($source_url)->find('bugs', $bugs); |
188 | 186 | } |
189 | 187 | |
@@ -198,8 +196,7 @@ discard block |
||
198 | 196 | |
199 | 197 | if ( $revisions ) { |
200 | 198 | $this->performMerge($source_url, $wc_path, $revisions); |
201 | - } |
|
202 | - elseif ( $this->_unmergedRevisions ) { |
|
199 | + } elseif ( $this->_unmergedRevisions ) { |
|
203 | 200 | $this->runOtherCommand('log', array( |
204 | 201 | 'path' => $this->repositoryConnector->getProjectUrl($source_url), |
205 | 202 | '--revisions' => implode(',', $this->_unmergedRevisions), |
@@ -342,8 +339,7 @@ discard block |
||
342 | 339 | $unmerged_bugs = $revision_log->getBugsFromRevisions($unmerged_revisions); |
343 | 340 | $error_msg = '<error>%d revision(-s) or %d bug(-s) not merged</error>'; |
344 | 341 | $this->io->writeln(sprintf($error_msg, count($unmerged_revisions), count($unmerged_bugs))); |
345 | - } |
|
346 | - else { |
|
342 | + } else { |
|
347 | 343 | $this->io->writeln('<info>Up to date</info>'); |
348 | 344 | } |
349 | 345 | |
@@ -426,8 +422,7 @@ discard block |
||
426 | 422 | foreach ( $revisions as $revision ) { |
427 | 423 | $revision_log->getRevisionData('summary', $revision); |
428 | 424 | } |
429 | - } |
|
430 | - catch ( \InvalidArgumentException $e ) { |
|
425 | + } catch ( \InvalidArgumentException $e ) { |
|
431 | 426 | throw new CommandException($e->getMessage()); |
432 | 427 | } |
433 | 428 | |
@@ -495,8 +490,7 @@ discard block |
||
495 | 490 | 'Path', |
496 | 491 | 'Associated Revisions (before ' . $largest_suggested_revision . ')', |
497 | 492 | )); |
498 | - } |
|
499 | - else { |
|
493 | + } else { |
|
500 | 494 | $table->setHeaders(array( |
501 | 495 | 'Path', |
502 | 496 | 'Associated Revisions', |
@@ -155,7 +155,7 @@ |
||
155 | 155 | /** |
156 | 156 | * Returns cache invalidator for this plugin data. |
157 | 157 | * |
158 | - * @return string |
|
158 | + * @return integer |
|
159 | 159 | */ |
160 | 160 | public function getCacheInvalidator() |
161 | 161 | { |
@@ -153,7 +153,7 @@ |
||
153 | 153 | /** |
154 | 154 | * Returns cache invalidator for this plugin data. |
155 | 155 | * |
156 | - * @return string |
|
156 | + * @return integer |
|
157 | 157 | */ |
158 | 158 | public function getCacheInvalidator() |
159 | 159 | { |
@@ -88,8 +88,7 @@ |
||
88 | 88 | |
89 | 89 | if ( $first_criteria === 'all_merges' ) { |
90 | 90 | return array_keys($this->_mergeRevisions); |
91 | - } |
|
92 | - elseif ( $first_criteria === 'all_merged' ) { |
|
91 | + } elseif ( $first_criteria === 'all_merged' ) { |
|
93 | 92 | return array_keys($this->_mergedRevisions); |
94 | 93 | } |
95 | 94 |
@@ -149,7 +149,7 @@ |
||
149 | 149 | /** |
150 | 150 | * Returns cache invalidator for this plugin data. |
151 | 151 | * |
152 | - * @return string |
|
152 | + * @return integer |
|
153 | 153 | */ |
154 | 154 | public function getCacheInvalidator() |
155 | 155 | { |
@@ -119,7 +119,7 @@ |
||
119 | 119 | /** |
120 | 120 | * Returns format version. |
121 | 121 | * |
122 | - * @return mixed |
|
122 | + * @return string |
|
123 | 123 | */ |
124 | 124 | private function _getCacheInvalidator() |
125 | 125 | { |
@@ -155,7 +155,7 @@ |
||
155 | 155 | /** |
156 | 156 | * Returns cache invalidator for this plugin data. |
157 | 157 | * |
158 | - * @return string |
|
158 | + * @return integer |
|
159 | 159 | */ |
160 | 160 | public function getCacheInvalidator() |
161 | 161 | { |
@@ -95,8 +95,7 @@ |
||
95 | 95 | foreach ( $this->_authorRevisions[$value] as $revision ) { |
96 | 96 | $summary_revisions[$revision] = true; |
97 | 97 | } |
98 | - } |
|
99 | - else { |
|
98 | + } else { |
|
100 | 99 | $error_msg = 'Searching by "%s" is not supported by "%s" plugin.'; |
101 | 100 | throw new \InvalidArgumentException(sprintf($error_msg, $field, $this->getName())); |
102 | 101 | } |
@@ -238,8 +238,7 @@ |
||
238 | 238 | |
239 | 239 | if ( !$this->repositoryConnector->isUrl($path) ) { |
240 | 240 | $path = realpath($path); |
241 | - } |
|
242 | - elseif ( !$this->pathAcceptsUrl ) { |
|
241 | + } elseif ( !$this->pathAcceptsUrl ) { |
|
243 | 242 | throw new \RuntimeException('The "path" argument must be a working copy path and not URL.'); |
244 | 243 | } |
245 | 244 |