Complex classes like Connector often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Connector, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | class Connector |
||
| 24 | { |
||
| 25 | |||
| 26 | const STATUS_UNVERSIONED = 'unversioned'; |
||
| 27 | |||
| 28 | const URL_REGEXP = '#([\w]*)://([^/@\s\']+@)?([^/@:\s\']+)(:\d+)?([^@\s\']*)?#'; |
||
| 29 | |||
| 30 | /** |
||
| 31 | * Reference to configuration. |
||
| 32 | * |
||
| 33 | * @var ConfigEditor |
||
| 34 | */ |
||
| 35 | private $_configEditor; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * Process factory. |
||
| 39 | * |
||
| 40 | * @var IProcessFactory |
||
| 41 | */ |
||
| 42 | private $_processFactory; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * Console IO. |
||
| 46 | * |
||
| 47 | * @var ConsoleIO |
||
| 48 | */ |
||
| 49 | private $_io; |
||
| 50 | |||
| 51 | /** |
||
| 52 | * Cache manager. |
||
| 53 | * |
||
| 54 | * @var CacheManager |
||
| 55 | */ |
||
| 56 | private $_cacheManager; |
||
| 57 | |||
| 58 | /** |
||
| 59 | * Path to an svn command. |
||
| 60 | * |
||
| 61 | * @var string |
||
| 62 | */ |
||
| 63 | private $_svnCommand = 'svn'; |
||
| 64 | |||
| 65 | /** |
||
| 66 | * Cache duration for next invoked command. |
||
| 67 | * |
||
| 68 | * @var mixed |
||
| 69 | */ |
||
| 70 | private $_nextCommandCacheDuration = null; |
||
| 71 | |||
| 72 | /** |
||
| 73 | * Whatever to cache last repository revision or not. |
||
| 74 | * |
||
| 75 | * @var mixed |
||
| 76 | */ |
||
| 77 | private $_lastRevisionCacheDuration = null; |
||
| 78 | |||
| 79 | /** |
||
| 80 | * Creates repository connector. |
||
| 81 | * |
||
| 82 | * @param ConfigEditor $config_editor ConfigEditor. |
||
| 83 | * @param IProcessFactory $process_factory Process factory. |
||
| 84 | * @param ConsoleIO $io Console IO. |
||
| 85 | * @param CacheManager $cache_manager Cache manager. |
||
| 86 | */ |
||
| 87 | 58 | public function __construct( |
|
| 108 | |||
| 109 | /** |
||
| 110 | * Prepares static part of svn command to be used across the script. |
||
| 111 | * |
||
| 112 | * @return void |
||
| 113 | */ |
||
| 114 | 58 | protected function prepareSvnCommand() |
|
| 129 | |||
| 130 | /** |
||
| 131 | * Builds a command. |
||
| 132 | * |
||
| 133 | * @param string $sub_command Sub command. |
||
| 134 | * @param string|null $param_string Parameter string. |
||
| 135 | * |
||
| 136 | * @return Command |
||
| 137 | */ |
||
| 138 | 32 | public function getCommand($sub_command, $param_string = null) |
|
| 155 | |||
| 156 | /** |
||
| 157 | * Builds command from given arguments. |
||
| 158 | * |
||
| 159 | * @param string $sub_command Command. |
||
| 160 | * @param string $param_string Parameter string. |
||
| 161 | * |
||
| 162 | * @return string |
||
| 163 | * @throws \InvalidArgumentException When command contains spaces. |
||
| 164 | */ |
||
| 165 | 32 | protected function buildCommand($sub_command, $param_string = null) |
|
| 191 | |||
| 192 | /** |
||
| 193 | * Sets cache configuration for next created command. |
||
| 194 | * |
||
| 195 | * @param mixed $cache_duration Cache duration. |
||
| 196 | * |
||
| 197 | * @return self |
||
| 198 | */ |
||
| 199 | 20 | public function withCache($cache_duration) |
|
| 205 | |||
| 206 | /** |
||
| 207 | * Returns property value. |
||
| 208 | * |
||
| 209 | * @param string $name Property name. |
||
| 210 | * @param string $path_or_url Path to get property from. |
||
| 211 | * @param mixed $revision Revision. |
||
| 212 | * |
||
| 213 | * @return string |
||
| 214 | */ |
||
| 215 | 2 | public function getProperty($name, $path_or_url, $revision = null) |
|
| 225 | |||
| 226 | /** |
||
| 227 | * Returns relative path of given path/url to the root of the repository. |
||
| 228 | * |
||
| 229 | * @param string $path_or_url Path or url. |
||
| 230 | * |
||
| 231 | * @return string |
||
| 232 | */ |
||
| 233 | 3 | public function getRelativePath($path_or_url) |
|
| 240 | |||
| 241 | /** |
||
| 242 | * Returns repository root url from given path/url. |
||
| 243 | * |
||
| 244 | * @param string $path_or_url Path or url. |
||
| 245 | * |
||
| 246 | * @return string |
||
| 247 | */ |
||
| 248 | 6 | public function getRootUrl($path_or_url) |
|
| 252 | |||
| 253 | /** |
||
| 254 | * Detects ref from given path. |
||
| 255 | * |
||
| 256 | * @param string $path Path to a file. |
||
| 257 | * |
||
| 258 | * @return string|boolean |
||
| 259 | * @see getProjectUrl |
||
| 260 | */ |
||
| 261 | 9 | public function getRefByPath($path) |
|
| 269 | |||
| 270 | /** |
||
| 271 | * Returns URL of the working copy. |
||
| 272 | * |
||
| 273 | * @param string $wc_path Working copy path. |
||
| 274 | * |
||
| 275 | * @return string |
||
| 276 | * @throws RepositoryCommandException When repository command failed to execute. |
||
| 277 | */ |
||
| 278 | 8 | public function getWorkingCopyUrl($wc_path) |
|
| 305 | |||
| 306 | /** |
||
| 307 | * Returns last changed revision on path/url. |
||
| 308 | * |
||
| 309 | * @param string $path_or_url Path or url. |
||
| 310 | * |
||
| 311 | * @return integer |
||
| 312 | */ |
||
| 313 | 7 | public function getLastRevision($path_or_url) |
|
| 320 | |||
| 321 | /** |
||
| 322 | * Determines if given path is in fact an url. |
||
| 323 | * |
||
| 324 | * @param string $path Path. |
||
| 325 | * |
||
| 326 | * @return boolean |
||
| 327 | */ |
||
| 328 | 24 | public function isUrl($path) |
|
| 332 | |||
| 333 | /** |
||
| 334 | * Removes credentials from url. |
||
| 335 | * |
||
| 336 | * @param string $url URL. |
||
| 337 | * |
||
| 338 | * @return string |
||
| 339 | * @throws \InvalidArgumentException When non-url given. |
||
| 340 | */ |
||
| 341 | 15 | public function removeCredentials($url) |
|
| 349 | |||
| 350 | /** |
||
| 351 | * Returns project url (container for "trunk/branches/tags/releases" folders). |
||
| 352 | * |
||
| 353 | * @param string $repository_url Repository url. |
||
| 354 | * |
||
| 355 | * @return string |
||
| 356 | * @see getRefByPath |
||
| 357 | */ |
||
| 358 | 9 | public function getProjectUrl($repository_url) |
|
| 367 | |||
| 368 | /** |
||
| 369 | * Returns "svn info" entry for path or url. |
||
| 370 | * |
||
| 371 | * @param string $path_or_url Path or url. |
||
| 372 | * @param mixed $cache_duration Cache duration. |
||
| 373 | * |
||
| 374 | * @return \SimpleXMLElement |
||
| 375 | * @throws \LogicException When unexpected 'svn info' results retrieved. |
||
| 376 | */ |
||
| 377 | 19 | private function _getSvnInfoEntry($path_or_url, $cache_duration = null) |
|
| 406 | |||
| 407 | /** |
||
| 408 | * Returns path of "svn info" entry. |
||
| 409 | * |
||
| 410 | * @param \SimpleXMLElement $svn_info_entry The "entry" node of "svn info" command. |
||
| 411 | * |
||
| 412 | * @return string |
||
| 413 | */ |
||
| 414 | 17 | private function _getSvnInfoEntryPath(\SimpleXMLElement $svn_info_entry) |
|
| 426 | |||
| 427 | /** |
||
| 428 | * Returns revision, when path was added to repository. |
||
| 429 | * |
||
| 430 | * @param string $url Url. |
||
| 431 | * |
||
| 432 | * @return integer |
||
| 433 | * @throws \InvalidArgumentException When not an url was given. |
||
| 434 | */ |
||
| 435 | public function getFirstRevision($url) |
||
| 445 | |||
| 446 | /** |
||
| 447 | * Returns conflicts in working copy. |
||
| 448 | * |
||
| 449 | * @param string $wc_path Working copy path. |
||
| 450 | * |
||
| 451 | * @return array |
||
| 452 | */ |
||
| 453 | public function getWorkingCopyConflicts($wc_path) |
||
| 465 | |||
| 466 | /** |
||
| 467 | * Returns compact working copy status. |
||
| 468 | * |
||
| 469 | * @param string $wc_path Working copy path. |
||
| 470 | * @param boolean $with_unversioned With unversioned. |
||
| 471 | * |
||
| 472 | * @return string |
||
| 473 | */ |
||
| 474 | public function getCompactWorkingCopyStatus($wc_path, $with_unversioned = true) |
||
| 491 | |||
| 492 | /** |
||
| 493 | * Returns short item status. |
||
| 494 | * |
||
| 495 | * @param string $status Status. |
||
| 496 | * |
||
| 497 | * @return string |
||
| 498 | * @throws \InvalidArgumentException When unknown status given. |
||
| 499 | */ |
||
| 500 | protected function getShortItemStatus($status) |
||
| 525 | |||
| 526 | /** |
||
| 527 | * Returns short item status. |
||
| 528 | * |
||
| 529 | * @param string $status Status. |
||
| 530 | * |
||
| 531 | * @return string |
||
| 532 | * @throws \InvalidArgumentException When unknown status given. |
||
| 533 | */ |
||
| 534 | protected function getShortPropertiesStatus($status) |
||
| 549 | |||
| 550 | /** |
||
| 551 | * Returns working copy status. |
||
| 552 | * |
||
| 553 | * @param string $wc_path Working copy path. |
||
| 554 | * |
||
| 555 | * @return array |
||
| 556 | */ |
||
| 557 | public function getWorkingCopyStatus($wc_path) |
||
| 587 | |||
| 588 | /** |
||
| 589 | * Determines if working copy contains mixed revisions. |
||
| 590 | * |
||
| 591 | * @param string $wc_path Working copy path. |
||
| 592 | * |
||
| 593 | * @return array |
||
| 594 | */ |
||
| 595 | public function isMixedRevisionWorkingCopy($wc_path) |
||
| 617 | |||
| 618 | /** |
||
| 619 | * Determines if there is a working copy on a given path. |
||
| 620 | * |
||
| 621 | * @param string $path Path. |
||
| 622 | * |
||
| 623 | * @return boolean |
||
| 624 | * @throws \InvalidArgumentException When path isn't found. |
||
| 625 | * @throws RepositoryCommandException When repository command failed to execute. |
||
| 626 | */ |
||
|
1 ignored issue
–
show
|
|||
| 627 | public function isWorkingCopy($path) |
||
| 646 | |||
| 647 | } |
||
| 648 |