Complex classes like Connector often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Connector, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
23 | class Connector |
||
24 | { |
||
25 | |||
26 | const STATUS_UNVERSIONED = 'unversioned'; |
||
27 | |||
28 | const URL_REGEXP = '#([\w]*)://([^@\s\']+@)?([^/:\s\']+)(:\d+)?([^\s\']*)?#'; |
||
29 | |||
30 | /** |
||
31 | * Reference to configuration. |
||
32 | * |
||
33 | * @var ConfigEditor |
||
34 | */ |
||
35 | private $_configEditor; |
||
36 | |||
37 | /** |
||
38 | * Process factory. |
||
39 | * |
||
40 | * @var IProcessFactory |
||
41 | */ |
||
42 | private $_processFactory; |
||
43 | |||
44 | /** |
||
45 | * Console IO. |
||
46 | * |
||
47 | * @var ConsoleIO |
||
48 | */ |
||
49 | private $_io; |
||
50 | |||
51 | /** |
||
52 | * Cache manager. |
||
53 | * |
||
54 | * @var CacheManager |
||
55 | */ |
||
56 | private $_cacheManager; |
||
57 | |||
58 | /** |
||
59 | * Path to an svn command. |
||
60 | * |
||
61 | * @var string |
||
62 | */ |
||
63 | private $_svnCommand = 'svn'; |
||
64 | |||
65 | /** |
||
66 | * Cache duration for next invoked command. |
||
67 | * |
||
68 | * @var mixed |
||
69 | */ |
||
70 | private $_nextCommandCacheDuration = null; |
||
71 | |||
72 | /** |
||
73 | * Whatever to cache last repository revision or not. |
||
74 | * |
||
75 | * @var mixed |
||
76 | */ |
||
77 | private $_lastRevisionCacheDuration = null; |
||
78 | |||
79 | /** |
||
80 | * Creates repository connector. |
||
81 | * |
||
82 | * @param ConfigEditor $config_editor ConfigEditor. |
||
83 | * @param IProcessFactory $process_factory Process factory. |
||
84 | * @param ConsoleIO $io Console IO. |
||
85 | * @param CacheManager $cache_manager Cache manager. |
||
86 | */ |
||
87 | 57 | public function __construct( |
|
108 | |||
109 | /** |
||
110 | * Prepares static part of svn command to be used across the script. |
||
111 | * |
||
112 | * @return void |
||
113 | */ |
||
114 | 57 | protected function prepareSvnCommand() |
|
129 | |||
130 | /** |
||
131 | * Builds a command. |
||
132 | * |
||
133 | * @param string $sub_command Sub command. |
||
134 | * @param string|null $param_string Parameter string. |
||
135 | * |
||
136 | * @return Command |
||
137 | */ |
||
138 | 32 | public function getCommand($sub_command, $param_string = null) |
|
155 | |||
156 | /** |
||
157 | * Builds command from given arguments. |
||
158 | * |
||
159 | * @param string $sub_command Command. |
||
160 | * @param string $param_string Parameter string. |
||
161 | * |
||
162 | * @return string |
||
163 | * @throws \InvalidArgumentException When command contains spaces. |
||
164 | */ |
||
165 | 32 | protected function buildCommand($sub_command, $param_string = null) |
|
191 | |||
192 | /** |
||
193 | * Sets cache configuration for next created command. |
||
194 | * |
||
195 | * @param mixed $cache_duration Cache duration. |
||
196 | * |
||
197 | * @return self |
||
198 | */ |
||
199 | 20 | public function withCache($cache_duration) |
|
205 | |||
206 | /** |
||
207 | * Returns property value. |
||
208 | * |
||
209 | * @param string $name Property name. |
||
210 | * @param string $path_or_url Path to get property from. |
||
211 | * @param mixed $revision Revision. |
||
212 | * |
||
213 | * @return string |
||
214 | */ |
||
215 | 2 | public function getProperty($name, $path_or_url, $revision = null) |
|
225 | |||
226 | /** |
||
227 | * Returns relative path of given path/url to the root of the repository. |
||
228 | * |
||
229 | * @param string $path_or_url Path or url. |
||
230 | * |
||
231 | * @return string |
||
232 | */ |
||
233 | 3 | public function getRelativePath($path_or_url) |
|
240 | |||
241 | /** |
||
242 | * Returns repository root url from given path/url. |
||
243 | * |
||
244 | * @param string $path_or_url Path or url. |
||
245 | * |
||
246 | * @return string |
||
247 | */ |
||
248 | 6 | public function getRootUrl($path_or_url) |
|
252 | |||
253 | /** |
||
254 | * Detects ref from given path. |
||
255 | * |
||
256 | * @param string $path Path to a file. |
||
257 | * |
||
258 | * @return string|boolean |
||
259 | */ |
||
260 | 9 | public function getRefByPath($path) |
|
268 | |||
269 | /** |
||
270 | * Returns URL of the working copy. |
||
271 | * |
||
272 | * @param string $wc_path Working copy path. |
||
273 | * |
||
274 | * @return string |
||
275 | * @throws RepositoryCommandException When repository command failed to execute. |
||
276 | */ |
||
277 | 8 | public function getWorkingCopyUrl($wc_path) |
|
304 | |||
305 | /** |
||
306 | * Returns last changed revision on path/url. |
||
307 | * |
||
308 | * @param string $path_or_url Path or url. |
||
309 | * |
||
310 | * @return integer |
||
311 | */ |
||
312 | 7 | public function getLastRevision($path_or_url) |
|
319 | |||
320 | /** |
||
321 | * Determines if given path is in fact an url. |
||
322 | * |
||
323 | * @param string $path Path. |
||
324 | * |
||
325 | * @return boolean |
||
326 | */ |
||
327 | 24 | public function isUrl($path) |
|
331 | |||
332 | /** |
||
333 | * Removes credentials from url. |
||
334 | * |
||
335 | * @param string $url URL. |
||
336 | * |
||
337 | * @return string |
||
338 | * @throws \InvalidArgumentException When non-url given. |
||
339 | */ |
||
340 | 15 | public function removeCredentials($url) |
|
348 | |||
349 | /** |
||
350 | * Returns project url (container for "trunk/branches/tags/releases" folders). |
||
351 | * |
||
352 | * @param string $repository_url Repository url. |
||
353 | * |
||
354 | * @return string |
||
355 | */ |
||
356 | 9 | public function getProjectUrl($repository_url) |
|
364 | |||
365 | /** |
||
366 | * Returns "svn info" entry for path or url. |
||
367 | * |
||
368 | * @param string $path_or_url Path or url. |
||
369 | * @param mixed $cache_duration Cache duration. |
||
370 | * |
||
371 | * @return \SimpleXMLElement |
||
372 | * @throws \LogicException When unexpected 'svn info' results retrieved. |
||
373 | */ |
||
374 | 19 | private function _getSvnInfoEntry($path_or_url, $cache_duration = null) |
|
396 | |||
397 | /** |
||
398 | * Returns path of "svn info" entry. |
||
399 | * |
||
400 | * @param \SimpleXMLElement $svn_info_entry The "entry" node of "svn info" command. |
||
401 | * |
||
402 | * @return string |
||
403 | */ |
||
404 | 17 | private function _getSvnInfoEntryPath(\SimpleXMLElement $svn_info_entry) |
|
416 | |||
417 | /** |
||
418 | * Returns revision, when path was added to repository. |
||
419 | * |
||
420 | * @param string $url Url. |
||
421 | * |
||
422 | * @return integer |
||
423 | * @throws \InvalidArgumentException When not an url was given. |
||
424 | */ |
||
425 | public function getFirstRevision($url) |
||
435 | |||
436 | /** |
||
437 | * Returns conflicts in working copy. |
||
438 | * |
||
439 | * @param string $wc_path Working copy path. |
||
440 | * |
||
441 | * @return array |
||
442 | */ |
||
443 | public function getWorkingCopyConflicts($wc_path) |
||
455 | |||
456 | /** |
||
457 | * Returns compact working copy status. |
||
458 | * |
||
459 | * @param string $wc_path Working copy path. |
||
460 | * @param boolean $with_unversioned With unversioned. |
||
461 | * |
||
462 | * @return string |
||
463 | */ |
||
464 | public function getCompactWorkingCopyStatus($wc_path, $with_unversioned = true) |
||
481 | |||
482 | /** |
||
483 | * Returns short item status. |
||
484 | * |
||
485 | * @param string $status Status. |
||
486 | * |
||
487 | * @return string |
||
488 | * @throws \InvalidArgumentException When unknown status given. |
||
489 | */ |
||
490 | protected function getShortItemStatus($status) |
||
515 | |||
516 | /** |
||
517 | * Returns short item status. |
||
518 | * |
||
519 | * @param string $status Status. |
||
520 | * |
||
521 | * @return string |
||
522 | * @throws \InvalidArgumentException When unknown status given. |
||
523 | */ |
||
524 | protected function getShortPropertiesStatus($status) |
||
539 | |||
540 | /** |
||
541 | * Returns working copy status. |
||
542 | * |
||
543 | * @param string $wc_path Working copy path. |
||
544 | * |
||
545 | * @return array |
||
546 | */ |
||
547 | public function getWorkingCopyStatus($wc_path) |
||
577 | |||
578 | /** |
||
579 | * Determines if working copy contains mixed revisions. |
||
580 | * |
||
581 | * @param string $wc_path Working copy path. |
||
582 | * |
||
583 | * @return array |
||
584 | */ |
||
585 | public function isMixedRevisionWorkingCopy($wc_path) |
||
607 | |||
608 | /** |
||
609 | * Determines if there is a working copy on a given path. |
||
610 | * |
||
611 | * @param string $path Path. |
||
612 | * |
||
613 | * @return boolean |
||
614 | * @throws \InvalidArgumentException When path isn't found. |
||
615 | * @throws RepositoryCommandException When repository command failed to execute. |
||
616 | */ |
||
1 ignored issue
–
show
|
|||
617 | public function isWorkingCopy($path) |
||
636 | |||
637 | } |
||
638 |