Inspection of "Fixing the build" - console-helpers/phpunit-compat - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

by Alexander

created 2024-02-19 19:55 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -14,7 +14,7 @@  discard block
 block discarded – undo
 use PHPUnit\Framework\TestResult;
 use PHPUnit\Runner\Version;
 
-if ( \class_exists('PHPUnit\Runner\Version') ) {
+if (\class_exists('PHPUnit\Runner\Version')) {
 	$runner_version = Version::id();
 }
 else {
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
 }
 
 
-if ( version_compare($runner_version, '6.0.0', '<') ) {
+if (version_compare($runner_version, '6.0.0', '<')) {
 	require_once __DIR__ . '/AbstractPHPUnitCompatibilityTestSuite5.php';
 }
 else {

Please login to merge, or discard this patch.

src/PHPUnitCompat/AbstractPHPUnitCompatibilityTestCase5.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@  discard block
 block discarded – undo
 
 use PHPUnit\Framework\TestCase;
 
-if ( version_compare($runner_version, '5.0.0', '<') ) {
+if (version_compare($runner_version, '5.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 4
 	 */
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
 
 	}
 }
-elseif ( version_compare($runner_version, '6.0.0', '<') ) {
+elseif (version_compare($runner_version, '6.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 5
 	 */

Please login to merge, or discard this patch.

src/PHPUnitCompat/AbstractPHPUnitCompatibilityTestCase.php 1 patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -13,63 +13,63 @@  discard block
 block discarded – undo
 
 use PHPUnit\Runner\Version;
 
-if ( \class_exists('\PHPUnit_Framework_IncompleteTestError') ) {
+if (\class_exists('\PHPUnit_Framework_IncompleteTestError')) {
 	\class_alias('\PHPUnit_Framework_IncompleteTestError', '\ConsoleHelpers\PHPUnitCompat\Framework\IncompleteTestError');
 }
 else {
 	\class_alias('\PHPUnit\Framework\IncompleteTestError', '\ConsoleHelpers\PHPUnitCompat\Framework\IncompleteTestError');
 }
 
-if ( class_exists('\PHPUnit_Framework_SkippedTestError') ) {
+if (class_exists('\PHPUnit_Framework_SkippedTestError')) {
 	\class_alias('\PHPUnit_Framework_SkippedTestError', '\ConsoleHelpers\PHPUnitCompat\Framework\SkippedTestError');
 }
 else {
 	\class_alias('\PHPUnit\Framework\SkippedTestError', '\ConsoleHelpers\PHPUnitCompat\Framework\SkippedTestError');
 }
 
-if ( class_exists('\PHPUnit_Framework_TestSuite_DataProvider') ) {
+if (class_exists('\PHPUnit_Framework_TestSuite_DataProvider')) {
 	\class_alias('\PHPUnit_Framework_TestSuite_DataProvider', '\ConsoleHelpers\PHPUnitCompat\Framework\DataProviderTestSuite');
 }
 else {
 	\class_alias('\PHPUnit\Framework\DataProviderTestSuite', '\ConsoleHelpers\PHPUnitCompat\Framework\DataProviderTestSuite');
 }
 
-if ( class_exists('\PHPUnit_Framework_TestResult') ) {
+if (class_exists('\PHPUnit_Framework_TestResult')) {
 	\class_alias('\PHPUnit_Framework_TestResult', '\ConsoleHelpers\PHPUnitCompat\Framework\TestResult');
 }
 else {
 	\class_alias('\PHPUnit\Framework\TestResult', '\ConsoleHelpers\PHPUnitCompat\Framework\TestResult');
 }
 
-if ( class_exists('\PHPUnit_Framework_Test') ) {
+if (class_exists('\PHPUnit_Framework_Test')) {
 	\class_alias('\PHPUnit_Framework_Test', '\ConsoleHelpers\PHPUnitCompat\Framework\Test');
 }
 else {
 	\class_alias('\PHPUnit\Framework\Test', '\ConsoleHelpers\PHPUnitCompat\Framework\Test');
 }
 
-if ( class_exists('\PHP_CodeCoverage') ) {
+if (class_exists('\PHP_CodeCoverage')) {
 	\class_alias('\PHP_CodeCoverage', '\aik099\SebastianBergmann\CodeCoverage\CodeCoverage');
 }
 else {
 	\class_alias('\SebastianBergmann\CodeCoverage\CodeCoverage', '\aik099\SebastianBergmann\CodeCoverage\CodeCoverage');
 }
 
-if ( \interface_exists('\PHP_CodeCoverage_Driver') ) {
+if (\interface_exists('\PHP_CodeCoverage_Driver')) {
 	\class_alias('\PHP_CodeCoverage_Driver', '\aik099\SebastianBergmann\CodeCoverage\Driver\Driver');
 }
 else {
 	\class_alias('\SebastianBergmann\CodeCoverage\Driver\Driver', '\aik099\SebastianBergmann\CodeCoverage\Driver\Driver');
 }
 
-if ( class_exists('\PHP_CodeCoverage_Filter') ) {
+if (class_exists('\PHP_CodeCoverage_Filter')) {
 	\class_alias('\PHP_CodeCoverage_Filter', '\aik099\SebastianBergmann\CodeCoverage\Filter');
 }
 else {
 	\class_alias('\SebastianBergmann\CodeCoverage\Filter', '\aik099\SebastianBergmann\CodeCoverage\Filter');
 }
 
-if ( \class_exists('PHPUnit\Runner\Version') ) {
+if (\class_exists('PHPUnit\Runner\Version')) {
 	$runner_version = Version::id();
 }
 else {
@@ -97,9 +97,9 @@  discard block
 block discarded – undo
 	 */
 	protected function verifyMockeryExpectations()
 	{
-		if ( \class_exists('Mockery') ) {
+		if (\class_exists('Mockery')) {
 			// Add Mockery expectations to assertion count.
-			if ( ($container = \Mockery::getContainer()) !== null ) {
+			if (($container = \Mockery::getContainer()) !== null) {
 				$this->addToAssertionCount($container->mockery_getExpectationCount());
 			}
 
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
 }
 
 
-if ( version_compare($runner_version, '6.0.0', '<') ) {
+if (version_compare($runner_version, '6.0.0', '<')) {
 	require_once __DIR__ . '/AbstractPHPUnitCompatibilityTestCase5.php';
 }
 else {

Please login to merge, or discard this patch.

src/PHPUnitCompat/AbstractPHPUnitCompatibilityTestSuite5.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@  discard block
 block discarded – undo
 
 use PHPUnit\Framework\TestSuite;
 
-if ( version_compare($runner_version, '5.0.0', '<') ) {
+if (version_compare($runner_version, '5.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 4
 	 */
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
 
 	}
 }
-elseif ( version_compare($runner_version, '6.0.0', '<') ) {
+elseif (version_compare($runner_version, '6.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 5
 	 */

Please login to merge, or discard this patch.

src/PHPUnitCompat/AbstractPHPUnitCompatibilityTestCase7.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@  discard block
 block discarded – undo
 
 use PHPUnit\Framework\TestCase;
 
-if ( version_compare($runner_version, '7.0.0', '<') ) {
+if (version_compare($runner_version, '7.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 6
 	 */
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
 
 	}
 }
-elseif ( version_compare($runner_version, '8.0.0', '<') ) {
+elseif (version_compare($runner_version, '8.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 7
 	 */

Please login to merge, or discard this patch.

src/PHPUnitCompat/AbstractPHPUnitCompatibilityTestSuite7.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -14,7 +14,7 @@  discard block
 block discarded – undo
 use PHPUnit\Framework\TestResult;
 use PHPUnit\Framework\TestSuite;
 
-if ( version_compare($runner_version, '7.0.0', '<') ) {
+if (version_compare($runner_version, '7.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 6
 	 */
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
 
 	}
 }
-elseif ( version_compare($runner_version, '8.0.0', '<') ) {
+elseif (version_compare($runner_version, '8.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 7
 	 */

Please login to merge, or discard this patch.

		@@ -13,63 +13,63 @@ discard block
		block discarded – undo
13	13
14	14	use PHPUnit\Runner\Version;
15	15
16		-if ( \class_exists('\PHPUnit_Framework_IncompleteTestError') ) {
	16	+if (\class_exists('\PHPUnit_Framework_IncompleteTestError')) {
17	17	\class_alias('\PHPUnit_Framework_IncompleteTestError', '\ConsoleHelpers\PHPUnitCompat\Framework\IncompleteTestError');
18	18	}
19	19	else {
20	20	\class_alias('\PHPUnit\Framework\IncompleteTestError', '\ConsoleHelpers\PHPUnitCompat\Framework\IncompleteTestError');
21	21	}
22	22
23		-if ( class_exists('\PHPUnit_Framework_SkippedTestError') ) {
	23	+if (class_exists('\PHPUnit_Framework_SkippedTestError')) {
24	24	\class_alias('\PHPUnit_Framework_SkippedTestError', '\ConsoleHelpers\PHPUnitCompat\Framework\SkippedTestError');
25	25	}
26	26	else {
27	27	\class_alias('\PHPUnit\Framework\SkippedTestError', '\ConsoleHelpers\PHPUnitCompat\Framework\SkippedTestError');
28	28	}
29	29
30		-if ( class_exists('\PHPUnit_Framework_TestSuite_DataProvider') ) {
	30	+if (class_exists('\PHPUnit_Framework_TestSuite_DataProvider')) {
31	31	\class_alias('\PHPUnit_Framework_TestSuite_DataProvider', '\ConsoleHelpers\PHPUnitCompat\Framework\DataProviderTestSuite');
32	32	}
33	33	else {
34	34	\class_alias('\PHPUnit\Framework\DataProviderTestSuite', '\ConsoleHelpers\PHPUnitCompat\Framework\DataProviderTestSuite');
35	35	}
36	36
37		-if ( class_exists('\PHPUnit_Framework_TestResult') ) {
	37	+if (class_exists('\PHPUnit_Framework_TestResult')) {
38	38	\class_alias('\PHPUnit_Framework_TestResult', '\ConsoleHelpers\PHPUnitCompat\Framework\TestResult');
39	39	}
40	40	else {
41	41	\class_alias('\PHPUnit\Framework\TestResult', '\ConsoleHelpers\PHPUnitCompat\Framework\TestResult');
42	42	}
43	43
44		-if ( class_exists('\PHPUnit_Framework_Test') ) {
	44	+if (class_exists('\PHPUnit_Framework_Test')) {
45	45	\class_alias('\PHPUnit_Framework_Test', '\ConsoleHelpers\PHPUnitCompat\Framework\Test');
46	46	}
47	47	else {
48	48	\class_alias('\PHPUnit\Framework\Test', '\ConsoleHelpers\PHPUnitCompat\Framework\Test');
49	49	}
50	50
51		-if ( class_exists('\PHP_CodeCoverage') ) {
	51	+if (class_exists('\PHP_CodeCoverage')) {
52	52	\class_alias('\PHP_CodeCoverage', '\aik099\SebastianBergmann\CodeCoverage\CodeCoverage');
53	53	}
54	54	else {
55	55	\class_alias('\SebastianBergmann\CodeCoverage\CodeCoverage', '\aik099\SebastianBergmann\CodeCoverage\CodeCoverage');
56	56	}
57	57
58		-if ( \interface_exists('\PHP_CodeCoverage_Driver') ) {
	58	+if (\interface_exists('\PHP_CodeCoverage_Driver')) {
59	59	\class_alias('\PHP_CodeCoverage_Driver', '\aik099\SebastianBergmann\CodeCoverage\Driver\Driver');
60	60	}
61	61	else {
62	62	\class_alias('\SebastianBergmann\CodeCoverage\Driver\Driver', '\aik099\SebastianBergmann\CodeCoverage\Driver\Driver');
63	63	}
64	64
65		-if ( class_exists('\PHP_CodeCoverage_Filter') ) {
	65	+if (class_exists('\PHP_CodeCoverage_Filter')) {
66	66	\class_alias('\PHP_CodeCoverage_Filter', '\aik099\SebastianBergmann\CodeCoverage\Filter');
67	67	}
68	68	else {
69	69	\class_alias('\SebastianBergmann\CodeCoverage\Filter', '\aik099\SebastianBergmann\CodeCoverage\Filter');
70	70	}
71	71
72		-if ( \class_exists('PHPUnit\Runner\Version') ) {
	72	+if (\class_exists('PHPUnit\Runner\Version')) {
73	73	$runner_version = Version::id();
74	74	}
75	75	else {
		@@ -97,9 +97,9 @@ discard block
		block discarded – undo
97	97	*/
98	98	protected function verifyMockeryExpectations()
99	99	{
100		- if ( \class_exists('Mockery') ) {
	100	+ if (\class_exists('Mockery')) {
101	101	// Add Mockery expectations to assertion count.
102		- if ( ($container = \Mockery::getContainer()) !== null ) {
	102	+ if (($container = \Mockery::getContainer()) !== null) {
103	103	$this->addToAssertionCount($container->mockery_getExpectationCount());
104	104	}
105	105
		@@ -111,7 +111,7 @@ discard block
		block discarded – undo
111	111	}
112	112
113	113
114		-if ( version_compare($runner_version, '6.0.0', '<') ) {
	114	+if (version_compare($runner_version, '6.0.0', '<')) {
115	115	require_once __DIR__ . '/AbstractPHPUnitCompatibilityTestCase5.php';
116	116	}
117	117	else {

		@@ -14,7 +14,7 @@ discard block
		block discarded – undo
14	14	use PHPUnit\Framework\TestResult;
15	15	use PHPUnit\Runner\Version;
16	16
17		-if ( \class_exists('PHPUnit\Runner\Version') ) {
	17	+if (\class_exists('PHPUnit\Runner\Version')) {
18	18	$runner_version = Version::id();
19	19	}
20	20	else {
		@@ -49,7 +49,7 @@ discard block
		block discarded – undo
49	49	}
50	50
51	51
52		-if ( version_compare($runner_version, '6.0.0', '<') ) {
	52	+if (version_compare($runner_version, '6.0.0', '<')) {
53	53	require_once __DIR__ . '/AbstractPHPUnitCompatibilityTestSuite5.php';
54	54	}
55	55	else {

		@@ -13,7 +13,7 @@ discard block
		block discarded – undo
13	13
14	14	use PHPUnit\Framework\TestCase;
15	15
16		-if ( version_compare($runner_version, '5.0.0', '<') ) {
	16	+if (version_compare($runner_version, '5.0.0', '<')) {
17	17	/**
18	18	* Implementation for PHPUnit 4
19	19	*/
		@@ -34,7 +34,7 @@ discard block
		block discarded – undo
34	34
35	35	}
36	36	}
37		-elseif ( version_compare($runner_version, '6.0.0', '<') ) {
	37	+elseif (version_compare($runner_version, '6.0.0', '<')) {
38	38	/**
39	39	* Implementation for PHPUnit 5
40	40	*/

		@@ -13,7 +13,7 @@ discard block
		block discarded – undo
13	13
14	14	use PHPUnit\Framework\TestSuite;
15	15
16		-if ( version_compare($runner_version, '5.0.0', '<') ) {
	16	+if (version_compare($runner_version, '5.0.0', '<')) {
17	17	/**
18	18	* Implementation for PHPUnit 4
19	19	*/
		@@ -40,7 +40,7 @@ discard block
		block discarded – undo
40	40
41	41	}
42	42	}
43		-elseif ( version_compare($runner_version, '6.0.0', '<') ) {
	43	+elseif (version_compare($runner_version, '6.0.0', '<')) {
44	44	/**
45	45	* Implementation for PHPUnit 5
46	46	*/

console-helpers / phpunit-compat

Pull Request — master (#1)

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch