Inspection of "Improve coverage" - console-helpers/phpunit-compat - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#2)

by Alexander

created 2024-02-20 10:36 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -14,7 +14,7 @@  discard block
 block discarded – undo
 use PHPUnit\Framework\TestResult;
 use PHPUnit\Framework\TestSuite;
 
-if ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '7.0.0', '<') ) {
+if (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '7.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 6
 	 */
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
 
 	}
 }
-elseif ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '8.0.0', '<') ) {
+elseif (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '8.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 7
 	 */

Please login to merge, or discard this patch.

src/PHPUnitCompat/AbstractTestCase.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@  discard block
 block discarded – undo
 
 use PHPUnit\Runner\Version;
 
-if ( \class_exists('\PHPUnit_Framework_IncompleteTestError') ) {
+if (\class_exists('\PHPUnit_Framework_IncompleteTestError')) {
 	\class_alias(
 		'\PHPUnit_Framework_IncompleteTestError',
 		'\ConsoleHelpers\PHPUnitCompat\Framework\IncompleteTestError'
@@ -26,14 +26,14 @@  discard block
 block discarded – undo
 	);
 }
 
-if ( class_exists('\PHPUnit_Framework_SkippedTestError') ) {
+if (class_exists('\PHPUnit_Framework_SkippedTestError')) {
 	\class_alias('\PHPUnit_Framework_SkippedTestError', '\ConsoleHelpers\PHPUnitCompat\Framework\SkippedTestError');
 }
 else {
 	\class_alias('\PHPUnit\Framework\SkippedTestError', '\ConsoleHelpers\PHPUnitCompat\Framework\SkippedTestError');
 }
 
-if ( class_exists('\PHPUnit_Framework_TestSuite_DataProvider') ) {
+if (class_exists('\PHPUnit_Framework_TestSuite_DataProvider')) {
 	\class_alias(
 		'\PHPUnit_Framework_TestSuite_DataProvider',
 		'\ConsoleHelpers\PHPUnitCompat\Framework\DataProviderTestSuite'
@@ -46,21 +46,21 @@  discard block
 block discarded – undo
 	);
 }
 
-if ( class_exists('\PHPUnit_Framework_TestResult') ) {
+if (class_exists('\PHPUnit_Framework_TestResult')) {
 	\class_alias('\PHPUnit_Framework_TestResult', '\ConsoleHelpers\PHPUnitCompat\Framework\TestResult');
 }
 else {
 	\class_alias('\PHPUnit\Framework\TestResult', '\ConsoleHelpers\PHPUnitCompat\Framework\TestResult');
 }
 
-if ( class_exists('\PHPUnit_Framework_Test') ) {
+if (class_exists('\PHPUnit_Framework_Test')) {
 	\class_alias('\PHPUnit_Framework_Test', '\ConsoleHelpers\PHPUnitCompat\Framework\Test');
 }
 else {
 	\class_alias('\PHPUnit\Framework\Test', '\ConsoleHelpers\PHPUnitCompat\Framework\Test');
 }
 
-if ( class_exists('\PHP_CodeCoverage') ) {
+if (class_exists('\PHP_CodeCoverage')) {
 	\class_alias('\PHP_CodeCoverage', '\aik099\SebastianBergmann\CodeCoverage\CodeCoverage');
 }
 else {
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
 	);
 }
 
-if ( \interface_exists('\PHP_CodeCoverage_Driver') ) {
+if (\interface_exists('\PHP_CodeCoverage_Driver')) {
 	\class_alias('\PHP_CodeCoverage_Driver', '\aik099\SebastianBergmann\CodeCoverage\Driver\Driver');
 }
 else {
@@ -80,15 +80,15 @@  discard block
 block discarded – undo
 	);
 }
 
-if ( class_exists('\PHP_CodeCoverage_Filter') ) {
+if (class_exists('\PHP_CodeCoverage_Filter')) {
 	\class_alias('\PHP_CodeCoverage_Filter', '\aik099\SebastianBergmann\CodeCoverage\Filter');
 }
 else {
 	\class_alias('\SebastianBergmann\CodeCoverage\Filter', '\aik099\SebastianBergmann\CodeCoverage\Filter');
 }
 
-if ( !\defined('PHPUNIT_COMPAT_RUNNER_VERSION') ) {
-	if ( \class_exists('PHPUnit\Runner\Version') ) {
+if (!\defined('PHPUNIT_COMPAT_RUNNER_VERSION')) {
+	if (\class_exists('PHPUnit\Runner\Version')) {
 		\define('PHPUNIT_COMPAT_RUNNER_VERSION', Version::id());
 	}
 	else {
@@ -119,14 +119,14 @@  discard block
 block discarded – undo
 	 */
 	protected function verifyMockeryExpectations()
 	{
-		if ( !\class_exists('Mockery') ) {
+		if (!\class_exists('Mockery')) {
 			return;
 		}
 
 		// Add Mockery expectations to assertion count.
 		$container = \Mockery::getContainer();
 
-		if ( $container !== null ) {
+		if ($container !== null) {
 			$this->addToAssertionCount($container->mockery_getExpectationCount());
 		}
 
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
 
 }
 
-if ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '6.0.0', '<') ) {
+if (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '6.0.0', '<')) {
 	require_once __DIR__ . '/AbstractTestCase5.php';
 }
 else {

Please login to merge, or discard this patch.

src/PHPUnitCompat/AbstractTestSuite.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -14,8 +14,8 @@  discard block
 block discarded – undo
 use PHPUnit\Framework\TestResult;
 use PHPUnit\Runner\Version;
 
-if ( !\defined('PHPUNIT_COMPAT_RUNNER_VERSION') ) {
-	if ( \class_exists('PHPUnit\Runner\Version') ) {
+if (!\defined('PHPUNIT_COMPAT_RUNNER_VERSION')) {
+	if (\class_exists('PHPUnit\Runner\Version')) {
 		\define('PHPUNIT_COMPAT_RUNNER_VERSION', Version::id());
 	}
 	else {
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
 }
 
 
-if ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '6.0.0', '<') ) {
+if (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '6.0.0', '<')) {
 	require_once __DIR__ . '/AbstractTestSuite5.php';
 }
 else {

Please login to merge, or discard this patch.

src/PHPUnitCompat/AbstractTestSuite5.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@  discard block
 block discarded – undo
 
 use PHPUnit\Framework\TestSuite;
 
-if ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '5.0.0', '<') ) {
+if (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '5.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 4
 	 */
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
 
 	}
 }
-elseif ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '6.0.0', '<') ) {
+elseif (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '6.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 5
 	 */

Please login to merge, or discard this patch.

src/PHPUnitCompat/AbstractTestCase7.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@  discard block
 block discarded – undo
 
 use PHPUnit\Framework\TestCase;
 
-if ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '7.0.0', '<') ) { // @codeCoverageIgnore
+if (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '7.0.0', '<')) { // @codeCoverageIgnore
 	/**
 	 * Implementation for PHPUnit 6
 	 */
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
 
 	}
 }
-elseif ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '8.0.0', '<') ) {
+elseif (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '8.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 7
 	 */

Please login to merge, or discard this patch.

src/PHPUnitCompat/AbstractTestCase5.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -13,7 +13,7 @@  discard block
 block discarded – undo
 
 use PHPUnit\Framework\TestCase;
 
-if ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '5.0.0', '<') ) { // @codeCoverageIgnore
+if (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '5.0.0', '<')) { // @codeCoverageIgnore
 	/**
 	 * Implementation for PHPUnit 4
 	 */
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
 
 	}
 }
-elseif ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '6.0.0', '<') ) {
+elseif (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '6.0.0', '<')) {
 	/**
 	 * Implementation for PHPUnit 5
 	 */

Please login to merge, or discard this patch.

		@@ -13,7 +13,7 @@ discard block
		block discarded – undo
13	13
14	14	use PHPUnit\Runner\Version;
15	15
16		-if ( \class_exists('\PHPUnit_Framework_IncompleteTestError') ) {
	16	+if (\class_exists('\PHPUnit_Framework_IncompleteTestError')) {
17	17	\class_alias(
18	18	'\PHPUnit_Framework_IncompleteTestError',
19	19	'\ConsoleHelpers\PHPUnitCompat\Framework\IncompleteTestError'
		@@ -26,14 +26,14 @@ discard block
		block discarded – undo
26	26	);
27	27	}
28	28
29		-if ( class_exists('\PHPUnit_Framework_SkippedTestError') ) {
	29	+if (class_exists('\PHPUnit_Framework_SkippedTestError')) {
30	30	\class_alias('\PHPUnit_Framework_SkippedTestError', '\ConsoleHelpers\PHPUnitCompat\Framework\SkippedTestError');
31	31	}
32	32	else {
33	33	\class_alias('\PHPUnit\Framework\SkippedTestError', '\ConsoleHelpers\PHPUnitCompat\Framework\SkippedTestError');
34	34	}
35	35
36		-if ( class_exists('\PHPUnit_Framework_TestSuite_DataProvider') ) {
	36	+if (class_exists('\PHPUnit_Framework_TestSuite_DataProvider')) {
37	37	\class_alias(
38	38	'\PHPUnit_Framework_TestSuite_DataProvider',
39	39	'\ConsoleHelpers\PHPUnitCompat\Framework\DataProviderTestSuite'
		@@ -46,21 +46,21 @@ discard block
		block discarded – undo
46	46	);
47	47	}
48	48
49		-if ( class_exists('\PHPUnit_Framework_TestResult') ) {
	49	+if (class_exists('\PHPUnit_Framework_TestResult')) {
50	50	\class_alias('\PHPUnit_Framework_TestResult', '\ConsoleHelpers\PHPUnitCompat\Framework\TestResult');
51	51	}
52	52	else {
53	53	\class_alias('\PHPUnit\Framework\TestResult', '\ConsoleHelpers\PHPUnitCompat\Framework\TestResult');
54	54	}
55	55
56		-if ( class_exists('\PHPUnit_Framework_Test') ) {
	56	+if (class_exists('\PHPUnit_Framework_Test')) {
57	57	\class_alias('\PHPUnit_Framework_Test', '\ConsoleHelpers\PHPUnitCompat\Framework\Test');
58	58	}
59	59	else {
60	60	\class_alias('\PHPUnit\Framework\Test', '\ConsoleHelpers\PHPUnitCompat\Framework\Test');
61	61	}
62	62
63		-if ( class_exists('\PHP_CodeCoverage') ) {
	63	+if (class_exists('\PHP_CodeCoverage')) {
64	64	\class_alias('\PHP_CodeCoverage', '\aik099\SebastianBergmann\CodeCoverage\CodeCoverage');
65	65	}
66	66	else {
		@@ -70,7 +70,7 @@ discard block
		block discarded – undo
70	70	);
71	71	}
72	72
73		-if ( \interface_exists('\PHP_CodeCoverage_Driver') ) {
	73	+if (\interface_exists('\PHP_CodeCoverage_Driver')) {
74	74	\class_alias('\PHP_CodeCoverage_Driver', '\aik099\SebastianBergmann\CodeCoverage\Driver\Driver');
75	75	}
76	76	else {
		@@ -80,15 +80,15 @@ discard block
		block discarded – undo
80	80	);
81	81	}
82	82
83		-if ( class_exists('\PHP_CodeCoverage_Filter') ) {
	83	+if (class_exists('\PHP_CodeCoverage_Filter')) {
84	84	\class_alias('\PHP_CodeCoverage_Filter', '\aik099\SebastianBergmann\CodeCoverage\Filter');
85	85	}
86	86	else {
87	87	\class_alias('\SebastianBergmann\CodeCoverage\Filter', '\aik099\SebastianBergmann\CodeCoverage\Filter');
88	88	}
89	89
90		-if ( !\defined('PHPUNIT_COMPAT_RUNNER_VERSION') ) {
91		- if ( \class_exists('PHPUnit\Runner\Version') ) {
	90	+if (!\defined('PHPUNIT_COMPAT_RUNNER_VERSION')) {
	91	+ if (\class_exists('PHPUnit\Runner\Version')) {
92	92	\define('PHPUNIT_COMPAT_RUNNER_VERSION', Version::id());
93	93	}
94	94	else {
		@@ -119,14 +119,14 @@ discard block
		block discarded – undo
119	119	*/
120	120	protected function verifyMockeryExpectations()
121	121	{
122		- if ( !\class_exists('Mockery') ) {
	122	+ if (!\class_exists('Mockery')) {
123	123	return;
124	124	}
125	125
126	126	// Add Mockery expectations to assertion count.
127	127	$container = \Mockery::getContainer();
128	128
129		- if ( $container !== null ) {
	129	+ if ($container !== null) {
130	130	$this->addToAssertionCount($container->mockery_getExpectationCount());
131	131	}
132	132
		@@ -136,7 +136,7 @@ discard block
		block discarded – undo
136	136
137	137	}
138	138
139		-if ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '6.0.0', '<') ) {
	139	+if (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '6.0.0', '<')) {
140	140	require_once __DIR__ . '/AbstractTestCase5.php';
141	141	}
142	142	else {

		@@ -14,7 +14,7 @@ discard block
		block discarded – undo
14	14	use PHPUnit\Framework\TestResult;
15	15	use PHPUnit\Framework\TestSuite;
16	16
17		-if ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '7.0.0', '<') ) {
	17	+if (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '7.0.0', '<')) {
18	18	/**
19	19	* Implementation for PHPUnit 6
20	20	*/
		@@ -41,7 +41,7 @@ discard block
		block discarded – undo
41	41
42	42	}
43	43	}
44		-elseif ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '8.0.0', '<') ) {
	44	+elseif (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '8.0.0', '<')) {
45	45	/**
46	46	* Implementation for PHPUnit 7
47	47	*/

		@@ -14,8 +14,8 @@ discard block
		block discarded – undo
14	14	use PHPUnit\Framework\TestResult;
15	15	use PHPUnit\Runner\Version;
16	16
17		-if ( !\defined('PHPUNIT_COMPAT_RUNNER_VERSION') ) {
18		- if ( \class_exists('PHPUnit\Runner\Version') ) {
	17	+if (!\defined('PHPUNIT_COMPAT_RUNNER_VERSION')) {
	18	+ if (\class_exists('PHPUnit\Runner\Version')) {
19	19	\define('PHPUNIT_COMPAT_RUNNER_VERSION', Version::id());
20	20	}
21	21	else {
		@@ -51,7 +51,7 @@ discard block
		block discarded – undo
51	51	}
52	52
53	53
54		-if ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '6.0.0', '<') ) {
	54	+if (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '6.0.0', '<')) {
55	55	require_once __DIR__ . '/AbstractTestSuite5.php';
56	56	}
57	57	else {

		@@ -13,7 +13,7 @@ discard block
		block discarded – undo
13	13
14	14	use PHPUnit\Framework\TestCase;
15	15
16		-if ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '7.0.0', '<') ) { // @codeCoverageIgnore
	16	+if (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '7.0.0', '<')) { // @codeCoverageIgnore
17	17	/**
18	18	* Implementation for PHPUnit 6
19	19	*/
		@@ -34,7 +34,7 @@ discard block
		block discarded – undo
34	34
35	35	}
36	36	}
37		-elseif ( version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '8.0.0', '<') ) {
	37	+elseif (version_compare(\PHPUNIT_COMPAT_RUNNER_VERSION, '8.0.0', '<')) {
38	38	/**
39	39	* Implementation for PHPUnit 7
40	40	*/

console-helpers / phpunit-compat

Pull Request — master (#2)

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch