console-helpers / jira-cli

src/JiraCLI/Container.php

<?php
/**
 * This file is part of the Jira-CLI library.
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 *
 * @copyright Alexander Obuhovich <aik.bold@gmail.com>
 * @link      https://github.com/console-helpers/jira-cli
 */

namespace ConsoleHelpers\JiraCLI;


use chobie\Jira\Api\Authentication\Basic;
use ConsoleHelpers\ConsoleKit\Config\ConfigEditor;
use ConsoleHelpers\JiraCLI\Cache\CacheFactory;
use ConsoleHelpers\JiraCLI\Issue\BackportableIssueCloner;
use ConsoleHelpers\JiraCLI\Issue\ChangeLogIssueCloner;

class Container extends \ConsoleHelpers\ConsoleKit\Container
{

	/**
	 * {@inheritdoc}
	 */
	public function __construct(array $values = array())
	{
		parent::__construct($values);

		$this['app_name'] = 'Jira-CLI';
		$this['app_version'] = '@git-version@';

		$this['working_directory_sub_folder'] = '.jira-cli';

		$this['config_defaults'] = array(
			'jira.url' => '',
			'jira.username' => '',
			'jira.password' => '',
			'cache.provider' => '',
		);

		$this['cache'] = function ($c) {
			/** @var ConfigEditor $config_editor */
			$config_editor = $c['config_editor'];
			$cache_provider = $config_editor->get('cache.provider');

			$cache_factory = new CacheFactory('jira_url:' . $config_editor->get('jira.url'));

Are you sure $config_editor->get('jira.url') of type array|mixed|null can be used in concatenation?

			return $cache_factory->create('chain', array('array', $cache_provider));
		};

		$this['jira_api'] = function ($c) {
			/** @var ConfigEditor $config_editor */
			$config_editor = $c['config_editor'];

			$authentication = new Basic(
				$config_editor->get('jira.username'),

It seems like $config_editor->get('jira.username') can also be of type array and array; however, parameter $user_id of chobie\Jira\Api\Authentication\Basic::__construct() does only seem to accept string, maybe add an additional type check?

				$config_editor->get('jira.password')

It seems like $config_editor->get('jira.password') can also be of type array and array; however, parameter $password of chobie\Jira\Api\Authentication\Basic::__construct() does only seem to accept string, maybe add an additional type check?

			);

			$api = new JiraApi($config_editor->get('jira.url'), $authentication);

It seems like $config_editor->get('jira.url') can also be of type array and array; however, parameter $endpoint of ConsoleHelpers\JiraCLI\JiraApi::__construct() does only seem to accept string, maybe add an additional type check?

			$api->setCache($c['cache']);

			return $api;
		};

		$this['backportable_issue_cloner'] = function ($c) {
			return new BackportableIssueCloner($c['jira_api']);
		};

		$this['changelog_issue_cloner'] = function ($c) {
			return new ChangeLogIssueCloner($c['jira_api']);
		};
	}

}