ConsoleHelpers\CodeInsight\BackwardsCompatibility\BreakFilter

Complexity

Total Complexity

16

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	removeMatching()	0	11	3
C	isMatching()	0	31	13

<?php
/**
 * This file is part of the Code-Insight library.
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 *
 * @copyright Alexander Obuhovich <aik.bold@gmail.com>
 * @link      https://github.com/console-helpers/code-insight
 */

namespace ConsoleHelpers\CodeInsight\BackwardsCompatibility;


class BreakFilter
{

	/**
	 * Removes ignored BC breaks.
	 *
	 * @param array $bc_breaks BC breaks.
	 * @param array $rules     Rules.
	 *
	 * @return array
	 */
	public function removeMatching(array $bc_breaks, array $rules)
	{
		$ret = array();

		foreach ( $bc_breaks as $break_data ) {
			if ( !$this->isMatching($break_data, $rules) ) {
				$ret[] = $break_data;
			}
		}

		return $ret;
	}

	/**
	 * Determines if BC break is ignored.
	 *
	 * @param array $break_data Break data.
	 * @param array $rules      Rules.
	 *
	 * @return boolean
	 */
	protected function isMatching(array $break_data, array $rules)
	{
		if ( !$rules ) {

The expression $rules of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

			return false;
		}

		foreach ( $rules as $rule_data ) {
			if ( isset($rule_data['type']) && $rule_data['type'] !== $break_data['type'] ) {
				continue;
			}

			if ( isset($rule_data['element']) && $rule_data['element'] !== $break_data['element'] ) {
				continue;
			}

			if ( isset($rule_data['old']) ) {
				if ( !isset($break_data['old']) || $rule_data['old'] !== $break_data['old'] ) {
					continue;
				}
			}

			if ( isset($rule_data['new']) ) {
				if ( !isset($break_data['new']) || $rule_data['new'] !== $break_data['new'] ) {
					continue;
				}
			}

			return true;
		}

		return false;
	}

}