PublishAssetCommand::publish() - Code Metrics - consigliere/components - Measure and Improve Code Quality continuously with Scrutinizer

PublishAssetCommand::publish() A
last analyzed 2017-05-12 08:13 UTC

↳ Parent: PublishAssetCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	10

Duplication

Lines	15
Ratio	100 %

Importance

Changes

Metric	Value
dl	15
loc	15
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	10
nc	2
nop	1

<?php

namespace Consigliere\Components\Commands;

use Illuminate\Console\Command as ComponentCommand;
use Consigliere\Components\Component;
use Consigliere\Components\Publishing\AssetPublisher;
use Symfony\Component\Console\Input\InputArgument;

class PublishAssetCommand extends ComponentCommand

{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'component:publish-asset';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Publish a component\'s assets to the application';

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function fire()
    {
        if ($name = $this->argument('component')) {
            return $this->publish($name);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }

        $this->publishAll();
    }

    /**
     * Publish assets from all components.
     */
    public function publishAll()
    {
        foreach ($this->laravel['components']->enabled() as $component) {
            $this->publish($component);
        }
    }

    /**
     * Publish assets from the specified component.
     *
     * @param string $name
     */
    public function publish($name)
    {
        if ($name instanceof Component) {
            $component = $name;
        } else {
            $component = $this->laravel['components']->findOrFail($name);
        }

        with(new AssetPublisher($component))
            ->setRepository($this->laravel['components'])
            ->setConsole($this)
            ->publish();

        $this->line("<info>Published</info>: {$component->getStudlyName()}");
    }

    /**
     * Get the console command arguments.
     *
     * @return array
     */
    protected function getArguments()
    {
        return [
            ['component', InputArgument::OPTIONAL, 'The name of component will be used.'],
        ];
    }
}


1		<?php
2
3		namespace Consigliere\Components\Commands;
4
5		use Illuminate\Console\Command as ComponentCommand;
6		use Consigliere\Components\Component;
7		use Consigliere\Components\Publishing\AssetPublisher;
8		use Symfony\Component\Console\Input\InputArgument;
9
10	View Code Duplication	class PublishAssetCommand extends ComponentCommand
		0 ignored issues – show Duplication introduced 2017-01-18 11:24 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		/**
13		* The console command name.
14		*
15		* @var string
16		*/
17		protected $name = 'component:publish-asset';
18
19		/**
20		* The console command description.
21		*
22		* @var string
23		*/
24		protected $description = 'Publish a component\'s assets to the application';
25
26		/**
27		* Execute the console command.
28		*
29		* @return mixed
30		*/
31		public function fire()
32		{
33		if ($name = $this->argument('component')) {
34		return $this->publish($name);
		0 ignored issues – show Bug introduced 2017-01-18 11:24 UTC by Report Bug Copy Issue Report It seems like `$name` defined by `$this->argument('component')` on line `33` can also be of type `array`; however, `Consigliere\Components\C...AssetCommand::publish()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
35		}
36
37		$this->publishAll();
38		}
39
40		/**
41		* Publish assets from all components.
42		*/
43		public function publishAll()
44		{
45		foreach ($this->laravel['components']->enabled() as $component) {
46		$this->publish($component);
47		}
48		}
49
50		/**
51		* Publish assets from the specified component.
52		*
53		* @param string $name
54		*/
55		public function publish($name)
56		{
57		if ($name instanceof Component) {
58		$component = $name;
59		} else {
60		$component = $this->laravel['components']->findOrFail($name);
61		}
62
63		with(new AssetPublisher($component))
64		->setRepository($this->laravel['components'])
65		->setConsole($this)
66		->publish();
67
68		$this->line("<info>Published</info>: {$component->getStudlyName()}");
69		}
70
71		/**
72		* Get the console command arguments.
73		*
74		* @return array
75		*/
76		protected function getArguments()
77		{
78		return [
79		['component', InputArgument::OPTIONAL, 'The name of component will be used.'],
80		];
81		}
82		}
83

consigliere / components

PublishAssetCommand::publish() A last analyzed 2017-05-12 08:13 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PublishAssetCommand::publish() A
last analyzed 2017-05-12 08:13 UTC