MakeCommand::getOptions() - Code Metrics - consigliere/components - Measure and Improve Code Quality continuously with Scrutinizer

MakeCommand::getOptions() A
last analyzed 2017-05-12 08:13 UTC

↳ Parent: MakeCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	0

<?php

namespace Consigliere\Components\Commands;

use Illuminate\Console\Command as ComponentCommand;
use Consigliere\Components\Generators\ComponentGenerator;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputOption;

class MakeCommand extends ComponentCommand
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'component:make';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Generate new component.';

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function fire()
    {
        $names = $this->argument('name');

        foreach ($names as $name) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            with(new ComponentGenerator($name))
                ->setFilesystem($this->laravel['files'])
                ->setComponent($this->laravel['components'])
                ->setConfig($this->laravel['config'])
                ->setConsole($this)
                ->setForce($this->option('force'))
                ->setPlain($this->option('plain'))
                ->generate();
        }
    }

    /**
     * Get the console command arguments.
     *
     * @return array
     */
    protected function getArguments()
    {
        return [
            ['name', InputArgument::IS_ARRAY, 'The names of components will be created.'],
        ];
    }

    protected function getOptions()
    {
        return [
            ['plain', 'p', InputOption::VALUE_NONE, 'Generate a plain component (without some resources).'],
            ['force', null, InputOption::VALUE_NONE, 'Force the operation to run when component already exist.'],
        ];
    }
}


1			<?php
2
3			namespace Consigliere\Components\Commands;
4
5			use Illuminate\Console\Command as ComponentCommand;
6			use Consigliere\Components\Generators\ComponentGenerator;
7			use Symfony\Component\Console\Input\InputArgument;
8			use Symfony\Component\Console\Input\InputOption;
9
10			class MakeCommand extends ComponentCommand
11			{
12			/**
13			* The console command name.
14			*
15			* @var string
16			*/
17			protected $name = 'component:make';
18
19			/**
20			* The console command description.
21			*
22			* @var string
23			*/
24			protected $description = 'Generate new component.';
25
26			/**
27			* Execute the console command.
28			*
29			* @return mixed
30			*/
31			public function fire()
32			{
33			$names = $this->argument('name');
34
35			foreach ($names as $name) {
			0 ignored issues – show Bug introduced 2017-01-18 11:24 UTC by Report Bug Copy Issue Report The expression `$names` of type `string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
36			with(new ComponentGenerator($name))
37			->setFilesystem($this->laravel['files'])
38			->setComponent($this->laravel['components'])
39			->setConfig($this->laravel['config'])
40			->setConsole($this)
41			->setForce($this->option('force'))
42			->setPlain($this->option('plain'))
43			->generate();
44			}
45			}
46
47			/**
48			* Get the console command arguments.
49			*
50			* @return array
51			*/
52			protected function getArguments()
53			{
54			return [
55			['name', InputArgument::IS_ARRAY, 'The names of components will be created.'],
56			];
57			}
58
59			protected function getOptions()
60			{
61			return [
62			['plain', 'p', InputOption::VALUE_NONE, 'Generate a plain component (without some resources).'],
63			['force', null, InputOption::VALUE_NONE, 'Force the operation to run when component already exist.'],
64			];
65			}
66			}
67

consigliere / components

MakeCommand::getOptions() A last analyzed 2017-05-12 08:13 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

MakeCommand::getOptions() A
last analyzed 2017-05-12 08:13 UTC