Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class Seeder |
||
9 | { |
||
10 | /** |
||
11 | * Pingpong Component instance. |
||
12 | * |
||
13 | * @var \Consigliere\Components\Component |
||
14 | */ |
||
15 | protected $component; |
||
16 | |||
17 | /** |
||
18 | * Laravel Application instance. |
||
19 | * |
||
20 | * @var \Illuminate\Foundation\Application. |
||
21 | */ |
||
22 | protected $laravel; |
||
23 | |||
24 | /** |
||
25 | * The database connection to be used |
||
26 | * |
||
27 | * @var string |
||
28 | */ |
||
29 | protected $database = ''; |
||
30 | |||
31 | /** |
||
32 | * Create new instance. |
||
33 | * |
||
34 | * @param \Consigliere\Components\Component $component |
||
35 | */ |
||
36 | public function __construct(Component $component) |
||
41 | |||
42 | /** |
||
43 | * Set the database connection to be used |
||
44 | * |
||
45 | * @param $database |
||
46 | * |
||
47 | * @return $this |
||
48 | */ |
||
49 | public function setDatabase($database) |
||
55 | |||
56 | /** |
||
57 | * @return Component |
||
58 | */ |
||
59 | public function getComponent() |
||
63 | |||
64 | /** |
||
65 | * Get seed path. |
||
66 | * |
||
67 | * @return string |
||
68 | */ |
||
69 | View Code Duplication | public function getPath() |
|
77 | |||
78 | /** |
||
79 | * Get seed files. |
||
80 | * |
||
81 | * @param boolean $reverse |
||
82 | * |
||
83 | * @return array |
||
84 | */ |
||
85 | View Code Duplication | public function getSeeds($reverse = false) |
|
112 | } |
||
113 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..