Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class Migrator |
||
9 | { |
||
10 | /** |
||
11 | * Pingpong Component instance. |
||
12 | * |
||
13 | * @var \Consigliere\Components\Component |
||
14 | */ |
||
15 | protected $component; |
||
16 | |||
17 | /** |
||
18 | * Laravel Application instance. |
||
19 | * |
||
20 | * @var \Illuminate\Foundation\Application. |
||
21 | */ |
||
22 | protected $laravel; |
||
23 | |||
24 | /** |
||
25 | * The database connection to be used |
||
26 | * |
||
27 | * @var string |
||
28 | */ |
||
29 | protected $database = ''; |
||
30 | |||
31 | /** |
||
32 | * Create new instance. |
||
33 | * |
||
34 | * @param \Consigliere\Components\Component $component |
||
35 | */ |
||
36 | public function __construct(Component $component) |
||
41 | |||
42 | /** |
||
43 | * Set the database connection to be used |
||
44 | * |
||
45 | * @param $database |
||
46 | * |
||
47 | * @return $this |
||
48 | */ |
||
49 | public function setDatabase($database) |
||
55 | |||
56 | /** |
||
57 | * @return Component |
||
58 | */ |
||
59 | public function getComponent() |
||
63 | |||
64 | /** |
||
65 | * Get migration path. |
||
66 | * |
||
67 | * @return string |
||
68 | */ |
||
69 | View Code Duplication | public function getPath() |
|
77 | |||
78 | /** |
||
79 | * Get migration files. |
||
80 | * |
||
81 | * @param boolean $reverse |
||
82 | * |
||
83 | * @return array |
||
84 | */ |
||
85 | View Code Duplication | public function getMigrations($reverse = false) |
|
112 | |||
113 | /** |
||
114 | * Rollback migration. |
||
115 | * |
||
116 | * @return array |
||
117 | */ |
||
118 | View Code Duplication | public function rollback() |
|
140 | |||
141 | /** |
||
142 | * Reset migration. |
||
143 | * |
||
144 | * @return array |
||
145 | */ |
||
146 | View Code Duplication | public function reset() |
|
168 | |||
169 | /** |
||
170 | * Run down schema from the given migration name. |
||
171 | * |
||
172 | * @param string $migration |
||
173 | */ |
||
174 | public function down($migration) |
||
178 | |||
179 | /** |
||
180 | * Run up schema from the given migration name. |
||
181 | * |
||
182 | * @param string $migration |
||
183 | */ |
||
184 | public function up($migration) |
||
188 | |||
189 | /** |
||
190 | * Resolve a migration instance from a file. |
||
191 | * |
||
192 | * @param string $file |
||
193 | * |
||
194 | * @return object |
||
195 | */ |
||
196 | public function resolve($file) |
||
204 | |||
205 | /** |
||
206 | * Require in all the migration files in a given path. |
||
207 | * |
||
208 | * @param array $files |
||
209 | */ |
||
210 | public function requireFiles(array $files) |
||
217 | |||
218 | /** |
||
219 | * Get table instance. |
||
220 | * |
||
221 | * @return string |
||
222 | */ |
||
223 | public function table() |
||
227 | |||
228 | /** |
||
229 | * Find migration data from database by given migration name. |
||
230 | * |
||
231 | * @param string $migration |
||
232 | * |
||
233 | * @return object |
||
234 | */ |
||
235 | public function find($migration) |
||
239 | |||
240 | /** |
||
241 | * Save new migration to database. |
||
242 | * |
||
243 | * @param string $migration |
||
244 | * |
||
245 | * @return mixed |
||
246 | */ |
||
247 | public function log($migration) |
||
254 | |||
255 | /** |
||
256 | * Get the next migration batch number. |
||
257 | * |
||
258 | * @return int |
||
259 | */ |
||
260 | public function getNextBatchNumber() |
||
264 | |||
265 | /** |
||
266 | * Get the last migration batch number. |
||
267 | * |
||
268 | * @param array $migrations |
||
269 | * |
||
270 | * @return int |
||
271 | */ |
||
272 | public function getLastBatchNumber($migrations) |
||
278 | |||
279 | /** |
||
280 | * Get the last migration batch. |
||
281 | * |
||
282 | * @param array $migrations |
||
283 | * |
||
284 | * @return Collection |
||
285 | */ |
||
286 | public function getLast($migrations) |
||
298 | |||
299 | /** |
||
300 | * Get the ran migrations. |
||
301 | * |
||
302 | * @return Collection |
||
303 | */ |
||
304 | public function getRan() |
||
308 | } |
||
309 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..