ConferenceTools\Tickets\Domain\ValueObject\TicketType

Complexity

Total Complexity

5

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Test Coverage

Coverage

71.43%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getDisplayName()	0	3	1
A	getIdentifier()	0	3	1
A	getPrice()	0	3	1
A	getDescription()	0	3	1

<?php

namespace ConferenceTools\Tickets\Domain\ValueObject;

use Doctrine\ORM\Mapping as ORM;
use JMS\Serializer\Annotation as Jms;

/**
 * Class TicketType
 * @package ConferenceTools\Tickets\Domain\ValueObject
 * @ORM\Embeddable
 */
final class TicketType
{
    /**
     * @var string
     * @Jms\Type("string")
     * @ORM\Column(type="string")
     */
    private $identifier;

    /**
     * @var Money
     * @ORM\Embedded(class="ConferenceTools\Tickets\Domain\ValueObject\Price")
     * @Jms\Type("ConferenceTools\Tickets\Domain\ValueObject\Price")
     */
    private $price;

    /**
     * @var string
     * @Jms\Type("string")
     * @ORM\Column(type="string")
     */
    private $displayName;

    /**
     * @var string
     * @Jms\Type("string")
     * @ORM\Column(type="string")
     */
    private $description;

    public function __construct(string $identifier, Price $price, string $displayName, string $description = '')
    {
        $this->identifier = $identifier;
        $this->price = $price;

It seems like $price of type ConferenceTools\Tickets\Domain\ValueObject\Price is incompatible with the declared type ConferenceTools\Tickets\Domain\ValueObject\Money of property $price.

        $this->displayName = $displayName;
        $this->description = $description;
    }

    public function getIdentifier(): string
    {
        return $this->identifier;
    }

    public function getPrice(): Price
    {
        return $this->price;

The expression return $this->price returns the type ConferenceTools\Tickets\Domain\ValueObject\Money which is incompatible with the type-hinted return ConferenceTools\Tickets\Domain\ValueObject\Price.

    }

    public function getDisplayName(): string
    {
        return $this->displayName;
    }

    public function getDescription(): string
    {
        return $this->description;
    }
}