ConferenceTools\Tickets\Domain\Service\TicketAvailability\TicketAvailability

Complexity

Total Complexity

8

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	fetchAllAvailableTickets()	0	5	1
A	reindex()	0	9	2
A	isAvailable()	0	5	2
A	filterSet()	0	8	2

<?php

namespace ConferenceTools\Tickets\Domain\Service\TicketAvailability;

use Carnage\Cqrs\Persistence\ReadModel\RepositoryInterface;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Doctrine\Common\Collections\Criteria;
use ConferenceTools\Tickets\Domain\ReadModel\TicketCounts\TicketCounter;
use ConferenceTools\Tickets\Domain\ValueObject\TicketType;
use ConferenceTools\Tickets\Domain\Service\TicketAvailability\Filters\FilterInterface;

class TicketAvailability
{
    /**
     * @var FilterInterface[]
     */
    private $filters;

    /**
     * @var RepositoryInterface
     */
    private $repository;

    /**
     * TicketAvailability constructor.
     * @param RepositoryInterface $repository
     * @param FilterInterface[] $filters
     */
    public function __construct(RepositoryInterface $repository, FilterInterface ...$filters)
    {
        $this->filters = $filters;
        $this->repository = $repository;
    }

    /**
     * @return TicketCounter[]|Collection
     */
    public function fetchAllAvailableTickets()
    {
        $tickets = $this->repository->matching(new Criteria());

        return $this->reindex($this->filterSet($tickets));
    }

    public function isAvailable(TicketType $ticketType, int $quantity)
    {
        $tickets = $this->fetchAllAvailableTickets();
        return isset($tickets[$ticketType->getIdentifier()]) &&
            $tickets[$ticketType->getIdentifier()]->getRemaining() >= $quantity;
    }

    private function filterSet(Collection $tickets): Collection
    {
        foreach ($this->filters as $filter) {
            /** @var FilterInterface $tickets */
            $tickets = $filter->filter($tickets);

$tickets of type ConferenceTools\Tickets\Domain\Service\TicketAvailability\Filters\FilterInterface is incompatible with the type Doctrine\Common\Collections\Collection expected by parameter $tickets of ConferenceTools\Tickets\Domain\Service\TicketAvailability\Filters\FilterInterface::filter().

        }

        return $tickets;

The expression return $tickets could return the type ConferenceTools\Tickets\Domain\Service\TicketAvailability\Filters\FilterInterface which is incompatible with the type-hinted return Doctrine\Common\Collections\Collection. Consider adding an additional type-check to rule them out.

    }

    private function reindex(Collection $tickets): Collection
    {
        $result = [];
        foreach($tickets as $ticket) {
            /** @var TicketCounter $ticket */
            $result[$ticket->getTicketType()->getIdentifier()] = $ticket;
        }

        return new ArrayCollection($result);
    }
}