TicketType::isSupplementary() - Code Metrics - Inspection of "Supplementary tickets" - conferencetools/tickets-module - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#86)

by Chris

created 2017-12-18 18:31 UTC

TicketType::isSupplementary() A

↳ Parent: TicketType

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace ConferenceTools\Tickets\Domain\ValueObject;

use Doctrine\ORM\Mapping as ORM;
use JMS\Serializer\Annotation as Jms;

/**
 * Class TicketType
 * @package ConferenceTools\Tickets\Domain\ValueObject
 * @ORM\Embeddable
 */
final class TicketType
{
    /**
     * @var string
     * @Jms\Type("string")
     * @ORM\Column(type="string")
     */
    private $identifier;

    /**
     * @var Money
     * @ORM\Embedded(class="ConferenceTools\Tickets\Domain\ValueObject\Price")
     * @Jms\Type("ConferenceTools\Tickets\Domain\ValueObject\Price")
     */
    private $price;

    /**
     * @var string
     * @Jms\Type("string")
     * @ORM\Column(type="string")
     */
    private $displayName;

    /**
     * @var string
     * @Jms\Type("string")
     * @ORM\Column(type="string")
     */
    private $description;

    /**
     * @var boolean
     * @Jms\Type("boolean")
     * @ORM\Column(type="boolean")
     */
    private $supplementary = false;

    public function __construct(
        string $identifier,
        Price $price,
        string $displayName,
        string $description = '',
        bool $supplementary = false
    ) {
        $this->identifier = $identifier;
        $this->price = $price;

        $this->displayName = $displayName;
        $this->description = $description;
        $this->supplementary = $supplementary;
    }

    public function getIdentifier(): string
    {
        return $this->identifier;
    }

    public function getPrice(): Price
    {
        return $this->price;

    }

    public function getDisplayName(): string
    {
        return $this->displayName;
    }

    public function getDescription(): string
    {
        return $this->description;
    }

    public function isSupplementary(): bool
    {
        return $this->supplementary;
    }
}

1		<?php
2
3		namespace ConferenceTools\Tickets\Domain\ValueObject;
4
5		use Doctrine\ORM\Mapping as ORM;
6		use JMS\Serializer\Annotation as Jms;
7
8		/**
9		* Class TicketType
10		* @package ConferenceTools\Tickets\Domain\ValueObject
11		* @ORM\Embeddable
12		*/
13		final class TicketType
14		{
15		/**
16		* @var string
17		* @Jms\Type("string")
18		* @ORM\Column(type="string")
19		*/
20		private $identifier;
21
22		/**
23		* @var Money
24		* @ORM\Embedded(class="ConferenceTools\Tickets\Domain\ValueObject\Price")
25		* @Jms\Type("ConferenceTools\Tickets\Domain\ValueObject\Price")
26		*/
27		private $price;
28
29		/**
30		* @var string
31		* @Jms\Type("string")
32		* @ORM\Column(type="string")
33		*/
34		private $displayName;
35
36		/**
37		* @var string
38		* @Jms\Type("string")
39		* @ORM\Column(type="string")
40		*/
41		private $description;
42
43		/**
44		* @var boolean
45		* @Jms\Type("boolean")
46		* @ORM\Column(type="boolean")
47		*/
48		private $supplementary = false;
49
50	11	public function __construct(
51		string $identifier,
52		Price $price,
53		string $displayName,
54		string $description = '',
55		bool $supplementary = false
56		) {
57	11	$this->identifier = $identifier;
58	11	$this->price = $price;
		0 ignored issues – show Documentation Bug introduced 2017-11-05 16:12 UTC by Report Bug Copy Issue Report It seems like `$price` of type `ConferenceTools\Tickets\Domain\ValueObject\Price` is incompatible with the declared type `ConferenceTools\Tickets\Domain\ValueObject\Money` of property `$price`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
59	11	$this->displayName = $displayName;
60	11	$this->description = $description;
61	11	$this->supplementary = $supplementary;
62	11	}
63
64	5	public function getIdentifier(): string
65		{
66	5	return $this->identifier;
67		}
68
69	16	public function getPrice(): Price
70		{
71	16	return $this->price;
		0 ignored issues – show Bug Best Practice introduced 2017-12-08 18:18 UTC by Report Bug Copy Issue Report The expression `return $this->price` returns the type `ConferenceTools\Tickets\Domain\ValueObject\Money` which is incompatible with the type-hinted return `ConferenceTools\Tickets\Domain\ValueObject\Price`. Loading history...
72		}
73
74		public function getDisplayName(): string
75		{
76		return $this->displayName;
77		}
78
79		public function getDescription(): string
80		{
81		return $this->description;
82		}
83
84		public function isSupplementary(): bool
85		{
86		return $this->supplementary;
87		}
88		}

conferencetools / tickets-module

Pull Request — master (#86)

TicketType::isSupplementary() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like