ConferenceTools\Tickets\Domain\ValueObject\MoneyTest

Complexity

Total Complexity

7

Size/Duplication

Total Lines	74
Duplicated Lines	35.14 %

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	testCompare()	0	4	1
A	testExceptionWithDifferentCurrencies()	0	8	1
A	provideCompare()	0	11	1
A	testGreaterThan()	8	8	1
A	testEquals()	8	8	1
A	testLessThan()	8	8	1
A	testCreate()	0	5	1

<?php


namespace ConferenceTools\Tickets\Domain\ValueObject;


class MoneyTest extends \PHPUnit\Framework\TestCase
{
    public function testCreate()
    {
        $sut = Money::EUR(300);

The method EUR() does not exist on ConferenceTools\Tickets\Domain\ValueObject\Money. Since you implemented __callStatic, consider adding a @method annotation.

        self::assertEquals(300, $sut->getAmount());
        self::assertEquals('EUR', $sut->getCurrency());
    }

    /**
     * @dataProvider provideCompare
     *
     * @param Money $a
     * @param Money $b
     * @param int $expected
     */
    public function testCompare(Money $a, Money $b, $expected)
    {
        self::assertEquals($expected, $a->compare($b));
        self::assertEquals(-1 * $expected, $b->compare($a));
    }

    public function provideCompare()
    {
        $a = new Money(10, 'GBP');
        $b = new Money(10, 'GBP');
        $c = new Money(11, 'GBP');
        $d = new Money(12, 'GBP');
        return [
            [$a, $b, 0],
            [$b, $c, -1],
            [$c, $d, -1],
            [$d, $a, 1],
        ];
    }

    public function testExceptionWithDifferentCurrencies()
    {
        $this->setExpectedException(\InvalidArgumentException::class);

The function PHPUnit_Framework_TestCase::setExpectedException() has been deprecated: Method deprecated since Release 5.2.0; use expectException() instead

        $sut = new Money(10, 'GBP');
        $money1 = new Money(9, 'USD');

        $sut->compare($money1);
    }

    public function testEquals()

This method seems to be duplicated in your project.

    {
        $sut = new Money(10, 'GBP');
        $money1 = new Money(10, 'GBP');
        $money2 = new Money(11, 'GBP');

        self::assertTrue($sut->equals($money1));
        self::assertFalse($sut->equals($money2));
    }

    public function testLessThan()

This method seems to be duplicated in your project.

    {
        $sut = new Money(10, 'GBP');
        $money1 = new Money(9, 'GBP');
        $money2 =  new Money(11, 'GBP');

        self::assertTrue($sut->lessThan($money2));
        self::assertFalse($sut->lessThan($money1));
    }

    public function testGreaterThan()

This method seems to be duplicated in your project.

    {
        $sut = new Money(10, 'GBP');
        $money1 = new Money(9, 'GBP');
        $money2 = new Money(11, 'GBP');

        self::assertTrue($sut->greaterThan($money1));
        self::assertFalse($sut->greaterThan($money2));
    }
}