ConferenceTools\Tickets\Domain\ValueObject\BasketTest

Complexity

Total Complexity

7

Size/Duplication

Total Lines	140
Duplicated Lines	28.57 %

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	testGetTotalNoDiscount()	0	8	1
A	provideGetTotalNoDiscount()	17	17	1
A	testGetTotalWithDiscount()	0	9	1
A	provideGetTotalWithDiscount()	17	17	1
A	__construct()	0	13	1
B	provideContainingOnly()	0	25	1
A	testContainingOnly()	0	10	1

<?php

namespace ConferenceTools\Tickets\Domain\ValueObject;

use ConferenceTools\Tickets\Domain\Service\Configuration;
use ConferenceTools\Tickets\Domain\ValueObject\DiscountType\Percentage;

class BasketTest extends \PHPUnit\Framework\TestCase
{
    /**
     * @var Configuration
     */
    private $config;

    public function __construct($name = null, array $data = array(), $dataName = '')
    {
        parent::__construct($name, $data, $dataName);
        $this->config = Configuration::fromArray([
            'tickets' => [
                'early' => ['name' => 'Early Bird', 'cost' => 5000, 'available' => 75],
                'std' => ['name' => 'Standard', 'cost' => 10000, 'available' => 150],
                'free' => ['name' => 'Free', 'cost' => 0, 'available' => 0]
            ],
            'financial' => [
                'taxRate' => 10,
                'currency' => 'GBP',
                'displayTax' => true
            ]
        ]);
    }

    /**
     * @dataProvider provideGetTotalNoDiscount
     * @param array $reservations
     */
    public function testGetTotalNoDiscount(array $reservations, Price $expected)
    {
        $sut = Basket::fromReservations(
            $this->config,
            ... $reservations
        );

        $this->assertTrue($expected->equals($sut->getTotal()), 'Total didn\'t match expected total');
    }

    public function provideGetTotalNoDiscount()

This method seems to be duplicated in your project.

    {
        $stdReservation = new TicketReservation($this->config->getTicketType('std'), 'abc');
        $earlyReservation = new TicketReservation($this->config->getTicketType('early'), 'abc');

        return [
            [
                [$stdReservation],
                Price::fromNetCost(new Money(10000, $this->config->getCurrency()), $this->config->getTaxRate())
            ],
            [
                [$stdReservation, $stdReservation],
                Price::fromNetCost(new Money(20000, $this->config->getCurrency()), $this->config->getTaxRate())
            ],
            [
                [$stdReservation, $earlyReservation],
                Price::fromNetCost(new Money(15000, $this->config->getCurrency()), $this->config->getTaxRate())
            ]
        ];
    }

    /**
     * @dataProvider provideGetTotalWithDiscount
     * @param array $reservations
     */
    public function testGetTotalWithDiscount(array $reservations, Price $expected)
    {
        $sut = Basket::fromReservationsWithDiscount(
            $this->config,
            new DiscountCode('50off', '50% off', new Percentage(50)),
            ... $reservations
        );

        $this->assertTrue($expected->equals($sut->getTotal()), 'Total didn\'t match expected total');
    }

    public function provideGetTotalWithDiscount()

This method seems to be duplicated in your project.

    {
        $stdReservation = new TicketReservation($this->config->getTicketType('std'), 'abc');
        $earlyReservation = new TicketReservation($this->config->getTicketType('early'), 'abc');

        return [
            [
                [$stdReservation],
                Price::fromNetCost(new Money(5000, $this->config->getCurrency()), $this->config->getTaxRate())
            ],
            [
                [$stdReservation, $stdReservation],
                Price::fromNetCost(new Money(10000, $this->config->getCurrency()), $this->config->getTaxRate())
            ],
            [
                [$stdReservation, $earlyReservation],
                Price::fromNetCost(new Money(7500, $this->config->getCurrency()), $this->config->getTaxRate())
            ]
        ];
    }

    /**
     * @dataProvider provideContainingOnly
     *
     * @param $reservations
     * @param $ticketTypes
     * @param $expected
     */
    public function testContainingOnly($reservations, $ticketTypes, $expected)
    {
        $sut = Basket::fromReservations(
            $this->config,
            ... $reservations
        );

        $result = $sut->containingOnly(...$ticketTypes);

        $this->assertEquals($expected, array_values($result->getTickets()));

    }

    public function provideContainingOnly()
    {
        $stdReservation = new TicketReservation($this->config->getTicketType('std'), 'abc');
        $earlyReservation = new TicketReservation($this->config->getTicketType('early'), 'abc');

        return [
            [
                [$stdReservation],
                [$this->config->getTicketType('std')],
                [$stdReservation]
            ],
            [
                [$stdReservation, $stdReservation],
                [$this->config->getTicketType('std')],
                [$stdReservation, $stdReservation],
            ],
            [
                [$stdReservation, $earlyReservation],
                [$this->config->getTicketType('std')],
                [$stdReservation],
            ],
            [
                [$stdReservation, $earlyReservation],
                [$this->config->getTicketType('std'), $this->config->getTicketType('early')],
                [$stdReservation, $earlyReservation],
            ]
        ];
    }
}