ConferenceTools\Tickets\Domain\Service\Availability\DiscountCodeAvailability

Complexity

Total Complexity

7

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	fetchAllAvailableDiscountCodes()	0	5	1
A	filterSet()	0	8	2
A	reindex()	0	9	2
A	isAvailable()	0	4	1
A	__construct()	0	4	1

<?php

namespace ConferenceTools\Tickets\Domain\Service\Availability;

use Carnage\Cqrs\Persistence\ReadModel\RepositoryInterface;
use ConferenceTools\Tickets\Domain\Service\Configuration;
use ConferenceTools\Tickets\Domain\ValueObject\DiscountCode;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Doctrine\Common\Collections\Criteria;
use ConferenceTools\Tickets\Domain\ReadModel\Counts\TicketCounter;

The type ConferenceTools\Tickets\Domain\ReadModel\Counts\TicketCounter was not found. Maybe you did not declare it correctly or list all dependencies?

use ConferenceTools\Tickets\Domain\ValueObject\TicketType;
use ConferenceTools\Tickets\Domain\Service\Availability\Filters\FilterInterface;

class DiscountCodeAvailability
{
    /**
     * @var FilterInterface[]
     */
    private $filters;
    /**
     * @var RepositoryInterface
     */
    private $repository;

    /**
     * TicketAvailability constructor.
     * @param RepositoryInterface $repository
     * @param FilterInterface[] $filters
     */
    public function __construct(RepositoryInterface $repository, FilterInterface ...$filters)
    {
        $this->filters = $filters;
        $this->repository = $repository;
    }

    /**
     * @return TicketCounter[]|Collection
     */
    public function fetchAllAvailableDiscountCodes()
    {
        $tickets = $this->repository->matching(new Criteria());

        return $this->reindex($this->filterSet($tickets));
    }

    private function filterSet(Collection $tickets): Collection
    {
        foreach ($this->filters as $filter) {
            /** @var FilterInterface $tickets */
            $tickets = $filter->filter($tickets);

$tickets of type ConferenceTools\Tickets\Domain\Service\Availability\Filters\FilterInterface is incompatible with the type Doctrine\Common\Collections\Collection expected by parameter $tickets of ConferenceTools\Tickets\Domain\Service\Availability\Filters\FilterInterface::filter().

        }

        return $tickets;

The expression return $tickets could return the type ConferenceTools\Tickets\Domain\Service\Availability\Filters\FilterInterface which is incompatible with the type-hinted return Doctrine\Common\Collections\Collection. Consider adding an additional type-check to rule them out.

    }

    private function reindex(Collection $discountCodes): Collection
    {
        $result = [];
        foreach($discountCodes as $discountCode) {
            /** @var DiscountCode $discountCode */
            $result[$discountCode->getCode()] = $discountCode;
        }

        return new ArrayCollection($result);
    }

    public function isAvailable(DiscountCode $discountCode)
    {
        $discountCodes = $this->fetchAllAvailableDiscountCodes();
        return isset($discountCodes[$discountCode->getCode()]);
    }
}