DiscountByDate::filter() - Code Metrics - Inspection of "Discount availability by date" - conferencetools/tickets-module - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#82)

by Chris

created 2017-12-11 09:21 UTC

DiscountByDate::filter() A

↳ Parent: DiscountByDate

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	11
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	6
nc	1
nop	1
dl	11
loc	11
ccs	0
cts	7
cp	0
crap	2
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: imhotek
 * Date: 15/11/17
 * Time: 16:57
 */

namespace ConferenceTools\Tickets\Domain\Service\Availability\Filters;

use ConferenceTools\Tickets\Domain\ReadModel\Counts\TicketCounter;
filter:
    dependency_paths: ["lib/*"]
use ConferenceTools\Tickets\Domain\Service\Configuration;
use ConferenceTools\Tickets\Domain\ValueObject\DiscountCode;
use Doctrine\Common\Collections\Collection;

/**
 * @TODO refactor this to use a single filter
 */
class DiscountByDate implements FilterInterface

{
    /**
     * @var Configuration
     */
    private $configuration;

    public function __construct(Configuration $configuration)
    {
        $this->configuration = $configuration;
    }

    public function filter(Collection $tickets): Collection
    {
        $configuration = $this->configuration;
        $today = new \DateTime();

        $p = function (DiscountCode $discountCode) use ($configuration, $today) {
            $metadata = $configuration->getDiscountCodeMetadata($discountCode->getCode());
            return $metadata->isAvailableOn($today);
        };

        return $tickets->filter($p);
    }
}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: imhotek
5		* Date: 15/11/17
6		* Time: 16:57
7		*/
8
9		namespace ConferenceTools\Tickets\Domain\Service\Availability\Filters;
10
11		use ConferenceTools\Tickets\Domain\ReadModel\Counts\TicketCounter;
		0 ignored issues – show Bug introduced 2017-12-11 09:27 UTC by Report Bug Copy Issue Report The type `ConferenceTools\Tickets\...el\Counts\TicketCounter` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
12		use ConferenceTools\Tickets\Domain\Service\Configuration;
13		use ConferenceTools\Tickets\Domain\ValueObject\DiscountCode;
14		use Doctrine\Common\Collections\Collection;
15
16		/**
17		* @TODO refactor this to use a single filter
18		*/
19	View Code Duplication	class DiscountByDate implements FilterInterface
		0 ignored issues – show Duplication introduced 2017-12-11 09:27 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
20		{
21		/**
22		* @var Configuration
23		*/
24		private $configuration;
25
26		public function __construct(Configuration $configuration)
27		{
28		$this->configuration = $configuration;
29		}
30
31		public function filter(Collection $tickets): Collection
32		{
33		$configuration = $this->configuration;
34		$today = new \DateTime();
35
36		$p = function (DiscountCode $discountCode) use ($configuration, $today) {
37		$metadata = $configuration->getDiscountCodeMetadata($discountCode->getCode());
38		return $metadata->isAvailableOn($today);
39		};
40
41		return $tickets->filter($p);
42		}
43		}

conferencetools / tickets-module

Pull Request — master (#82)

DiscountByDate::filter() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like