Issues in TaxRate.php (master) - Issues in master - conferencetools/opentickets - Measure and Improve Code Quality continuously with Scrutinizer

Issues (81)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Domain/ValueObject/TaxRate.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace ConferenceTools\Tickets\Domain\ValueObject;

use Doctrine\ORM\Mapping as ORM;
use JMS\Serializer\Annotation as Jms;

/**
 * Class TaxRate
 * @package ConferenceTools\Tickets\Domain\ValueObject
 * @ORM\Embeddable
 */
class TaxRate
{
    /**
     * @var string
     * @Jms\Type("integer")
     * @ORM\Column(type="integer")
     */
    private $percentage;

    /**
     * TaxRate constructor.
     * @param $percentage
     */
    public function __construct(int $percentage)
    {
        $this->percentage = $percentage;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
    }

    /**
     * @return int
     */
    public function getPercentage(): int
    {
        return $this->percentage;
    }

    public function calculateTaxFromNet(Money $net): Money
    {
        return $net->multiply($this->getPercentageAsFloat());
    }

    public function calculateGross(Money $net): Money
    {
        return $net->add($this->calculateTaxFromNet($net));
    }

    public function calculateTaxFromGross(Money $gross): Money
    {
        return $gross->subtract($gross->multiply($this->getInversePercentage()));
    }

    public function calculateNet(Money $gross): Money
    {
        return $gross->subtract($this->calculateTaxFromGross($gross));
    }

    /**
     * @return float
     */
    private function getInversePercentage()
    {
        return 1 / (1 + $this->getPercentageAsFloat());
    }

    /**
     * @return float
     */
    private function getPercentageAsFloat(): float
    {
        return (float) ($this->percentage / 100);
    }

    /**
     * @param TaxRate $other
     * @return bool
     */
    public function equals(TaxRate $other): bool
    {
        return ($other->percentage === $this->percentage);
    }

    /**
     * @param TaxRate $other
     * @return int
     */
    public function compare(TaxRate $other): int
    {
        if ($this->percentage < $other->percentage) {
            return -1;
        } elseif ($this->percentage == $other->percentage) {
            return 0;
        } else {
            return 1;
        }
    }

    /**
     * @param TaxRate $other
     * @return bool
     */
    public function greaterThan(TaxRate $other): bool
    {
        return 1 === $this->compare($other);
    }

    /**
     * @param TaxRate $other
     * @return bool
     */
    public function lessThan(TaxRate $other): bool
    {
        return -1 === $this->compare($other);
    }
}

1		<?php
2
3		namespace ConferenceTools\Tickets\Domain\ValueObject;
4
5		use Doctrine\ORM\Mapping as ORM;
6		use JMS\Serializer\Annotation as Jms;
7
8		/**
9		* Class TaxRate
10		* @package ConferenceTools\Tickets\Domain\ValueObject
11		* @ORM\Embeddable
12		*/
13		class TaxRate
14		{
15		/**
16		* @var string
17		* @Jms\Type("integer")
18		* @ORM\Column(type="integer")
19		*/
20		private $percentage;
21
22		/**
23		* TaxRate constructor.
24		* @param $percentage
25		*/
26	31	public function __construct(int $percentage)
27		{
28	31	$this->percentage = $percentage;
		0 ignored issues – show Documentation Bug introduced 2017-02-03 11:17 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$percentage` was declared of type `string`, but `$percentage` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
29	31	}
30
31		/**
32		* @return int
33		*/
34	1	public function getPercentage(): int
35		{
36	1	return $this->percentage;
37		}
38
39	3	public function calculateTaxFromNet(Money $net): Money
40		{
41	3	return $net->multiply($this->getPercentageAsFloat());
42		}
43
44	2	public function calculateGross(Money $net): Money
45		{
46	2	return $net->add($this->calculateTaxFromNet($net));
47		}
48
49	1	public function calculateTaxFromGross(Money $gross): Money
50		{
51	1	return $gross->subtract($gross->multiply($this->getInversePercentage()));
52		}
53
54	1	public function calculateNet(Money $gross): Money
55		{
56	1	return $gross->subtract($this->calculateTaxFromGross($gross));
57		}
58
59		/**
60		* @return float
61		*/
62	1	private function getInversePercentage()
63		{
64	1	return 1 / (1 + $this->getPercentageAsFloat());
65		}
66
67		/**
68		* @return float
69		*/
70	3	private function getPercentageAsFloat(): float
71		{
72	3	return (float) ($this->percentage / 100);
73		}
74
75		/**
76		* @param TaxRate $other
77		* @return bool
78		*/
79	29	public function equals(TaxRate $other): bool
80		{
81	29	return ($other->percentage === $this->percentage);
82		}
83
84		/**
85		* @param TaxRate $other
86		* @return int
87		*/
88	6	public function compare(TaxRate $other): int
89		{
90	6	if ($this->percentage < $other->percentage) {
91	5	return -1;
92	6	} elseif ($this->percentage == $other->percentage) {
93	1	return 0;
94		} else {
95	5	return 1;
96		}
97		}
98
99		/**
100		* @param TaxRate $other
101		* @return bool
102		*/
103	1	public function greaterThan(TaxRate $other): bool
104		{
105	1	return 1 === $this->compare($other);
106		}
107
108		/**
109		* @param TaxRate $other
110		* @return bool
111		*/
112	1	public function lessThan(TaxRate $other): bool
113		{
114	1	return -1 === $this->compare($other);
115		}
116		}

conferencetools / opentickets

Issues (81)

Security Analysis no request data

src/Domain/ValueObject/TaxRate.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like