TicketType::getPrice() - Code Metrics - Inspection of "Merge pull request #64 from conferencetools/rename..." - conferencetools/opentickets - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c541cb...64a56e )

by Chris

created 2017-06-30 12:38 UTC

TicketType::getPrice() A

↳ Parent: TicketType

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
rs	10
c	0
b	0
f	0
ccs	2
cts	2
cp	1
crap	1

<?php

namespace ConferenceTools\Tickets\Domain\ValueObject;

use Doctrine\ORM\Mapping as ORM;
use JMS\Serializer\Annotation as Jms;

/**
 * Class TicketType
 * @package ConferenceTools\Tickets\Domain\ValueObject
 * @ORM\Embeddable
 */
final class TicketType
{
    /**
     * @var string
     * @Jms\Type("string")
     * @ORM\Column(type="string")
     */
    private $identifier;

    /**
     * @var Money
     * @ORM\Embedded(class="ConferenceTools\Tickets\Domain\ValueObject\Price")
     * @Jms\Type("ConferenceTools\Tickets\Domain\ValueObject\Price")
     */
    private $price;

    /**
     * @var string
     * @Jms\Type("string")
     * @ORM\Column(type="string")
     */
    private $displayName;

    /**
     * TicketType constructor.
     * @param string $identifier
     * @param Price $price
     * @param string $displayName
     */
    public function __construct(string $identifier, Price $price, string $displayName)
    {
        $this->identifier = $identifier;
        $this->price = $price;

        $this->displayName = $displayName;
    }

    /**
     * @return string
     */
    public function getIdentifier(): string
    {
        return $this->identifier;
    }

    /**
     * @return Price
     */
    public function getPrice(): Price
    {
        return $this->price;
    }

    /**
     * @return string
     */
    public function getDisplayName(): string 
    {
        return $this->displayName;
    }
}

1		<?php
2
3		namespace ConferenceTools\Tickets\Domain\ValueObject;
4
5		use Doctrine\ORM\Mapping as ORM;
6		use JMS\Serializer\Annotation as Jms;
7
8		/**
9		* Class TicketType
10		* @package ConferenceTools\Tickets\Domain\ValueObject
11		* @ORM\Embeddable
12		*/
13		final class TicketType
14		{
15		/**
16		* @var string
17		* @Jms\Type("string")
18		* @ORM\Column(type="string")
19		*/
20		private $identifier;
21
22		/**
23		* @var Money
24		* @ORM\Embedded(class="ConferenceTools\Tickets\Domain\ValueObject\Price")
25		* @Jms\Type("ConferenceTools\Tickets\Domain\ValueObject\Price")
26		*/
27		private $price;
28
29		/**
30		* @var string
31		* @Jms\Type("string")
32		* @ORM\Column(type="string")
33		*/
34		private $displayName;
35
36		/**
37		* TicketType constructor.
38		* @param string $identifier
39		* @param Price $price
40		* @param string $displayName
41		*/
42	11	public function __construct(string $identifier, Price $price, string $displayName)
43		{
44	11	$this->identifier = $identifier;
45	11	$this->price = $price;
		0 ignored issues – show Documentation Bug introduced 2017-06-03 10:51 UTC by Report Bug Copy Issue Report It seems like `$price` of type `object<ConferenceTools\T...main\ValueObject\Price>` is incompatible with the declared type `object<ConferenceTools\T...main\ValueObject\Money>` of property `$price`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
46	11	$this->displayName = $displayName;
47	11	}
48
49		/**
50		* @return string
51		*/
52	5	public function getIdentifier(): string
53		{
54	5	return $this->identifier;
55		}
56
57		/**
58		* @return Price
59		*/
60	7	public function getPrice(): Price
61		{
62	7	return $this->price;
63		}
64
65		/**
66		* @return string
67		*/
68		public function getDisplayName(): string
69		{
70		return $this->displayName;
71		}
72		}

conferencetools / opentickets

Push — master ( c541cb...64a56e )

TicketType::getPrice() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like