Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 14 | View Code Duplication | class AssignToDelegate implements CommandInterface |
|
|
|
|||
| 15 | { |
||
| 16 | /** |
||
| 17 | * @var Delegate |
||
| 18 | */ |
||
| 19 | private $delegate; |
||
| 20 | |||
| 21 | /** |
||
| 22 | * @var string |
||
| 23 | */ |
||
| 24 | private $ticketId; |
||
| 25 | |||
| 26 | /** |
||
| 27 | * @var string |
||
| 28 | */ |
||
| 29 | private $purchaseId; |
||
| 30 | |||
| 31 | /** |
||
| 32 | * AssignToDelegate constructor. |
||
| 33 | * @param $delegate |
||
| 34 | * @param $ticketId |
||
| 35 | * @param $purchaseId |
||
| 36 | */ |
||
| 37 | public function __construct(Delegate $delegate, string $ticketId, string $purchaseId) |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @return Delegate |
||
| 46 | */ |
||
| 47 | public function getDelegate(): Delegate |
||
| 51 | |||
| 52 | /** |
||
| 53 | * @return string |
||
| 54 | */ |
||
| 55 | public function getTicketId(): string |
||
| 59 | |||
| 60 | /** |
||
| 61 | * @return string |
||
| 62 | */ |
||
| 63 | public function getPurchaseId(): string |
||
| 67 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.