SortableTrait::calculateSort() - Code Metrics - Inspection of "Sortable and Layout Entity Tests" - components-web-app/api-components-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 258453...5d2ce0 )

by Daniel

created 2018-02-27 22:30 UTC

SortableTrait::calculateSort() B

↳ Parent: SortableTrait

Complexity

Conditions	5
Paths	5

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5

Importance

Changes

Metric	Value
cc	5
eloc	8
nc	5
nop	1
dl	0
loc	13
ccs	9
cts	9
cp	1
crap	5
rs	8.8571
c	0
b	0
f	0

<?php

namespace Silverback\ApiComponentBundle\Entity;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Doctrine\ORM\Mapping as ORM;
use Symfony\Component\Validator\Constraints as Assert;

/**
 * Trait SortableTrait
 * @package Silverback\ApiComponentBundle\Entity
 * @author Daniel West <[email protected]>
 */
trait SortableTrait
{
    /**
     * @ORM\Column(type="integer", nullable=false)
     * @Assert\NotNull()
     * @var int
     */
    protected $sort;

    /**
     * @return int
     */
    public function getSort(): int
    {
        return $this->sort;
    }

    /**
     * @param int $sort
     * @return SortableTrait|SortableInterface
     */
    public function setSort(int $sort = 0)
    {
        $this->sort = $sort;
        return $this;
    }

    /**
     * @param bool|null $sortLast
     * @return int
     */
    final public function calculateSort(?bool $sortLast = null): int
    {
        /* @var $collection Collection|SortableInterface[] */
        $collection = $this->getSortCollection();
        if (null === $sortLast) {
            return 0;
        }
        if ($sortLast) {
            $lastItem = $collection->last();
            return $lastItem ? ($lastItem->getSort() + 1) : 0;
        }
        $firstItem = $collection->first();
        return $firstItem ? ($firstItem->getSort() - 1) : 0;
    }

    /**
     * @return ArrayCollection
     */
    abstract public function getSortCollection(): ArrayCollection;
}


1		<?php
2
3		namespace Silverback\ApiComponentBundle\Entity;
4
5		use Doctrine\Common\Collections\ArrayCollection;
6		use Doctrine\Common\Collections\Collection;
7		use Doctrine\ORM\Mapping as ORM;
8		use Symfony\Component\Validator\Constraints as Assert;
9
10		/**
11		* Trait SortableTrait
12		* @package Silverback\ApiComponentBundle\Entity
13		* @author Daniel West <[email protected]>
14		*/
15		trait SortableTrait
16		{
17		/**
18		* @ORM\Column(type="integer", nullable=false)
19		* @Assert\NotNull()
20		* @var int
21		*/
22		protected $sort;
23
24		/**
25		* @return int
26		*/
27	2	public function getSort(): int
28		{
29	2	return $this->sort;
30		}
31
32		/**
33		* @param int $sort
34		* @return SortableTrait\|SortableInterface
35		*/
36	2	public function setSort(int $sort = 0)
37		{
38	2	$this->sort = $sort;
39	2	return $this;
40		}
41
42		/**
43		* @param bool\|null $sortLast
44		* @return int
45		*/
46	1	final public function calculateSort(?bool $sortLast = null): int
47		{
48		/* @var $collection Collection\|SortableInterface[] */
49	1	$collection = $this->getSortCollection();
50	1	if (null === $sortLast) {
51	1	return 0;
52		}
53	1	if ($sortLast) {
54	1	$lastItem = $collection->last();
55	1	return $lastItem ? ($lastItem->getSort() + 1) : 0;
56		}
57	1	$firstItem = $collection->first();
58	1	return $firstItem ? ($firstItem->getSort() - 1) : 0;
59		}
60
61		/**
62		* @return ArrayCollection
63		*/
64		abstract public function getSortCollection(): ArrayCollection;
65		}
66

components-web-app / api-components-bundle

Push — develop ( 258453...5d2ce0 )

SortableTrait::calculateSort() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like