Silverback\ApiComponentBundle\EventListener\Api\PublishableEventListener

Complexity

Total Complexity

15

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	handlePUTRequest()	0	52	8
A	__invoke()	0	17	5
A	handlePOSTRequest()	0	8	2

<?php

/*
 * This file is part of the Silverback API Component Bundle Project
 *
 * (c) Daniel West <daniel@silverback.is>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Silverback\ApiComponentBundle\EventListener\Api;

use Doctrine\ORM\Mapping\ClassMetadataInfo;
use Doctrine\Persistence\ManagerRegistry;
use Silverback\ApiComponentBundle\Annotation\Publishable;
use Silverback\ApiComponentBundle\Publishable\ClassMetadataTrait;
use Silverback\ApiComponentBundle\Publishable\PublishableHelper;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Event\ViewEvent;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;

/**
 * @author Vincent Chalamon <vincent@les-tilleuls.coop>
 */
final class PublishableEventListener
{
    use ClassMetadataTrait;

    private PublishableHelper $publishableHelper;
    private ManagerRegistry $registry;

The private property $registry is not used, and could be removed.

    public function __invoke(ViewEvent $event): void
    {
        $request = $event->getRequest();
        $data = $request->attributes->get('data');
        if (!$this->publishableHelper->isPublishable($data)) {
            return;
        }

        $configuration = $this->publishableHelper->getConfiguration($data);
        $classMetadata = $this->getClassMetadata($data);

        if ($request->isMethod(Request::METHOD_POST)) {
            $this->handlePOSTRequest($classMetadata, $configuration, $data);

It seems like $configuration can also be of type null; however, parameter $configuration of Silverback\ApiComponentBundle\EventListener\Api\PublishableEventListener::handlePOSTRequest() does only seem to accept Silverback\ApiComponentBundle\Annotation\Publishable, maybe add an additional type check?

        }

        if ($request->isMethod(Request::METHOD_PUT) || $request->isMethod(Request::METHOD_PATCH)) {
            $this->handlePUTRequest($classMetadata, $configuration, $data, $request);

It seems like $configuration can also be of type null; however, parameter $configuration of Silverback\ApiComponentBundle\EventListener\Api\PublishableEventListener::handlePUTRequest() does only seem to accept Silverback\ApiComponentBundle\Annotation\Publishable, maybe add an additional type check?

        }
    }

    private function handlePOSTRequest(ClassMetadataInfo $classMetadata, Publishable $configuration, object $data): void
    {
        // It's not possible for a user to define a resource as draft from another
        $classMetadata->setFieldValue($data, $configuration->associationName, null);

        // User doesn't have draft access: force publication date
        if (!$this->publishableHelper->isGranted()) {
            $classMetadata->setFieldValue($data, $configuration->fieldName, new \DateTimeImmutable());
        }
    }

    private function handlePUTRequest(ClassMetadataInfo $classMetadata, Publishable $configuration, object $data, Request $request): void
    {
        $changeSet = $this->getEntityManager($data)->getUnitOfWork()->getEntityChangeSet($data);

        // It's not possible to change the publishedResource property
        if (isset($changeSet[$configuration->associationName])) {
            $classMetadata->setFieldValue($data, $configuration->associationName, $changeSet[$configuration->associationName][0]);
        }

        // User doesn't have draft access: cannot change the publication date
        if (!$this->publishableHelper->isGranted()) {
            if (isset($changeSet[$configuration->fieldName])) {
                $classMetadata->setFieldValue($data, $configuration->fieldName, $changeSet[$configuration->fieldName][0]);
            }

            // Nothing to do here anymore for user without draft access
            return;
        }

        // User requested for original object
        if (true === $request->query->getBoolean('published', false)) {
            // User cannot change the publication date of the original resource
            if ($changeSet[$configuration->fieldName]) {
                throw new BadRequestHttpException('You cannot change the publication date of a published resource.');
            }

            // User wants to update the original object: nothing to do here anymore
            return;
        }

        // Resource is a draft of another resource: nothing to do here anymore
        if (null !== $classMetadata->getFieldValue($data, $configuration->associationName)) {
            return;
        }

        // Any field has been modified: create or update draft
        $draft = $this->getEntityManager($data)->getRepository($this->getObjectClass($data))->findOneBy([
            $configuration->associationName => $data,
        ]);
        if (!$draft) {
            $draft = clone $data;
            // Reset draft identifier(s)
            $classMetadata->setIdentifierValues($draft, array_combine($classMetadata->getIdentifierFieldNames(), array_fill(0, \count($classMetadata->getIdentifierFieldNames()), null)));

It seems like array_combine($classMetadata->getIdentifierFieldNames(), array_fill(0, count($classMetadata->getIdentifierFieldNames()), null)) can also be of type false; however, parameter $id of Doctrine\ORM\Mapping\ClassMetadataInfo::setIdentifierValues() does only seem to accept array, maybe add an additional type check?

            $this->getEntityManager($draft)->persist($draft);
        }

        // Replace data by its draft
        $request->attributes->set('data', $draft);

        // Rollback modifications on original resource
        $this->getEntityManager($data)->refresh($data);
    }
}