RouteAwareTrait::addRoute() - Code Metrics - Inspection of "Require ramsey/uuid" - components-web-app/api-components-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — develop (ac2838)

by Daniel

created 2018-02-23 10:07 UTC

RouteAwareTrait::addRoute() A

↳ Parent: RouteAwareTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace Silverback\ApiComponentBundle\Entity\Navigation\Route;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\ORM\Mapping as ORM;
use Symfony\Component\Serializer\Annotation\Groups;

trait RouteAwareTrait
{
    /**
     * @ORM\OneToMany(targetEntity="Silverback\ApiComponentBundle\Entity\Navigation\Route\Route", mappedBy="content")
     * @Groups({"layout", "content", "component"})
     * @var ArrayCollection|Route[]
     */
    protected $routes;

    /**
     * @param Route $route
     * @return RouteAwareInterface
     */
    public function addRoute(Route $route): RouteAwareInterface
    {
        $this->routes->add($route);
        return $this;

    }

    /**
     * @param Route $route
     * @return RouteAwareInterface
     */
    public function removeRoute(Route $route): RouteAwareInterface
    {
        $this->routes->removeElement($route);
        return $this;

    }
}


1			<?php
2
3			namespace Silverback\ApiComponentBundle\Entity\Navigation\Route;
4
5			use Doctrine\Common\Collections\ArrayCollection;
6			use Doctrine\ORM\Mapping as ORM;
7			use Symfony\Component\Serializer\Annotation\Groups;
8
9			trait RouteAwareTrait
10			{
11			/**
12			* @ORM\OneToMany(targetEntity="Silverback\ApiComponentBundle\Entity\Navigation\Route\Route", mappedBy="content")
13			* @Groups({"layout", "content", "component"})
14			* @var ArrayCollection\|Route[]
15			*/
16			protected $routes;
17
18			/**
19			* @param Route $route
20			* @return RouteAwareInterface
21			*/
22			public function addRoute(Route $route): RouteAwareInterface
23			{
24			$this->routes->add($route);
25			return $this;
			0 ignored issues – show Bug Best Practice introduced 2018-02-23 10:16 UTC by Report Bug Copy Issue Report The expression `return $this` returns the type `Silverback\ApiComponentB...n\Route\RouteAwareTrait` which is incompatible with the type-hinted return `Silverback\ApiComponentB...ute\RouteAwareInterface`. Loading history...
26			}
27
28			/**
29			* @param Route $route
30			* @return RouteAwareInterface
31			*/
32			public function removeRoute(Route $route): RouteAwareInterface
33			{
34			$this->routes->removeElement($route);
35			return $this;
			0 ignored issues – show Bug Best Practice introduced 2018-02-23 10:16 UTC by Report Bug Copy Issue Report The expression `return $this` returns the type `Silverback\ApiComponentB...n\Route\RouteAwareTrait` which is incompatible with the type-hinted return `Silverback\ApiComponentB...ute\RouteAwareInterface`. Loading history...
36			}
37			}
38

components-web-app / api-components-bundle

Branch — develop (ac2838)

RouteAwareTrait::addRoute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like