FormView::__construct() - Code Metrics - Inspection of "Require ramsey/uuid" - components-web-app/api-components-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — develop (ac2838)

by Daniel

created 2018-02-23 10:07 UTC

FormView::__construct() C

↳ Parent: FormView

Complexity

Conditions	8
Paths	12

Size

Total Lines	52
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	39
nc	12
nop	2
dl	0
loc	52
rs	6.8493
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Silverback\ApiComponentBundle\Entity\Component\Form;

use Doctrine\Common\Collections\ArrayCollection;
use Symfony\Component\Serializer\Annotation\Groups;

/**
 * Class FormView
 * @package Silverback\ApiComponentBundle\Entity\Component\Form
 * @author Daniel West <[email protected]>
 */
class FormView
{
    /**
     * @Groups({"page"})
     * @var array
     */
    private $vars;

    /**
     * @Groups({"page"})
     * @var ArrayCollection
     */
    private $children;

    /**
     * @Groups({"page"})
     * @var bool
     */
    private $rendered;

    /**
     * @Groups({"page"})
     * @var bool
     */
    private $methodRendered;

    public function __construct(\Symfony\Component\Form\FormView $formViews, bool $children = true)
    {
        $varsToArray = ['choices', 'preferred_choices', 'errors', 'is_selected'];

        $outputVars = array_merge($varsToArray, [
            'value',
            'attr',
            'id',
            'name',
            'full_name',
            'disabled',
            'label',
            'block_prefixes',
            'unique_block_prefix',
            'valid',
            'required',
            'label_attr',
            'expanded',
            'submitted',
            'placeholder',
            'is_selected',
            'placeholder_in_choices',
            'checked',
            'action',
            'multiple'
        ]);
        foreach ($outputVars as $var) {
            if (isset($formViews->vars[$var])) {
                $this->vars[$var] = $formViews->vars[$var];

                if (in_array($var, $varsToArray)) {
                    $choices = $this->vars[$var];
                    $this->vars[$var] = [];
                    foreach ($choices as $choice) {
                        if (method_exists($choice, 'getMessage')) {
                            $this->vars[$var][] = $choice->getMessage();
                        } else {
                            $this->vars[$var][] = (array) $choice;
                        }
                    }
                }
            }
        }

        if ($children) {
            $this->children = new ArrayCollection();
            foreach ($formViews as $formView) {
                $this->addChild($formView);
            }
        }
        $this->rendered = $formViews->isRendered();
        $this->methodRendered = $formViews->isMethodRendered();
    }

    public function addChild(\Symfony\Component\Form\FormView $formViews)
    {
        $formView = new FormView($formViews);
        $this->children->add($formView);
    }

    /**
     * @return array
     */
    public function getVars(): array
    {
        return $this->vars;
    }

    /**
     * @return ArrayCollection
     */
    public function getChildren(): ArrayCollection
    {
        return $this->children;
    }

    /**
     * @return bool
     */
    public function isRendered(): bool
    {
        return $this->rendered;
    }

    /**
     * @return bool
     */
    public function isMethodRendered(): bool
    {
        return $this->methodRendered;
    }
}


1			<?php
2
3			namespace Silverback\ApiComponentBundle\Entity\Component\Form;
4
5			use Doctrine\Common\Collections\ArrayCollection;
6			use Symfony\Component\Serializer\Annotation\Groups;
7
8			/**
9			* Class FormView
10			* @package Silverback\ApiComponentBundle\Entity\Component\Form
11			* @author Daniel West <[email protected]>
12			*/
13			class FormView
14			{
15			/**
16			* @Groups({"page"})
17			* @var array
18			*/
19			private $vars;
20
21			/**
22			* @Groups({"page"})
23			* @var ArrayCollection
24			*/
25			private $children;
26
27			/**
28			* @Groups({"page"})
29			* @var bool
30			*/
31			private $rendered;
32
33			/**
34			* @Groups({"page"})
35			* @var bool
36			*/
37			private $methodRendered;
38
39			public function __construct(\Symfony\Component\Form\FormView $formViews, bool $children = true)
40			{
41			$varsToArray = ['choices', 'preferred_choices', 'errors', 'is_selected'];
42
43			$outputVars = array_merge($varsToArray, [
44			'value',
45			'attr',
46			'id',
47			'name',
48			'full_name',
49			'disabled',
50			'label',
51			'block_prefixes',
52			'unique_block_prefix',
53			'valid',
54			'required',
55			'label_attr',
56			'expanded',
57			'submitted',
58			'placeholder',
59			'is_selected',
60			'placeholder_in_choices',
61			'checked',
62			'action',
63			'multiple'
64			]);
65			foreach ($outputVars as $var) {
66			if (isset($formViews->vars[$var])) {
67			$this->vars[$var] = $formViews->vars[$var];
68
69			if (in_array($var, $varsToArray)) {
70			$choices = $this->vars[$var];
71			$this->vars[$var] = [];
72			foreach ($choices as $choice) {
73			if (method_exists($choice, 'getMessage')) {
74			$this->vars[$var][] = $choice->getMessage();
75			} else {
76			$this->vars[$var][] = (array) $choice;
77			}
78			}
79			}
80			}
81			}
82
83			if ($children) {
84			$this->children = new ArrayCollection();
85			foreach ($formViews as $formView) {
86			$this->addChild($formView);
87			}
88			}
89			$this->rendered = $formViews->isRendered();
90			$this->methodRendered = $formViews->isMethodRendered();
91			}
92
93			public function addChild(\Symfony\Component\Form\FormView $formViews)
94			{
95			$formView = new FormView($formViews);
96			$this->children->add($formView);
97			}
98
99			/**
100			* @return array
101			*/
102			public function getVars(): array
103			{
104			return $this->vars;
105			}
106
107			/**
108			* @return ArrayCollection
109			*/
110			public function getChildren(): ArrayCollection
111			{
112			return $this->children;
113			}
114
115			/**
116			* @return bool
117			*/
118			public function isRendered(): bool
119			{
120			return $this->rendered;
121			}
122
123			/**
124			* @return bool
125			*/
126			public function isMethodRendered(): bool
127			{
128			return $this->methodRendered;
129			}
130			}
131

components-web-app / api-components-bundle

Branch — develop (ac2838)

FormView::__construct() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like