LayoutDataProvider::getItem() - Code Metrics - Inspection of "Require ramsey/uuid" - components-web-app/api-components-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — develop (ac2838)

by Daniel

created 2018-02-23 10:07 UTC

LayoutDataProvider::getItem() A

↳ Parent: LayoutDataProvider

Complexity

Conditions	4
Paths	2

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	8
nc	2
nop	4
dl	0
loc	12
rs	9.2
c	0
b	0
f	0

<?php

namespace Silverback\ApiComponentBundle\DataProvider\Item;

use ApiPlatform\Core\DataProvider\ItemDataProviderInterface;
use ApiPlatform\Core\Exception\ResourceClassNotSupportedException;
use Doctrine\Common\Persistence\ManagerRegistry;
use Doctrine\Common\Persistence\ObjectRepository;
use Silverback\ApiComponentBundle\Entity\Layout\Layout;

final class LayoutDataProvider implements ItemDataProviderInterface
{
    /**
     * @var ObjectRepository
     */
    private $managerRegistry;

    /**
     * LayoutDataProvider constructor.
     *
     * @param ManagerRegistry $managerRegistry
     */
    public function __construct(ManagerRegistry $managerRegistry)
    {
        $this->managerRegistry = $managerRegistry;

    }

    /**
     * @param string      $resourceClass
     * @param int|string  $id
     * @param string|null $operationName
     * @param array       $context
     *
     * @return Layout|null
     * @throws ResourceClassNotSupportedException
     */
    public function getItem(string $resourceClass, $id, string $operationName = null, array $context = [])
    {
        $manager = $this->managerRegistry->getManagerForClass($resourceClass);
        if (
            null === $manager ||
            Layout::class !== $resourceClass ||
            $id !== 'default'
        ) {
            throw new ResourceClassNotSupportedException('This provider only supports getting the default layout');
        }
        $repository = $manager->getRepository($resourceClass);
        return $repository->findOneBy(['default' => true]);
    }
}


1			<?php
2
3			namespace Silverback\ApiComponentBundle\DataProvider\Item;
4
5			use ApiPlatform\Core\DataProvider\ItemDataProviderInterface;
6			use ApiPlatform\Core\Exception\ResourceClassNotSupportedException;
7			use Doctrine\Common\Persistence\ManagerRegistry;
8			use Doctrine\Common\Persistence\ObjectRepository;
9			use Silverback\ApiComponentBundle\Entity\Layout\Layout;
10
11			final class LayoutDataProvider implements ItemDataProviderInterface
12			{
13			/**
14			* @var ObjectRepository
15			*/
16			private $managerRegistry;
17
18			/**
19			* LayoutDataProvider constructor.
20			*
21			* @param ManagerRegistry $managerRegistry
22			*/
23			public function __construct(ManagerRegistry $managerRegistry)
24			{
25			$this->managerRegistry = $managerRegistry;
			0 ignored issues – show Documentation Bug introduced 2018-02-23 10:16 UTC by Report Bug Copy Issue Report It seems like `$managerRegistry` of type `Doctrine\Common\Persistence\ManagerRegistry` is incompatible with the declared type `Doctrine\Common\Persistence\ObjectRepository` of property `$managerRegistry`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
26			}
27
28			/**
29			* @param string $resourceClass
30			* @param int\|string $id
31			* @param string\|null $operationName
32			* @param array $context
33			*
34			* @return Layout\|null
35			* @throws ResourceClassNotSupportedException
36			*/
37			public function getItem(string $resourceClass, $id, string $operationName = null, array $context = [])
38			{
39			$manager = $this->managerRegistry->getManagerForClass($resourceClass);
40			if (
41			null === $manager \|\|
42			Layout::class !== $resourceClass \|\|
43			$id !== 'default'
44			) {
45			throw new ResourceClassNotSupportedException('This provider only supports getting the default layout');
46			}
47			$repository = $manager->getRepository($resourceClass);
48			return $repository->findOneBy(['default' => true]);
49			}
50			}
51

components-web-app / api-components-bundle

Branch — develop (ac2838)

LayoutDataProvider::getItem() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like