DynamicPageSubscriber::setComponentLocations() - Code Metrics - Inspection of "Further test removals" - components-web-app/api-components-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( f05cec...11f198 )

by Daniel

created 2018-11-09 17:04 UTC

DynamicPageSubscriber::setComponentLocations() A

↳ Parent: DynamicPageSubscriber

Complexity

Conditions	4
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
cc	4
eloc	8
nc	3
nop	1
dl	0
loc	14
ccs	0
cts	9
cp	0
crap	20
rs	10
c	0
b	0
f	0

<?php

namespace Silverback\ApiComponentBundle\EventSubscriber\ApiPlatform;

use ApiPlatform\Core\EventListener\EventPriorities;
use Silverback\ApiComponentBundle\Entity\Content\Dynamic\AbstractDynamicPage;
use Silverback\ApiComponentBundle\Repository\ComponentLocationRepository;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent;
use Symfony\Component\HttpKernel\KernelEvents;

class DynamicPageSubscriber extends AbstractSubscriber
{
    public static function getSubscribedEvents(): array
    {
        return [
            KernelEvents::VIEW => [
                ['setComponentLocations', EventPriorities::PRE_SERIALIZE]
            ]
        ];
    }

    public static function getSubscribedServices(): array
    {
        return [
            '?' . ComponentLocationRepository::class
        ];
    }

    public function setComponentLocations(GetResponseForControllerResultEvent $event): void
    {
        $page = $event->getControllerResult();
        $method = $event->getRequest()->getMethod();

        if (!$page instanceof AbstractDynamicPage || Request::METHOD_GET !== $method) {
            return;
        }

        /** @var ComponentLocationRepository $repository */
        $repository = $this->container->get(ComponentLocationRepository::class);
        $locations = $repository->findByDynamicPage($page);
        if ($locations) {

            $page->setComponentLocations($locations);
        }
    }
}


1			<?php
2
3			namespace Silverback\ApiComponentBundle\EventSubscriber\ApiPlatform;
4
5			use ApiPlatform\Core\EventListener\EventPriorities;
6			use Silverback\ApiComponentBundle\Entity\Content\Dynamic\AbstractDynamicPage;
7			use Silverback\ApiComponentBundle\Repository\ComponentLocationRepository;
8			use Symfony\Component\HttpFoundation\Request;
9			use Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent;
10			use Symfony\Component\HttpKernel\KernelEvents;
11
12			class DynamicPageSubscriber extends AbstractSubscriber
13			{
14			public static function getSubscribedEvents(): array
15			{
16			return [
17			KernelEvents::VIEW => [
18			['setComponentLocations', EventPriorities::PRE_SERIALIZE]
19			]
20			];
21			}
22
23			public static function getSubscribedServices(): array
24			{
25			return [
26			'?' . ComponentLocationRepository::class
27			];
28			}
29
30			public function setComponentLocations(GetResponseForControllerResultEvent $event): void
31			{
32			$page = $event->getControllerResult();
33			$method = $event->getRequest()->getMethod();
34
35			if (!$page instanceof AbstractDynamicPage \|\| Request::METHOD_GET !== $method) {
36			return;
37			}
38
39			/** @var ComponentLocationRepository $repository */
40			$repository = $this->container->get(ComponentLocationRepository::class);
41			$locations = $repository->findByDynamicPage($page);
42			if ($locations) {
			0 ignored issues – show Bug Best Practice introduced 2018-11-09 17:11 UTC by Report Bug Copy Issue Report The expression `$locations` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
43			$page->setComponentLocations($locations);
44			}
45			}
46			}
47

components-web-app / api-components-bundle

Push — develop ( f05cec...11f198 )

DynamicPageSubscriber::setComponentLocations() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like