Silverback\ApiComponentBundle\DataModifier\CollectionModifier::process()

Complexity

Conditions	9
Paths	8

Size

Total Lines	67
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function process($collectionEntity, array $context = array(), ?string $format = null)
    {
        $resourceMetadata = $this->resourceMetadataFactory->create($collectionEntity->getResource());
        $requestUri = null;

        $collectionOperations = $resourceMetadata->getCollectionOperations();
        if ($collectionOperations) {
            $collectionOperations = array_change_key_case($collectionOperations, CASE_LOWER);
            $baseRoute = trim(trim($resourceMetadata->getAttribute('route_prefix', '')), '/');
            $methods = ['post', 'get'];
            foreach ($methods as $method) {
                if (array_key_exists($method, $collectionOperations)) {
                    $path = $baseRoute . $this->operationPathResolver->resolveOperationPath(
                            $resourceMetadata->getShortName(),

It seems like $resourceMetadata->getShortName() can also be of type null; however, parameter $resourceShortName of ApiPlatform\Core\PathResolver\OperationPathResolverInterface::resolveOperationPath() does only seem to accept string, maybe add an additional type check?

                            $collectionOperations[$method],
                            OperationType::COLLECTION,
                            $method);

The call to ApiPlatform\Core\PathResolver\OperationPathResolverInterface::resolveOperationPath() has too many arguments starting with $method.

                    $finalPath = preg_replace('/{_format}$/', $format, $path);
                    $collectionEntity->addCollectionRoute(
                        $method,
                        $finalPath
                    );
                    if ($method === 'get') {
                        $requestUri = $finalPath;
                    }
                }
            }
        }
        $collectionResourceAttributes = $resourceMetadata->getAttributes();

The assignment to $collectionResourceAttributes is dead and can be removed.

        /** @var ContextAwareCollectionDataProviderInterface $dataProvider */
        $dataProvider = $this->container->get(ContextAwareCollectionDataProviderInterface::class);
        $dataProviderContext = [
            'filters' => [
                'pagination' => true,
                '_page' => 1
            ]];
        $request = $apiPagination = null;
        if ($collectionEntity->getPerPage() && ($request = $this->requestStack->getCurrentRequest())) {

The expression $collectionEntity->getPerPage() of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            $apiPagination = $request->attributes->get('_api_pagination');
            $originalPerPage = $apiPagination['itemsPerPage'];
            $apiPagination['itemsPerPage'] = $collectionEntity->getPerPage();
            $request->attributes->set('_api_pagination', $apiPagination);
            $apiPagination['itemsPerPage'] = $originalPerPage;
        }

        /** @var Paginator $collection */
        $collection = $dataProvider->getCollection($collectionEntity->getResource(), Request::METHOD_GET, $dataProviderContext);

        if ($request && $apiPagination) {
            $request->attributes->set('_api_pagination', $apiPagination);
        }

        $forcedContext = [
            'resource_class' => Collection::class,
            'request_uri' => $requestUri,
            'jsonld_has_context' => false,
            'api_sub_level' => null
        ];
        $mergedContext = array_merge($context, $forcedContext);
        $normalizedCollection = $this->itemNormalizer->normalize(
            $collection,
            $format,
            $mergedContext
        );

        $collectionEntity->setCollection($normalizedCollection);

It seems like $normalizedCollection can also be of type boolean and double and integer and string; however, parameter $collection of Silverback\ApiComponentBundle\Entity\Component\Collection\Collection::setCollection() does only seem to accept Traversable|array, maybe add an additional type check?

    }