Silverback\ApiComponentBundle\Validator\Constraints\ComponentLocationValidator

Complexity

Total Complexity

8

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	validateValidComponentInterface()	0	13	4
A	validate()	0	17	4

<?php

namespace Silverback\ApiComponentBundle\Validator\Constraints;

use Doctrine\Common\Collections\ArrayCollection;
use Silverback\ApiComponentBundle\Entity\ValidComponentInterface;
use Silverback\ApiComponentBundle\Validator\ClassNameValidator;
use Silverback\ApiComponentBundle\Entity\Content\ComponentLocation as ComponentLocationEntity;
use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;

class ComponentLocationValidator extends ConstraintValidator
{
    /**
     * @param mixed $entity
     * @param Constraint $constraint
     * @throws \ReflectionException
     */
    public function validate($entity, Constraint $constraint): void
    {
        if (!$entity instanceof ComponentLocationEntity) {
            throw new \InvalidArgumentException(
                sprintf('The ComponentLocationValidator should only be used with %s', ComponentLocationEntity::class)
            );
        }
        $content = $entity->getContent();
        if ($content instanceof ValidComponentInterface) {
            /** @var ArrayCollection|string[] $validComponents */
            $validComponents = $content->getValidComponents();
            $componentIsValid = $this->validateValidComponentInterface($entity, $validComponents);

It seems like $validComponents can also be of type string[]; however, parameter $validComponents of Silverback\ApiComponentBundle\Validator\Constraints\ComponentLocationValidator::validateValidComponentInterface() does only seem to accept Doctrine\Common\Collections\ArrayCollection, maybe add an additional type check?

            if (!$componentIsValid) {
                $this->context->buildViolation($constraint->message)
                    ->atPath('component')
                    ->setParameter('{{ string }}', implode(', ', $validComponents->toArray()))
                    ->addViolation();
            }
        }
    }

    /**
     * @param ComponentLocationEntity $entity
     * @param ArrayCollection $validComponents
     * @return bool
     * @throws \ReflectionException
     */
    private function validateValidComponentInterface(ComponentLocationEntity $entity, ArrayCollection $validComponents)
    {
        $componentIsValid = false;
        if ($validComponents->count()) {
            $component = $entity->getComponent();
            foreach ($validComponents as $validComponent) {
                if (ClassNameValidator::isClassSame($validComponent, $component)) {
                    $componentIsValid = true;
                    break;
                }
            }
        }
        return $componentIsValid;
    }
}