PageDataMetadataProvider::createAll() - Code Metrics - Inspection of "Refactor: PageDataMetadataProvider to provide all..." - components-web-app/api-components-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( a758a4...127461 )

by Daniel

created 2021-12-23 21:15 UTC

PageDataMetadataProvider::createAll() A

↳ Parent: PageDataMetadataProvider

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	5
c	1
b	0
f	0
nc	3
nop	0
dl	0
loc	9
rs	10

<?php

/*
 * This file is part of the Silverback API Components Bundle Project
 *
 * (c) Daniel West <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Silverback\ApiComponentsBundle\Metadata\Provider;

use ApiPlatform\Core\Metadata\Resource\Factory\ResourceNameCollectionFactoryInterface;
use Silverback\ApiComponentsBundle\Entity\Core\PageDataInterface;
use Silverback\ApiComponentsBundle\Metadata\Factory\PageDataMetadataFactoryInterface;
use Silverback\ApiComponentsBundle\Metadata\PageDataMetadata;

/**
 * @author Daniel West <[email protected]>
 */
class PageDataMetadataProvider
{
    private ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory;
    private PageDataMetadataFactoryInterface $pageDataMetadataFactory;

    public function __construct(
        ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory,
        PageDataMetadataFactoryInterface $pageDataMetadataFactory
    ) {
        $this->resourceNameCollectionFactory = $resourceNameCollectionFactory;
        $this->pageDataMetadataFactory = $pageDataMetadataFactory;
    }

    /**
     * @return PageDataMetadata[]|iterable
     */
    public function createAll(): iterable
    {
        foreach ($this->resourceNameCollectionFactory->create() as $pageDataResourceClass) {
            $reflectionClass = new \ReflectionClass($pageDataResourceClass);
            if (!$reflectionClass->implementsInterface(PageDataInterface::class)) {
                continue;
            }

            yield $this->pageDataMetadataFactory->create($pageDataResourceClass);

        }
    }
}


1			<?php
2
3			/*
4			* This file is part of the Silverback API Components Bundle Project
5			*
6			* (c) Daniel West <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace Silverback\ApiComponentsBundle\Metadata\Provider;
15
16			use ApiPlatform\Core\Metadata\Resource\Factory\ResourceNameCollectionFactoryInterface;
17			use Silverback\ApiComponentsBundle\Entity\Core\PageDataInterface;
18			use Silverback\ApiComponentsBundle\Metadata\Factory\PageDataMetadataFactoryInterface;
19			use Silverback\ApiComponentsBundle\Metadata\PageDataMetadata;
20
21			/**
22			* @author Daniel West <[email protected]>
23			*/
24			class PageDataMetadataProvider
25			{
26			private ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory;
27			private PageDataMetadataFactoryInterface $pageDataMetadataFactory;
28
29			public function __construct(
30			ResourceNameCollectionFactoryInterface $resourceNameCollectionFactory,
31			PageDataMetadataFactoryInterface $pageDataMetadataFactory
32			) {
33			$this->resourceNameCollectionFactory = $resourceNameCollectionFactory;
34			$this->pageDataMetadataFactory = $pageDataMetadataFactory;
35			}
36
37			/**
38			* @return PageDataMetadata[]\|iterable
39			*/
40			public function createAll(): iterable
41			{
42			foreach ($this->resourceNameCollectionFactory->create() as $pageDataResourceClass) {
43			$reflectionClass = new \ReflectionClass($pageDataResourceClass);
44			if (!$reflectionClass->implementsInterface(PageDataInterface::class)) {
45			continue;
46			}
47
48			yield $this->pageDataMetadataFactory->create($pageDataResourceClass);
			0 ignored issues – show Bug Best Practice introduced 2021-12-23 21:20 UTC by Report Bug Copy Issue Report The expression `yield $this->pageDataMet...$pageDataResourceClass)` returns the type `Generator` which is incompatible with the documented return type `Silverback\ApiComponents...DataMetadata[]\|iterable`. Loading history...
49			}
50			}
51			}
52

components-web-app / api-components-bundle

Push — master ( a758a4...127461 )

PageDataMetadataProvider::createAll() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like