FormViewFactory::create() - Code Metrics - Inspection of "Issue 63: Form review and refactor" - components-web-app/api-components-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#66)

by Daniel

created 2020-05-06 17:49 UTC

FormViewFactory::create() A

↳ Parent: FormViewFactory

Complexity

Conditions	3
Paths	2

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
eloc	4
nc	2
nop	1
dl	0
loc	9
ccs	0
cts	5
cp	0
crap	12
rs	10
c	0
b	0
f	0

<?php

/*
 * This file is part of the Silverback API Components Bundle Project
 *
 * (c) Daniel West <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Silverback\ApiComponentsBundle\Factory\Form;

use ApiPlatform\Core\Api\IriConverterInterface;
use Silverback\ApiComponentsBundle\Dto\FormView;
use Silverback\ApiComponentsBundle\Entity\Component\Form;
use Symfony\Component\Form\FormFactoryInterface;
use Symfony\Component\HttpFoundation\UrlHelper;

/**
 * @author Daniel West <[email protected]>
 */
class FormViewFactory
{
    private FormFactoryInterface $formFactory;
    private IriConverterInterface $iriConverter;
    private UrlHelper $urlHelper;

    public function __construct(FormFactoryInterface $formFactory, IriConverterInterface $iriConverter, UrlHelper $urlHelper)
    {
        $this->formFactory = $formFactory;
        $this->iriConverter = $iriConverter;
        $this->urlHelper = $urlHelper;
    }

    public function create(Form $form): FormView
    {
        $builder = $this->formFactory->createBuilder($form->formType);

        if (!($currentAction = $builder->getAction()) || '' === $currentAction) {
            $builder->setAction($this->getFormAction($form));
        }

        return new FormView($builder->getForm());
    }

    private function getFormAction(Form $form): string
    {
        return $this->urlHelper->getAbsoluteUrl($this->iriConverter->getIriFromItem($form) . '/submit');
    }
}


1			<?php
2
3			/*
4			* This file is part of the Silverback API Components Bundle Project
5			*
6			* (c) Daniel West <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace Silverback\ApiComponentsBundle\Factory\Form;
15
16			use ApiPlatform\Core\Api\IriConverterInterface;
17			use Silverback\ApiComponentsBundle\Dto\FormView;
18			use Silverback\ApiComponentsBundle\Entity\Component\Form;
19			use Symfony\Component\Form\FormFactoryInterface;
20			use Symfony\Component\HttpFoundation\UrlHelper;
21
22			/**
23			* @author Daniel West <[email protected]>
24			*/
25			class FormViewFactory
26			{
27			private FormFactoryInterface $formFactory;
28			private IriConverterInterface $iriConverter;
29			private UrlHelper $urlHelper;
30
31			public function __construct(FormFactoryInterface $formFactory, IriConverterInterface $iriConverter, UrlHelper $urlHelper)
32			{
33			$this->formFactory = $formFactory;
34			$this->iriConverter = $iriConverter;
35			$this->urlHelper = $urlHelper;
36			}
37
38			public function create(Form $form): FormView
39			{
40			$builder = $this->formFactory->createBuilder($form->formType);
41
42			if (!($currentAction = $builder->getAction()) \|\| '' === $currentAction) {
43			$builder->setAction($this->getFormAction($form));
44			}
45
46			return new FormView($builder->getForm());
47			}
48
49			private function getFormAction(Form $form): string
50			{
51			return $this->urlHelper->getAbsoluteUrl($this->iriConverter->getIriFromItem($form) . '/submit');
52			}
53			}
54

components-web-app / api-components-bundle

Pull Request — master (#66)

FormViewFactory::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like