Silverback\ApiComponentsBundle\Metadata\Factory\PageDataMetadataFactory::create()

Complexity

Conditions	5
Paths	5

Size

Total Lines	41
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function create(string $resourceClass): PageDataMetadata
    {
        // needs to be a class
        if (!class_exists($resourceClass)) {
            throw new PageDataNotFoundException(sprintf('`%s` was not found', $resourceClass));
        }

        // Check it is page data
        $reflection = new \ReflectionClass($resourceClass);
        if (!$reflection->implementsInterface(PageDataInterface::class)) {
            throw new PageDataNotFoundException(sprintf('Resource class `%s` is not a valid page data resource', $resourceClass));
        }

        // FInd the doctrine manager
        $manager = $this->registry->getManagerForClass($resourceClass);
        if (!$manager) {
            throw new PageDataNotFoundException(sprintf('Cannot find manager for page data resource `%s`', $resourceClass));
        }
        $classMetadata = $manager->getClassMetadata($resourceClass);

        // Get abstract prop names to exclude
        $abstractReflection = new \ReflectionClass(AbstractPageData::class);
        $reflProps = $abstractReflection->getProperties();
        $abstractProps = array_map(static function (\ReflectionProperty $prop) {
            return $prop->name;
        }, $reflProps);

        // Get all fields with association
        $assocFields = array_filter($classMetadata->getAssociationNames(), static function ($name) use ($abstractProps) {
            return !\in_array($name, $abstractProps, true);
        });

        // Create metadata with relations
        $metadata = new PageDataMetadata($resourceClass);
        foreach ($assocFields as $assocField) {
            $targetClass = $classMetadata->getAssociationTargetClass($assocField);
            $relationName = $this->resourceMetadataFactory->create($targetClass)->getShortName();

It seems like $targetClass can also be of type null; however, parameter $resourceClass of ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface::create() does only seem to accept string, maybe add an additional type check?

            $metadata->addProperty(new PageDataPropertyMetadata($assocField, $relationName));

It seems like $relationName can also be of type null; however, parameter $componentClass of Silverback\ApiComponentsBundle\Metadata\PageDataPropertyMetadata::__construct() does only seem to accept string, maybe add an additional type check?

        }

        return $metadata;
    }