Silverback\ApiComponentBundle\Action\AbstractAction

Complexity

Total Complexity

5

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getResponse()	0	15	2
A	getFormat()	0	3	1
A	__construct()	0	7	2

<?php

/*
 * This file is part of the Silverback API Component Bundle Project
 *
 * (c) Daniel West <daniel@silverback.is>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Silverback\ApiComponentBundle\Action;

use Silverback\ApiComponentBundle\Exception\InvalidParameterException;
use Silverback\ApiComponentBundle\Serializer\RequestFormatResolver;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Serializer\Encoder\DecoderInterface;
use Symfony\Component\Serializer\SerializerInterface;

/**
 * @author Daniel West <daniel@silverback.is>
 */
class AbstractAction
{
    protected DecoderInterface $serializer;
    protected RequestFormatResolver $requestFormatResolver;

    public function __construct(SerializerInterface $serializer, RequestFormatResolver $requestFormatResolver)
    {
        if (!$serializer instanceof DecoderInterface) {
            throw new InvalidParameterException(sprintf('The serializer injected into %s should implement %s', __CLASS__, DecoderInterface::class));
        }
        $this->serializer = $serializer;
        $this->requestFormatResolver = $requestFormatResolver;
    }

    protected function getFormat(Request $request): string
    {
        return $this->requestFormatResolver->getFormatFromRequest($request);
    }

    protected function getResponse(Request $request, $response = null, ?int $status = null): Response
    {
        $headers = [
            'Content-Type' => sprintf('%s; charset=utf-8', $format = $this->getFormat($request)),
            'Vary' => 'Accept',
            'X-Content-Type-Options' => 'nosniff',
            'X-Frame-Options' => 'deny',
        ];
        if (!\is_string($response)) {
            $response = $this->serializer->serialize($response, $format, []);

The method serialize() does not exist on Symfony\Component\Serializer\Encoder\DecoderInterface. It seems like you code against a sub-type of Symfony\Component\Serializer\Encoder\DecoderInterface such as Symfony\Component\Serializer\Serializer.

        }
        new Response(
            $response,
            $status ?? Response::HTTP_OK,
            $headers
        );

In this branch, the function will implicitly return null which is incompatible with the type-hinted return Symfony\Component\HttpFoundation\Response. Consider adding a return statement or allowing null as return value.

    }
}