ChangePasswordHandler::success() - Code Metrics - Inspection of "Initial updates to build in authentication" - components-web-app/api-components-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( 28e0cd...307ddb )

by Daniel

created 2019-02-15 10:03 UTC

ChangePasswordHandler::success() A

↳ Parent: ChangePasswordHandler

Complexity

Conditions	3
Paths	2

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	9
dl	0
loc	14
rs	9.9666
c	0
b	0
f	0
cc	3
nc	2
nop	3

<?php

namespace Silverback\ApiComponentBundle\Form\Handler;

use Silverback\ApiComponentBundle\Entity\User\User;
use App\Exception\NotSupportedException;
filter:
    dependency_paths: ["lib/*"]
use App\Security\PasswordManager;
filter:
    dependency_paths: ["lib/*"]
use Silverback\ApiComponentBundle\Entity\Component\Form\Form;
use Symfony\Component\HttpFoundation\Request;

class ChangePasswordHandler implements FormHandlerInterface
{
    private $passwordManager;

    public function __construct(
        PasswordManager $passwordManager
    ) {
        $this->passwordManager = $passwordManager;
    }

    /**
     * @param Form $form
     * @param User $user
     * @param Request $request
     * @throws NotSupportedException
     */
    public function success(Form $form, $user, Request $request): void
    {
        if (!$user instanceof User) {

            throw new NotSupportedException(
                sprintf(
                    '`%s` only supports forms that submit the `%s` entity. Received `%s`',
                    self::class,
                    User::class,
                    \is_object($user) ? \get_class($user) : $user
                )
            );
        }
        $this->passwordManager->persistPlainPassword($user);
        $user->eraseCredentials();
    }
}


1			<?php
2
3			namespace Silverback\ApiComponentBundle\Form\Handler;
4
5			use Silverback\ApiComponentBundle\Entity\User\User;
6			use App\Exception\NotSupportedException;
			0 ignored issues – show Bug introduced 2019-02-15 10:08 UTC by Report Bug Copy Issue Report The type `App\Exception\NotSupportedException` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
7			use App\Security\PasswordManager;
			0 ignored issues – show Bug introduced 2019-02-15 10:08 UTC by Report Bug Copy Issue Report The type `App\Security\PasswordManager` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8			use Silverback\ApiComponentBundle\Entity\Component\Form\Form;
9			use Symfony\Component\HttpFoundation\Request;
10
11			class ChangePasswordHandler implements FormHandlerInterface
12			{
13			private $passwordManager;
14
15			public function __construct(
16			PasswordManager $passwordManager
17			) {
18			$this->passwordManager = $passwordManager;
19			}
20
21			/**
22			* @param Form $form
23			* @param User $user
24			* @param Request $request
25			* @throws NotSupportedException
26			*/
27			public function success(Form $form, $user, Request $request): void
28			{
29			if (!$user instanceof User) {
			0 ignored issues – show introduced 2019-02-15 10:08 UTC by Report Bug Copy Issue Report `$user` is always a sub-type of `Silverback\ApiComponentBundle\Entity\User\User`. Loading history...
30			throw new NotSupportedException(
31			sprintf(
32			'`%s` only supports forms that submit the `%s` entity. Received `%s`',
33			self::class,
34			User::class,
35			\is_object($user) ? \get_class($user) : $user
36			)
37			);
38			}
39			$this->passwordManager->persistPlainPassword($user);
40			$user->eraseCredentials();
41			}
42			}
43

components-web-app / api-components-bundle

Push — develop ( 28e0cd...307ddb )

ChangePasswordHandler::success() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like