Sender::performCall() - Code Metrics - Inspection of "client skeleton, still not working" - comodojo/rpcclient - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2b2467...86fe2f )

by Marco

created 2016-03-08 07:58 UTC

Sender::performCall() B

↳ Parent: Sender

Complexity

Conditions	4
Paths	25

Size

Total Lines	43
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	43
rs	8.5806
cc	4
eloc	20
nc	25
nop	3

<?php namespace Comodojo\RpcClient\Transport;

use \Psr\Log\LoggerInterface;
use \Comodojo\Httprequest\Httprequest;
use \Crypt_AES;
use \Comodojo\Exception\HttpException;
use \Comodojo\Exception\RpcException;
use \Exception;

class Sender {

    private $transport = null;

    private $logger = null;

    private $aes = null;

    public function __construct($server, LoggerInterface $logger) {

        $this->logger = $logger;

        try {

            $this->transport = new Httprequest($server);

            $this->transport->setHttpMethod("POST");

        } catch (HttpException $he) {

            throw $he;

        } catch (Exception $e) {

            throw $e;

        }

    }

    public function transport() {

        return $this->transport;

    }

    public function logger() {

        return $this->logger();

    }

    /**
     * Send pre-econded request to server
     *
     * @param   string   $data
     * @param   string   $content_type
     *
     * @return  string
     *
     * @throws \Comodojo\Exception\RpcException
     * @throws \Comodojo\Exception\HttpException
     */
    public function performCall($data, $content_type, $encrypt=false) {

        try {

            $this->logger->notice("Sending data to ".$this->transport);

            $this->logger->debug("Original request data dump ", $data);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            $data = $this->can($data, $encrypt);

            $this->logger->debug("Real request data dump ", $data);

            $response = $this->transport->setContentType($content_type)->send($data);

            $this->logger->debug("Real response data dump ", $response);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            $return = $this->uncan($response, $encrypt);

            $this->logger->debug("Decoded response data dump ", $return);

        } catch (HttpException $he) {

            $this->logger->error("HTTP Transport error: ".$he->getMessage());

            throw $he;

        } catch (RpcException $re) {

            $this->logger->error("RPC Client error: ".$re->getMessage());

            throw $re;

        } catch (Exception $e) {

            $this->logger->critical("Generic Client error: ".$e->getMessage());

            throw $e;

        }

        return $return;

    }

    private function can($data, $key) {

        if ( !empty($key) && is_string($key) ) {

            $this->aes = new Crypt_AES();

            $this->aes->setKey($key);

            $return = 'comodojo_encrypted_request-'.base64_encode( $this->aes->encrypt($data) );

        } else {

            $return = $data;

        }

        return $return;

    }

    private function uncan($data, $key) {

        if ( !empty($key) && is_string($key) ) {

            if ( self::checkEncryptedResponseConsistency($data) === false ) throw new RpcException("Inconsistent encrypted response received");

            $return = $this->aes->decrypt(base64_decode(substr($response, 28)));


        } else {

            $return = $data;

        }

        return $return;

    }

    /**
     * Check if an encrypted envelop is consisent or not
     *
     * @param   string    $data
     *
     * @return  bool
     */
    private static function checkEncryptedResponseConsistency($data) {

        return substr($data, 0, 27) == 'comodojo_encrypted_response' ? true : false;

    }

}


1			<?php namespace Comodojo\RpcClient\Transport;
2
3			use \Psr\Log\LoggerInterface;
4			use \Comodojo\Httprequest\Httprequest;
5			use \Crypt_AES;
6			use \Comodojo\Exception\HttpException;
7			use \Comodojo\Exception\RpcException;
8			use \Exception;
9
10			class Sender {
11
12			private $transport = null;
13
14			private $logger = null;
15
16			private $aes = null;
17
18			public function __construct($server, LoggerInterface $logger) {
19
20			$this->logger = $logger;
21
22			try {
23
24			$this->transport = new Httprequest($server);
25
26			$this->transport->setHttpMethod("POST");
27
28			} catch (HttpException $he) {
29
30			throw $he;
31
32			} catch (Exception $e) {
33
34			throw $e;
35
36			}
37
38			}
39
40			public function transport() {
41
42			return $this->transport;
43
44			}
45
46			public function logger() {
47
48			return $this->logger();
49
50			}
51
52			/**
53			* Send pre-econded request to server
54			*
55			* @param string $data
56			* @param string $content_type
57			*
58			* @return string
59			*
60			* @throws \Comodojo\Exception\RpcException
61			* @throws \Comodojo\Exception\HttpException
62			*/
63			public function performCall($data, $content_type, $encrypt=false) {
64
65			try {
66
67			$this->logger->notice("Sending data to ".$this->transport);
68
69			$this->logger->debug("Original request data dump ", $data);
			0 ignored issues – show Documentation introduced 2016-03-08 08:10 UTC by Report Bug Copy Issue Report `$data` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
70
71			$data = $this->can($data, $encrypt);
72
73			$this->logger->debug("Real request data dump ", $data);
74
75			$response = $this->transport->setContentType($content_type)->send($data);
76
77			$this->logger->debug("Real response data dump ", $response);
			0 ignored issues – show Documentation introduced 2016-03-08 08:10 UTC by Report Bug Copy Issue Report `$response` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
78
79			$return = $this->uncan($response, $encrypt);
80
81			$this->logger->debug("Decoded response data dump ", $return);
82
83			} catch (HttpException $he) {
84
85			$this->logger->error("HTTP Transport error: ".$he->getMessage());
86
87			throw $he;
88
89			} catch (RpcException $re) {
90
91			$this->logger->error("RPC Client error: ".$re->getMessage());
92
93			throw $re;
94
95			} catch (Exception $e) {
96
97			$this->logger->critical("Generic Client error: ".$e->getMessage());
98
99			throw $e;
100
101			}
102
103			return $return;
104
105			}
106
107			private function can($data, $key) {
108
109			if ( !empty($key) && is_string($key) ) {
110
111			$this->aes = new Crypt_AES();
112
113			$this->aes->setKey($key);
114
115			$return = 'comodojo_encrypted_request-'.base64_encode( $this->aes->encrypt($data) );
116
117			} else {
118
119			$return = $data;
120
121			}
122
123			return $return;
124
125			}
126
127			private function uncan($data, $key) {
128
129			if ( !empty($key) && is_string($key) ) {
130
131			if ( self::checkEncryptedResponseConsistency($data) === false ) throw new RpcException("Inconsistent encrypted response received");
132
133			$return = $this->aes->decrypt(base64_decode(substr($response, 28)));
			0 ignored issues – show Bug introduced 2015-12-18 10:16 UTC by Report Bug Copy Issue Report The variable `$response` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
134
135			} else {
136
137			$return = $data;
138
139			}
140
141			return $return;
142
143			}
144
145			/**
146			* Check if an encrypted envelop is consisent or not
147			*
148			* @param string $data
149			*
150			* @return bool
151			*/
152			private static function checkEncryptedResponseConsistency($data) {
153
154			return substr($data, 0, 27) == 'comodojo_encrypted_response' ? true : false;
155
156			}
157
158			}
159

comodojo / rpcclient

Push — master ( 2b2467...86fe2f )

Sender::performCall() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like