RpcClient::send() - Code Metrics - Inspection of "client skeleton, still not working" - comodojo/rpcclient - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2b2467...86fe2f )

by Marco

created 2016-03-08 07:58 UTC

RpcClient::send() C

↳ Parent: RpcClient

Complexity

Conditions	8
Paths	29

Size

Total Lines	51
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	1	Features	1

Metric	Value
c	4
b	1
f	1
dl	0
loc	51
rs	6.5978
cc	8
eloc	23
nc	29
nop	0

How to fix Long Method

<?php namespace Comodojo\RpcClient;

use \Comodojo\RpcClient\Processor\JsonProcessor;
use \Comodojo\RpcClient\Processor\XmlProcessor;
use \Comodojo\RpcClient\Transport\Sender;
use \Comodojo\RpcClient\Components\Protocol;
use \Comodojo\RpcClient\Components\Encryption;
use \Comodojo\RpcClient\Components\Encoding;
use \Comodojo\RpcClient\Components\Request;
use \Comodojo\RpcClient\Utils\NullLogger;
use \Comodojo\Exception\RpcException;
use \Comodojo\Exception\HttpException;
use \Comodojo\Exception\XmlrpcException;
use \Exception;

/**
 * Comodojo RPC client. It's able to talk in XML and JSON (2.0).
 *
 * It optionally supports a not standard encrypted transport
 *
 * @package     Comodojo Spare Parts
 * @author      Marco Giovinazzi <[email protected]>
 * @license     MIT
 *
 * LICENSE:
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

class RpcClient {

    use Protocol;
    use Encryption;
    use Encoding;
    use Request;

    const JSONRPC = "JSON";

    const XMLRPC = "XML";

    // internals

    private $sender;

    private $logger;

    /**
     * Class constructor
     *
     * @param   string  $server  Remote RPC server address
     *
     * @throws \Comodojo\Exception\HttpException
     */
    public function __construct($server, Logger $logger = null) {

        if ( empty($server) ) throw new Exception("Invalid RPC server address");

        $this->logger = is_null($logger) ? new NullLogger() : $logger;

        try {

            $this->sender = new Sender($server, $this->logger);

        } catch (HttpException $he) {

            throw $he;

        }

    }

    public function logger() {

        return $this->logger;

    }

    public function sender() {

        return $this->sender;

    }

    /**
     * Get the transport layer
     *
     * This method will return the Httprequest object in order to customize transport
     * options before sending request(s)
     *
     * @return  \Comodojo\Httprequest\Httprequest
     */
    final public function getTransport() {

        return $this->sender->transport();

    }

    /**
     * Send request(s) to server
     *
     * @return mixed
     *
     * @throws \Comodojo\Exception\RpcException
     * @throws \Comodojo\Exception\HttpException
     * @throws \Comodojo\Exception\XmlrpcException
     * @throws \Exception
     */
    public function send() {

        $requests = $this->getRequest();

        if ( empty($requests) ) throw new Exception("No request to send");

        if ( $this->getProtocol() == self::XMLRPC ) {

            $processor = new XmlProcessor($this->getEncoding(), $this->logger());

            $content_type = "text/xml";

        } else {

            $processor = new JsonProcessor($this->getEncoding(), $this->logger());

            $content_type = "application/json";

        }

        try {

            $payload = $processor->encode($requests);

            $response = $this->sender()->setContentType($content_type)->performCall($payload, $this->getEncryption());


            $result = $processor->decode($response);

        } catch (HttpException $he) {

            throw $he;

        } catch (RpcException $re) {

            throw $re;

        } catch (XmlrpcException $xe) {

            throw $xe;

        } catch (Exception $e) {

            throw $e;

        }

        if ( $this->autoclean ) $this->clean();

        return $result;

    }

}


1			<?php namespace Comodojo\RpcClient;
2
3			use \Comodojo\RpcClient\Processor\JsonProcessor;
4			use \Comodojo\RpcClient\Processor\XmlProcessor;
5			use \Comodojo\RpcClient\Transport\Sender;
6			use \Comodojo\RpcClient\Components\Protocol;
7			use \Comodojo\RpcClient\Components\Encryption;
8			use \Comodojo\RpcClient\Components\Encoding;
9			use \Comodojo\RpcClient\Components\Request;
10			use \Comodojo\RpcClient\Utils\NullLogger;
11			use \Comodojo\Exception\RpcException;
12			use \Comodojo\Exception\HttpException;
13			use \Comodojo\Exception\XmlrpcException;
14			use \Exception;
15
16			/**
17			* Comodojo RPC client. It's able to talk in XML and JSON (2.0).
18			*
19			* It optionally supports a not standard encrypted transport
20			*
21			* @package Comodojo Spare Parts
22			* @author Marco Giovinazzi <[email protected]>
23			* @license MIT
24			*
25			* LICENSE:
26			*
27			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
28			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
29			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
30			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
31			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
32			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
33			* THE SOFTWARE.
34			*/
35
36			class RpcClient {
37
38			use Protocol;
39			use Encryption;
40			use Encoding;
41			use Request;
42
43			const JSONRPC = "JSON";
44
45			const XMLRPC = "XML";
46
47			// internals
48
49			private $sender;
50
51			private $logger;
52
53			/**
54			* Class constructor
55			*
56			* @param string $server Remote RPC server address
57			*
58			* @throws \Comodojo\Exception\HttpException
59			*/
60			public function __construct($server, Logger $logger = null) {
61
62			if ( empty($server) ) throw new Exception("Invalid RPC server address");
63
64			$this->logger = is_null($logger) ? new NullLogger() : $logger;
65
66			try {
67
68			$this->sender = new Sender($server, $this->logger);
69
70			} catch (HttpException $he) {
71
72			throw $he;
73
74			}
75
76			}
77
78			public function logger() {
79
80			return $this->logger;
81
82			}
83
84			public function sender() {
85
86			return $this->sender;
87
88			}
89
90			/**
91			* Get the transport layer
92			*
93			* This method will return the Httprequest object in order to customize transport
94			* options before sending request(s)
95			*
96			* @return \Comodojo\Httprequest\Httprequest
97			*/
98			final public function getTransport() {
99
100			return $this->sender->transport();
101
102			}
103
104			/**
105			* Send request(s) to server
106			*
107			* @return mixed
108			*
109			* @throws \Comodojo\Exception\RpcException
110			* @throws \Comodojo\Exception\HttpException
111			* @throws \Comodojo\Exception\XmlrpcException
112			* @throws \Exception
113			*/
114			public function send() {
115
116			$requests = $this->getRequest();
117
118			if ( empty($requests) ) throw new Exception("No request to send");
119
120			if ( $this->getProtocol() == self::XMLRPC ) {
121
122			$processor = new XmlProcessor($this->getEncoding(), $this->logger());
123
124			$content_type = "text/xml";
125
126			} else {
127
128			$processor = new JsonProcessor($this->getEncoding(), $this->logger());
129
130			$content_type = "application/json";
131
132			}
133
134			try {
135
136			$payload = $processor->encode($requests);
137
138			$response = $this->sender()->setContentType($content_type)->performCall($payload, $this->getEncryption());
			0 ignored issues – show Bug introduced 2016-03-08 08:10 UTC by Report Bug Copy Issue Report The method `setContentType()` does not seem to exist on `object<Comodojo\RpcClient\Transport\Sender>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
139
140			$result = $processor->decode($response);
141
142			} catch (HttpException $he) {
143
144			throw $he;
145
146			} catch (RpcException $re) {
147
148			throw $re;
149
150			} catch (XmlrpcException $xe) {
151
152			throw $xe;
153
154			} catch (Exception $e) {
155
156			throw $e;
157
158			}
159
160			if ( $this->autoclean ) $this->clean();
161
162			return $result;
163
164			}
165
166			}
167

comodojo / rpcclient

Push — master ( 2b2467...86fe2f )

RpcClient::send() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like