TaskStatusEvent::getTask() - Code Metrics - Inspection of "tasks section almost complete" - comodojo/extender.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( 21f326...dd3689 )

by Marco

created 2016-08-23 13:28 UTC

TaskStatusEvent::getTask() A

↳ Parent: TaskStatusEvent

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	5
rs	9.4285
cc	1
eloc	2
nc	1
nop	0

<?php namespace Comodojo\Extender\Events;

use \Comodojo\Extender\Tasks\TaskInterface;

/**
 * @package     Comodojo Dispatcher
 * @author      Marco Giovinazzi <[email protected]>
 * @author      Marco Castiello <[email protected]>
 * @license     GPL-3.0+
 *
 * LICENSE:
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

class TaskStatusEvent extends AbstractEvent {

    private $status;

    private $task;

    public function __construct($status, TaskInterface $task) {

        $name = $task->name;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        parent::__construct("extender.task.$name.$status");

        $this->status = $status;

        $this->task = $task;

    }

    public function getStatus() {

        return $this->status;

    }

    public function getTask() {

        return $this->task;

    }

}


1			<?php namespace Comodojo\Extender\Events;
2
3			use \Comodojo\Extender\Tasks\TaskInterface;
4
5			/**
6			* @package Comodojo Dispatcher
7			* @author Marco Giovinazzi <[email protected]>
8			* @author Marco Castiello <[email protected]>
9			* @license GPL-3.0+
10			*
11			* LICENSE:
12			*
13			* This program is free software: you can redistribute it and/or modify
14			* it under the terms of the GNU Affero General Public License as
15			* published by the Free Software Foundation, either version 3 of the
16			* License, or (at your option) any later version.
17			*
18			* This program is distributed in the hope that it will be useful,
19			* but WITHOUT ANY WARRANTY; without even the implied warranty of
20			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21			* GNU Affero General Public License for more details.
22			*
23			* You should have received a copy of the GNU Affero General Public License
24			* along with this program. If not, see <http://www.gnu.org/licenses/>.
25			*/
26
27			class TaskStatusEvent extends AbstractEvent {
28
29			private $status;
30
31			private $task;
32
33			public function __construct($status, TaskInterface $task) {
34
35			$name = $task->name;
			0 ignored issues – show Bug introduced 2016-08-23 13:46 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `Comodojo\Extender\Tasks\TaskInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
36
37			parent::__construct("extender.task.$name.$status");
38
39			$this->status = $status;
40
41			$this->task = $task;
42
43			}
44
45			public function getStatus() {
46
47			return $this->status;
48
49			}
50
51			public function getTask() {
52
53			return $this->task;
54
55			}
56
57			}
58

comodojo / extender.framework

Push — 2.0 ( 21f326...dd3689 )

TaskStatusEvent::getTask() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like