Extender::getCompletedProcesses() - Code Metrics - Inspection of "fix php < 5.5 timezone override" - comodojo/extender.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 8a4ca9...acd23c )

by Marco
created 2015-12-13 10:27 UTC
Extender::getCompletedProcesses() A

↳ Parent: Extender
Complexity

Conditions	1
Paths	1
Size

Total Lines	5
Code Lines	2
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	2
CRAP Score	1
Importance

Changes	2
Bugs	0	Features	0
Metric	Value
c	2
b	0
f	0
dl	0
loc	5
ccs	2
cts	2
cp	1
rs	9.4286
cc	1
eloc	2
nc	1
nop	0
crap	1
<?php namespace Comodojo\Extender;

use \Console_Color2;
use \Console_Table;
use \Comodojo\Extender\Scheduler\Scheduler;
use \Comodojo\Extender\Scheduler\Schedule;
use \Comodojo\Extender\Runner\JobsRunner;
use \Comodojo\Extender\Runner\JobsResult;
use \Comodojo\Extender\Job\Job;
use \Comodojo\Extender\Log\ExtenderLogger;
use \Comodojo\Extender\Events;
use \Comodojo\Extender\TasksTable;
use \Exception;

/**
 * Extender main class
 *
 * @package     Comodojo extender
 * @author      Marco Giovinazzi <[email protected]>
 * @license     GPL-3.0+
 *
 * LICENSE:
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

class Extender {

    // configurable things

    /**
     * Max result lenght (in bytes) retrieved from parent in miltithread mode
     *
     * @var int
     */
    private $max_result_bytes_in_multithread = null;

    /**
     * Maximum time (in seconds) the parent will wait for child tasks to be completed (in miltithread mode)
     *
     * @var int
     */
    private $max_childs_runtime = null;

    /**
     * Multithread mode
     *
     * @var bool
     */
    private $multithread_mode = false;

    /**
     * Verbose mode, if requested via command line arg -v
     *
     * @var bool
     */
    private $verbose_mode = false;

    /**
     * Debug mode, if requested via command line arg -V
     *
     * @var bool
     */
    private $debug_mode = false;

    /**
     * Summary mode, if requested via command line arg -s
     *
     * @var bool
     */
    private $summary_mode = false;

    /**
     * Daemon mode, if requested via command line arg -d
     *
     * @var bool
     */
    private $daemon_mode = false;

    /**
     * Timestamp, relative, of current extend() cycle
     *
     * @var float
     */
    private $timestamp = null;

    /**
     * Timestamp, absolute, sinnce extender was initiated
     *
     * @var float
     */
    private $timestamp_absolute = null;

    /**
     * PID of the parent extender process
     *
     * @var int
     */
    private $parent_pid = null;

    /**
     * Set exender in paused mode (no job will be processed)
     *
     * @var bool
     */
    private $paused = false;

    // Helper classes

    /**
     * Events manager instance
     *
     * @var \Comodojo\Extender\Events
     */
    private $events = null;

    /**
     * Console_Color2 instance
     *
     * @var \Console_Color2
     */
    private $color = null;

    /**
     * Logger instance
     *
     * @var \Monolog\Logger
     */
    private $logger = null;

    /**
     * JobsRunner instance
     *
     * @var \Comodojo\Extender\Runner\JobsRunner
     */
    private $runner = null;

    /**
     * TasksTable instance
     *
     * @var \Comodojo\Extender\TasksTable
     */
    private $tasks = null;

    // checks and locks are static!

    // local archives

    /**
     * Failed processes, refreshed each cycle (in daemon mode)
     *
     * @var int
     */
    private $failed_processes = 0;

    /**
     * Completed processes
     *
     * @var int
     */
    private $completed_processes = 0;

    /**
     * Constructor method
     *
     * Prepare extender environment, do checks and fire extender.ready event
     */
    final public function __construct() {

        // check if extender is running from cli

        if ( Checks::cli() === false ) {

            echo "Extender runs only in php-cli, exiting";

            self::end(1);

        }

        // setup default timezone (in daemon mode, timezone warning may break extender)

        $default_timezone = ini_get('date.timezone');

        if ( empty($default_timezone) ) {

            date_default_timezone_set(defined('EXTENDER_TIMEZONE') ? EXTENDER_TIMEZONE : 'Europe/Rome');

        }

        $this->timestamp_absolute = microtime(true);

        $this->color = new Console_Color2();

        // get command line options (vsdh)

        list($this->verbose_mode, $this->debug_mode, $this->summary_mode, $this->daemon_mode, $help_mode) = self::getCommandlineOptions();

        if ( $help_mode ) {

            self::showHelp($this->color);

            self::end(0);

        }

        $this->logger = ExtenderLogger::create($this->verbose_mode, $this->debug_mode);

        // do checks

        $check_constants = Checks::constants();

        if ( $check_constants !== true ) {

            $this->logger->critical($check_constants);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

            self::end(1);

        }

        if ( Checks::signals() === false AND $this->daemon_mode ) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);

            $this->logger->critical("Extender cannot run in daemon mode without PHP Process Control Extensions");

            self::end(1);

        }

        if ( Checks::database() === false ) {

            $this->logger->critical("Extender database not available, exiting");

            self::end(1);

        }

        $this->tasks = TasksTable::load($this->logger);

        $this->events = Events::load($this->logger);

        // setup extender parameters

        $this->max_result_bytes_in_multithread = defined('EXTENDER_MAX_RESULT_BYTES') ? filter_var(EXTENDER_MAX_RESULT_BYTES, FILTER_VALIDATE_INT) : 2048;

        $this->max_childs_runtime = defined('EXTENDER_MAX_CHILDS_RUNTIME') ? filter_var(EXTENDER_MAX_CHILDS_RUNTIME, FILTER_VALIDATE_INT) : 600;

        $this->multithread_mode = defined('EXTENDER_MULTITHREAD_ENABLED') ? filter_var(EXTENDER_MULTITHREAD_ENABLED, FILTER_VALIDATE_BOOLEAN) : false;

        // if in daemon mode, remember parent pid, setup lock and register signal handlers

        if ( $this->daemon_mode ) {

            $this->parent_pid = posix_getpid();

            Lock::register($this->parent_pid);

            $this->adjustNiceness();

            if ( Checks::signals() ) $this->registerSignals();

        }

        // init the runner

        $this->runner = new JobsRunner($this->logger, $this->getMultithreadMode(), $this->max_result_bytes_in_multithread, $this->max_childs_runtime);

        $this->logger->notice("Extender ready");

        // store initial status and queue information

        Status::dump($this->timestamp_absolute, $this->parent_pid, $this->completed_processes, $this->failed_processes, $this->paused);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        Queue::dump(0, 0);

        // we are ready to go!

    }

    /**
     * Set max result length (in bytes) that should be read from child tasks
     *
     * @param   int     $bytes  Maximum length (bytes)
     *
     * @return  Extender          $this
     */
    final public function setMaxResultLength($bytes) {

        $this->max_result_bytes_in_multithread = filter_var($bytes, FILTER_VALIDATE_INT, array("default" => 2048));

        return $this;

    }

    /**
     * Get max result length (in bytes)
     *
     * @return  int     Bytes parent should read (max)
     */
    final public function getMaxResultLength() {

        return $this->max_result_bytes_in_multithread;

    }

    /**
     * Set maximum time (in seconds) the parent will wait for child tasks to be completed (in miltithread mode)
     *
     * After $time seconds, parent will start killing tasks
     *
     * @param   int     $time   Maximum time (seconds)
     *
     * @return  Extender          $this
     */
    final public function setMaxChildsRuntime($time) {

        $this->max_childs_runtime = filter_var($time, FILTER_VALIDATE_INT, array("min_range" => 1, "default" => 300));

        return $this;

    }

    /**
     * Get maximum time (in seconds) the parent will wait for child tasks to be completed (in miltithread mode)
     *
     * @return  int     Time parent will wait for childs to be completed
     */
    final public function getMaxChildsRuntime() {

        return $this->max_childs_runtime;

    }

    /**
     * Set working mode (single or multithread)
     *
     * If multithread enabled, extender will use pcntl to fork child tasks
     *
     * @param   bool    $mode   Enable/disable multithread
     *
     * @return  Extender          $this
     */
    final public function setMultithreadMode($mode) {

        $this->multithread_mode = filter_var($mode, FILTER_VALIDATE_BOOLEAN);

        return $this;

    }

    /**
     * Get multithread mode status
     *
     * @return  bool    True if enabled, false if disabled
     */
    final public function getMultithreadMode() {

        return ($this->multithread_mode AND Checks::multithread()) ? true : false;
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);

    }

    /**
     * Get daemon mode status
     *
     * @return  bool    True if enabled, false if disabled
     */
    final public function getDaemonMode() {

        return $this->daemon_mode;

    }

    /**
     * Get the number of completed processes
     *
     * @return  int
     */
    final public function getCompletedProcesses() {

        return $this->completed_processes;

    }

    /**
     * Get the number of failed processes
     *
     * @return int
     */
    final public function getFailedProcesses() {

        return $this->failed_processes;

    }

    /**
     * Get current version
     *
     * @return  string
     */
    final public function getVersion() {

        return Version::getVersion();

    }

    /**
     * Get events manager
     *
     * @return  \Comodojo\Extender\Events
     */
    final public function events() {

        return $this->events;

    }

    /**
     * Get console color instance
     *
     * @return  \Console_Color2
     */
    final public function color() {

        return $this->color;

    }

    /**
     * Get internal logger
     *
     * @return  \Monolog\Logger
     */
    final public function logger() {

        return $this->logger;

    }

    /**
     * Get jobs' runner
     *
     * @return  JobsRunner
     */
    final public function runner() {

        return $this->runner;

    }

    /**
     * Get the tasks' table
     *
     * @return  TasksTable
     */
    final public function tasks() {

        return $this->tasks;

    }

    /**
     * Do extend!
     *
     */
    public function extend() {

        if ( $this->getDaemonMode() ) {

            $this->logger->notice("Executing extender in daemon mode");

            $idle_time = defined("EXTENDER_IDLE_TIME") ? filter_var(EXTENDER_IDLE_TIME, FILTER_VALIDATE_INT, array(
                'options' => array(
                    'default' => 1,
                    'min_range' => 1
                )
            )) : 1;

            while (true) {

                $this->cycle();

                sleep($idle_time);

            }

        } else {

            $this->logger->notice("Executing extender in single mode");

            $this->cycle();

        }

    }

    /**
     * Change parent process priority according to EXTENDER_NICENESS
     *
     */
    final public function adjustNiceness() {

        if ( defined("EXTENDER_PARENT_NICENESS") ) {

            $niceness = proc_nice(EXTENDER_PARENT_NICENESS);

            if ( $niceness == false ) $this->logger->warning("Unable to set parent process niceness to ".EXTENDER_PARENT_NICENESS);


        }

    }

    /**
     * Register signals
     *
     */
    final public function registerSignals() {

        $pluggable_signals = array(
            SIGHUP, SIGCHLD, SIGUSR2, SIGILL, SIGTRAP, SIGABRT, SIGIOT, SIGBUS, SIGFPE,
            SIGSEGV, SIGPIPE, SIGALRM, SIGTTIN, SIGTTOU, SIGURG, SIGXCPU, SIGXFSZ,
            SIGVTALRM, SIGPROF, SIGWINCH, SIGIO, SIGSYS, SIGBABY
        );

        if ( defined('SIGPOLL') )   $pluggable_signals[] = SIGPOLL;
        if ( defined('SIGPWR') )    $pluggable_signals[] = SIGPWR;
        if ( defined('SIGSTKFLT') ) $pluggable_signals[] = SIGSTKFLT;

        // register supported signals

        pcntl_signal(SIGTERM, array($this, 'sigTermHandler'));

        pcntl_signal(SIGINT, array($this, 'sigTermHandler'));

        pcntl_signal(SIGTSTP, array($this, 'sigStopHandler'));

        pcntl_signal(SIGCONT, array($this, 'sigContHandler'));

        //pcntl_signal(SIGUSR1, array($this,'sigUsr1Handler'));


        // register pluggable signals

        foreach ( $pluggable_signals as $signal ) {

            pcntl_signal($signal, array($this, 'genericSignalHandler'));

        }

        // register shutdown function

        register_shutdown_function(array($this, 'shutdown'));

    }

    /**
     * Delete all status file after exit() called
     *
     */
    final public function shutdown($force = false) {

        if ( $this->parent_pid == posix_getpid() ) {

            $this->logger->info("Shutdown in progress, cleaning environment");

            Lock::release();

            Status::release();

            Queue::release();

            Planner::release();

        }

        if ( $force === true ) {

            $this->logger->info("Shutdown in progress, cleaning environment");

            Status::release();

            Queue::release();

            Planner::release();

        }

    }

    /**
     * The sigTerm handler.
     *
     * It kills everything and then exit with status 1
     */
    final public function sigTermHandler() {

        if ( $this->parent_pid == posix_getpid() ) {

            $this->logger->info("Received TERM signal, shutting down extender gracefully");

            $this->runner->killAll($this->parent_pid);

            self::end(1);

        }

    }

    /**
     * The sigStop handler.
     *
     * It just pauses extender execution
     */
    final public function sigStopHandler() {

        if ( $this->parent_pid == posix_getpid() ) {

            $this->logger->info("Received STOP signal, pausing extender");

            $this->paused = true;

        }

    }

    /**
     * The sigCont handler.
     *
     * It just resume extender execution
     */
    final public function sigContHandler() {

        if ( $this->parent_pid == posix_getpid() ) {

            $this->logger->info("Received CONT signal, resuming extender");

            $this->paused = false;

        }

    }

    /**
     * The generig signal handler.
     *
     * It can be used to handle custom signals
     */
    final public function genericSignalHandler($signal) {

        if ( $this->parent_pid == posix_getpid() ) {

            $this->logger->info("Received ".$signal." signal, firing associated event(s)");

            $this->events->fire("extender.signal.".$signal, "VOID", $this);

        }

    }

    private function cycle() {

      // fire extender ready event

      $this->events->fire("extender", "VOID", $this);

      // dispatch signals (if multithread active)

      if ( $this->getMultithreadMode() ) pcntl_signal_dispatch();

      // if extender is paused (SIGINT), skip to extend

      if ( $this->paused ) return;

      // fix relative timestamp

      $this->timestamp = microtime(true);

      // fire tasktable event

      $this->tasks = $this->events->fire("extender.tasks", "TASKSTABLE", $this->tasks);

      // get the next planned activity interval

      $plans = Planner::get();

      if ( !is_null($plans) AND $this->timestamp < $plans ) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);

          // nothing to do right now, still waiting if in daemon mode

          $this->logger->info("Next planned job: ".date('c', $plans));

          $this->logger->notice("Extender completed\n");

          if ( $this->getDaemonMode() === false ) {

              $this->shutdown(true);

              self::end(0);

          }

          return;

      }

      // if no plan is retrieved, try to retrieve it from scheduler

      try {

          // get schedules and dispatch schedule event

          list($schedules, $planned) = Scheduler::getSchedules($this->logger, $this->timestamp);

          // write next planned activity interval

          if ( !is_null($planned) AND $planned != 0 ) Planner::set($planned);
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);

          $scheduled = new Schedule();

          $scheduled->setSchedules($schedules);

          // expose the current shcedule via events

          $scheduled = $this->events->fire("extender.schedule", "SCHEDULE", $scheduled);

          // if no jobs in queue, exit gracefully

          if ( $scheduled->howMany() == 0 ) {

              $this->logger->info("No jobs to process right now, exiting");

              $this->logger->notice("Extender completed\n");

              if ( $this->getDaemonMode() === false ) {

                  $this->shutdown(true);

                  self::end(0);

              }

              return;

          }

          // compose jobs

          foreach ( $scheduled->getSchedules() as $schedule ) {

              if ( $this->tasks->isRegistered($schedule['task']) ) {

                  $job = new Job();

                  $job->setName($schedule['name'])
                      ->setId($schedule['id'])
                      ->setParameters(unserialize($schedule['params']))
                      ->setTask($schedule['task'])
                      ->setClass($this->tasks->getClass($schedule['task']));

                  $this->runner->addJob($job);

              } else {

                  $this->logger->warning("Skipping job due to unknown task", array(
                      "ID"     => $schedule['id'],
                      "NAME"   => $schedule['name'],
                      "TASK"   => $schedule['task']
                  ));

              }

          }

          // lauch runner

          $result = $this->runner->run();

          // free runner for next cycle

          $this->runner->free();

          // compose results

          $results = new JobsResult($result);

          // update schedules

          Scheduler::updateSchedules($this->logger, $result);

          // increment counters

          foreach ( $result as $r ) {

              if ( $r[2] ) $this->completed_processes++;

              else $this->failed_processes++;

          }

      } catch (Exception $e) {

          $this->logger->error($e->getMessage());

          if ( $this->getDaemonMode() === false ) {

              self::end(1);

          }

      }

      // fire result event

      $this->events->fire("extender.result", "VOID", $results);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

      $this->logger->notice("Extender completed\n");

      // show summary (if -s)

      if ( $this->summary_mode ) self::showSummary($this->timestamp, $result, $this->color);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

      Status::dump($this->timestamp_absolute, $this->parent_pid, $this->completed_processes, $this->failed_processes, $this->paused);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

      if ( $this->getDaemonMode() === false ) {

          $this->shutdown(true);

          self::end(0);

      }

    }

    private static function showHelp($color) {

        echo Version::getDescription();

        echo "\nVersion: ".$color->convert("%g".Version::getVersion()."%n");

        echo "\n\nAvailable options:";

        echo "\n------------------";

        echo "\n".$color->convert("%g -v %n").": verbose mode";

        echo "\n".$color->convert("%g -V %n").": debug mode";

        echo "\n".$color->convert("%g -s %n").": show summary of executed jobs (if any)";

        echo "\n".$color->convert("%g -d %n").": run extender in daemon mode";

        echo "\n".$color->convert("%g -h %n").": show this help";

        echo "\n\n";

    }

    private static function getCommandlineOptions() {

        $options = getopt("svdVh");

        return array(
            array_key_exists('v', $options) ? true : false,
            array_key_exists('V', $options) ? true : false,
            array_key_exists('s', $options) ? true : false,
            array_key_exists('d', $options) ? true : false,
            array_key_exists('h', $options) ? true : false
        );

    }

    /**
     * @param double $timestamp
     */
    private static function showSummary($timestamp, $completed_processes, $color) {

        $header_string = "\n\n --- Comodojo Extender Summary --- ".date('c', $timestamp)."\n\n";

        $tbl = new Console_Table(CONSOLE_TABLE_ALIGN_LEFT, CONSOLE_TABLE_BORDER_ASCII, 1, null, true);

        $tbl->setHeaders(array(
            'Pid',
            'Name',
            'Log Id',
            'Success',
            'Result (truncated)',
            'Time elapsed'
        ));

        foreach ( $completed_processes as $key => $completed_process ) {

            $pid = $completed_process[0];

            $name = $completed_process[1];

            $success = $color->convert($completed_process[2] ? "%gYES%n" : "%rNO%n");

            $result = str_replace(array("\r", "\n"), " ", $completed_process[5]);

            $result = strlen($result) >= 80 ? substr($result, 0, 80)."..." : $result;

            $elapsed = empty($completed_process[4]) ? "--" : ($completed_process[4] - $completed_process[3]);

            $worklog_id = $completed_process[7];

            $tbl->addRow(array(
                $pid,
                $name,
                $worklog_id,
                $success,
                $result,
                $elapsed
            ));

        }

        $footer_string = "\n\nTotal script runtime: ".(microtime(true) - $timestamp)." seconds\r\n\n";

        print $header_string.$tbl->getTable().$footer_string;

    }

    /**
     * @param integer $returnCode
     */
    private static function end($returnCode) {


        if ( defined('COMODOJO_PHPUNIT_TEST') && @constant('COMODOJO_PHPUNIT_TEST') === true ) {

            if ( $returnCode === 1 ) throw new Exception("PHPUnit Test Exception");

            else return $returnCode;

        } else {

            exit($returnCode);

        }

    }

}

Push — master ( 8a4ca9...acd23c )

Extender::getCompletedProcesses() A

Complexity

Size

Duplication

Code Coverage

Importance

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Available Fixes

Available Fixes

comodojo / extender.framework

Push — master ( 8a4ca9...acd23c )

Extender::getCompletedProcesses() A

Complexity

Size

Duplication

Code Coverage

Importance

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
