Completed
Push — 2.0 ( a11c65...7cb9cd )
by Marco
11:37
created
test_socket_2.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@
 block discarded – undo
6 6
 
7 7
     $client = \Comodojo\Daemon\Socket\Client::create('unix://extender.sock');
8 8
 
9
-    $data = $client->send('scheduler:refresh',[]);
9
+    $data = $client->send('scheduler:refresh', []);
10 10
 
11 11
 } catch (Exception $e) {
12 12
 
Please login to merge, or discard this patch.
src/Comodojo/Extender/Components/Ipc.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -48,6 +48,9 @@  discard block
 block discarded – undo
48 48
 
49 49
     }
50 50
 
51
+    /**
52
+     * @param integer $uid
53
+     */
51 54
     public function init($uid) {
52 55
 
53 56
         $this->ipc[$uid] = [];
@@ -72,6 +75,10 @@  discard block
 block discarded – undo
72 75
 
73 76
     }
74 77
 
78
+    /**
79
+     * @param integer $uid
80
+     * @param string $data
81
+     */
75 82
     public function write($uid, $data) {
76 83
 
77 84
         $writer = $this->ipc[$uid][self::WRITER];
Please login to merge, or discard this patch.
src/Comodojo/Extender/Orm/Entities/Schedule.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
     /**
137 137
      * Get cron expression of this schedule
138 138
      *
139
-     * @return string
139
+     * @return CronExpression
140 140
      */
141 141
     public function getExpression() {
142 142
 
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
     /**
148 148
      * set cron expression for this schedule
149 149
      *
150
-     * @param srting $expression A cron-compatible expression
150
+     * @param CronExpression $expression A cron-compatible expression
151 151
      * @return Schedule
152 152
      */
153 153
     public function setExpression(CronExpression $expression) {
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
     /**
178 178
      * Set enable/disable status
179 179
      *
180
-     * @param bool $enable
180
+     * @param boolean $enabled
181 181
      * @return Schedule
182 182
      */
183 183
     public function setEnabled($enabled) {
Please login to merge, or discard this patch.
src/Comodojo/Extender/Components/Database.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -58,6 +58,9 @@
 block discarded – undo
58 58
 
59 59
     }
60 60
 
61
+    /**
62
+     * @return \Doctrine\ORM\EntityManagerInterface
63
+     */
61 64
     public function getEntityManager() {
62 65
 
63 66
         if ( $this->entity_manager === null ) {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
                 false
85 85
             ];
86 86
 
87
-            switch (strtoupper($metadata_mode)) {
87
+            switch ( strtoupper($metadata_mode) ) {
88 88
 
89 89
                 case 'YAML':
90 90
                     $db_config = Setup::createYAMLMetadataConfiguration(...$config_args);
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
         $repos = $configuration->get('database-repositories');
179 179
 
180 180
         return array_map(function($repo) use ($base_folder) {
181
-            return substr($repo, 0, 1 ) === "/" ? $repo : "$base_folder/$repo";
181
+            return substr($repo, 0, 1) === "/" ? $repo : "$base_folder/$repo";
182 182
         }, $repos);
183 183
 
184 184
     }
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
         $base_folder = $configuration->get('base-path');
189 189
         $folder = $configuration->get('database-proxies');
190 190
 
191
-        return substr($folder, 0, 1 ) === "/" ? $folder : "$base_folder/$folder";
191
+        return substr($folder, 0, 1) === "/" ? $folder : "$base_folder/$folder";
192 192
 
193 193
     }
194 194
 
Please login to merge, or discard this patch.
src/Comodojo/Extender/Queue/Manager.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,6 @@
 block discarded – undo
41 41
      *
42 42
      * @param Configuration $configuration
43 43
      * @param LoggerInterface $logger
44
-     * @param TasksTable $tasks
45 44
      * @param EventsManager $events
46 45
      * @param EntityManager $em
47 46
      */
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 
81 81
         $em = $this->getEntityManager();
82 82
 
83
-        foreach ($queue as $record) {
83
+        foreach ( $queue as $record ) {
84 84
             $em->remove($record);
85 85
         }
86 86
 
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 
107 107
         $records = [];
108 108
 
109
-        foreach ($queue as $name => $request) {
109
+        foreach ( $queue as $name => $request ) {
110 110
             $records[] = $request instanceof Request ? $this->doAddRequest($request, $em) : false;
111 111
         }
112 112
 
Please login to merge, or discard this patch.
src/Comodojo/Extender/Task/Manager.php 2 patches
Doc Comments   +9 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,12 +75,10 @@  discard block
 block discarded – undo
75 75
     /**
76 76
      * Class constructor
77 77
      *
78
-     * @param string $manager_name
79 78
      * @param Configuration $configuration
80 79
      * @param LoggerInterface $logger
81 80
      * @param TasksTable $tasks
82 81
      * @param EventsManager $events
83
-     * @param EntityManager $em
84 82
      */
85 83
     public function __construct(
86 84
         Locker $locker,
@@ -413,6 +411,9 @@  discard block
 block discarded – undo
413 411
 
414 412
     }
415 413
 
414
+    /**
415
+     * @param string $message
416
+     */
416 417
     private function generateSyntheticResult($uid, $message, $jid = null, $success = true) {
417 418
 
418 419
         return new Result([
@@ -437,6 +438,9 @@  discard block
 block discarded – undo
437 438
 
438 439
     }
439 440
 
441
+    /**
442
+     * @param null|integer $pid
443
+     */
440 444
     private function updateTrackerSetRunning($uid, $pid) {
441 445
 
442 446
         $this->tracker->setRunning($uid, $pid);
@@ -466,6 +470,9 @@  discard block
 block discarded – undo
466 470
 
467 471
     }
468 472
 
473
+    /**
474
+     * @param Result $result
475
+     */
469 476
     private function updateTrackerSetAborted($uid, $result) {
470 477
 
471 478
         $this->tracker->setAborted($uid, $result);
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -133,9 +133,9 @@  discard block
 block discarded – undo
133 133
 
134 134
     public function addBulk(array $requests) {
135 135
 
136
-        foreach ($requests as $id => $request) {
136
+        foreach ( $requests as $id => $request ) {
137 137
 
138
-            if ($request instanceof \Comodojo\Extender\Task\Request) {
138
+            if ( $request instanceof \Comodojo\Extender\Task\Request ) {
139 139
                 $this->add($request);
140 140
             } else {
141 141
                 $this->logger->error("Skipping invalid request with local id $id: class mismatch");
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
 
175 175
     protected function cycle() {
176 176
 
177
-        foreach ($this->tracker->getQueued() as $uid => $request) {
177
+        foreach ( $this->tracker->getQueued() as $uid => $request ) {
178 178
 
179 179
             if ( $this->multithread === false ) {
180 180
 
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
 
203 203
                 if ( $this->max_childs > 0 && $this->tracker->countRunning() >= $this->max_childs ) {
204 204
 
205
-                    while( $this->tracker->countRunning() >= $this->max_childs ) {
205
+                    while ( $this->tracker->countRunning() >= $this->max_childs ) {
206 206
 
207 207
                         $this->catcher();
208 208
 
Please login to merge, or discard this patch.
src/Comodojo/Extender/Task/Runner.php 2 patches
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -190,6 +190,15 @@  discard block
 block discarded – undo
190 190
 
191 191
     }
192 192
 
193
+    /**
194
+     * @param integer $uid
195
+     * @param integer $puid
196
+     * @param string $name
197
+     * @param integer $jid
198
+     * @param string $task
199
+     * @param TaskParameters $parameters
200
+     * @param \DateTime $start
201
+     */
193 202
     protected function openWorklog(
194 203
         $uid,
195 204
         $puid,
@@ -221,6 +230,9 @@  discard block
 block discarded – undo
221 230
 
222 231
     }
223 232
 
233
+    /**
234
+     * @param \DateTime $end
235
+     */
224 236
     protected function closeWorklog(
225 237
         $status,
226 238
         $result,
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 
87 87
             $thetask = $this->table->get($task)->getInstance($name, $parameters);
88 88
 
89
-            $this->events->emit( new TaskEvent('start', $thetask) );
89
+            $this->events->emit(new TaskEvent('start', $thetask));
90 90
 
91 91
             $pid = $thetask->getPid();
92 92
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 
122 122
             }
123 123
 
124
-            $this->events->emit( new TaskEvent('stop', $thetask) );
124
+            $this->events->emit(new TaskEvent('stop', $thetask));
125 125
 
126 126
             $this->stopwatch->stop();
127 127
 
Please login to merge, or discard this patch.
src/Comodojo/Extender/Task/Tracker.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,6 @@
 block discarded – undo
44 44
     /**
45 45
      * Tracker constructor
46 46
      *
47
-     * @param string $name
48 47
      * @param Configuration $configuration
49 48
      * @param LoggerInterface $logger
50 49
      */
Please login to merge, or discard this patch.
src/Comodojo/Extender/Schedule/Manager.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,6 @@
 block discarded – undo
41 41
      *
42 42
      * @param Configuration $configuration
43 43
      * @param LoggerInterface $logger
44
-     * @param TasksTable $tasks
45 44
      * @param EventsManager $events
46 45
      * @param EntityManager $em
47 46
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@
 block discarded – undo
144 144
         $records = [];
145 145
         $em = $this->getEntityManager();
146 146
 
147
-        foreach ($schedules as $key => $schedule) {
147
+        foreach ( $schedules as $key => $schedule ) {
148 148
 
149 149
             try {
150 150
 
Please login to merge, or discard this patch.