ScheduleWorker::loop() - Code Metrics - Inspection of "working core" - comodojo/extender.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( 76e968...4129d9 )

by Marco

created 2017-08-04 23:42 UTC

ScheduleWorker::loop() B

↳ Parent: ScheduleWorker

Complexity

Conditions	3
Paths	3

Size

Total Lines	30
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	30
rs	8.8571
c	0
b	0
f	0
cc	3
eloc	14
nc	3
nop	0

<?php namespace Comodojo\Extender\Workers;

use \Comodojo\Daemon\Worker\AbstractWorker;
use \Comodojo\Extender\Task\Manager as TaskManager;
use \Comodojo\Extender\Schedule\Manager as ScheduleManager;
use \Comodojo\Extender\Task\Request;
use \Comodojo\Daemon\Traits\LoggerTrait;
use \Comodojo\Daemon\Traits\EventsTrait;
use \Comodojo\Extender\Traits\ConfigurationTrait;
use \Comodojo\Extender\Traits\TasksTableTrait;
use \Comodojo\Extender\Traits\EntityManagerTrait;
use \Comodojo\Extender\Traits\WorkerTrait;

class ScheduleWorker extends AbstractWorker {

    use ConfigurationTrait;
    use LoggerTrait;
    use EventsTrait;
    use TasksTableTrait;
    use EntityManagerTrait;
    use WorkerTrait;

    protected $wakeup_time = 0;

    public function spinup() {


        $this->task_manager = new TaskManager(
            'schedule.worker',
            $this->getConfiguration(),
            $this->getLogger(),
            $this->getTasksTable(),
            $this->getEvents(),
            $this->getEntityManager()
        );

        $this->getEvents()->subscribe('daemon.worker.refresh', '\Comodojo\Extender\Listeners\RefreshScheduler');

        $this->job_manager = new ScheduleManager(
            $this->getConfiguration(),
            $this->getLogger(),
            $this->getEvents(),
            $this->getEntityManager()
        );

    }

    public function loop() {

        if ( $this->wakeup_time > time() ) {
            $this->logger->info('Still in sleep time, sorry');
            return;
        }

        $jobs = $this->job_manager->getJobs(true);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        if ( empty($jobs) ) {

            $this->logger->debug('Nothing to do right now, sleeping... zzZZzZzZzz');

        } else {

            $this->logger->debug(count($jobs)." jobs will be executed");

            $requests = $this->jobsToRequests($jobs);

            $this->task_manager->addBulk($requests);

            $result = $this->task_manager->run();

            $this->job_manager->updateSchedules($result);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        }

        $this->wakeup_time = $this->job_manager->getNextCycleTimestamp();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

    }

    public function spindown() {

        unset($this->task_manager);
        unset($this->job_manager);

    }

    public function refreshPlans() {

        $this->wakeup_time = 0;

    }

}


1		<?php namespace Comodojo\Extender\Workers;
2
3		use \Comodojo\Daemon\Worker\AbstractWorker;
4		use \Comodojo\Extender\Task\Manager as TaskManager;
5		use \Comodojo\Extender\Schedule\Manager as ScheduleManager;
6		use \Comodojo\Extender\Task\Request;
7		use \Comodojo\Daemon\Traits\LoggerTrait;
8		use \Comodojo\Daemon\Traits\EventsTrait;
9		use \Comodojo\Extender\Traits\ConfigurationTrait;
10		use \Comodojo\Extender\Traits\TasksTableTrait;
11		use \Comodojo\Extender\Traits\EntityManagerTrait;
12		use \Comodojo\Extender\Traits\WorkerTrait;
13
14		class ScheduleWorker extends AbstractWorker {
15
16		use ConfigurationTrait;
17		use LoggerTrait;
18		use EventsTrait;
19		use TasksTableTrait;
20		use EntityManagerTrait;
21		use WorkerTrait;
22
23		protected $wakeup_time = 0;
24
25	View Code Duplication	public function spinup() {
		0 ignored issues – show Duplication introduced 2017-08-04 23:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26
27		$this->task_manager = new TaskManager(
28		'schedule.worker',
29		$this->getConfiguration(),
30		$this->getLogger(),
31		$this->getTasksTable(),
32		$this->getEvents(),
33		$this->getEntityManager()
34		);
35
36		$this->getEvents()->subscribe('daemon.worker.refresh', '\Comodojo\Extender\Listeners\RefreshScheduler');
37
38		$this->job_manager = new ScheduleManager(
39		$this->getConfiguration(),
40		$this->getLogger(),
41		$this->getEvents(),
42		$this->getEntityManager()
43		);
44
45		}
46
47		public function loop() {
48
49		if ( $this->wakeup_time > time() ) {
50		$this->logger->info('Still in sleep time, sorry');
51		return;
52		}
53
54		$jobs = $this->job_manager->getJobs(true);
		0 ignored issues – show Bug introduced 2017-08-04 23:55 UTC by Report Bug Copy Issue Report The method `getJobs` does only exist in `Comodojo\Extender\Schedule\Manager`, but not in `Comodojo\Extender\Queue\Manager`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
55
56		if ( empty($jobs) ) {
57
58		$this->logger->debug('Nothing to do right now, sleeping... zzZZzZzZzz');
59
60		} else {
61
62		$this->logger->debug(count($jobs)." jobs will be executed");
63
64		$requests = $this->jobsToRequests($jobs);
65
66		$this->task_manager->addBulk($requests);
67
68		$result = $this->task_manager->run();
69
70		$this->job_manager->updateSchedules($result);
		0 ignored issues – show Bug introduced 2017-08-04 23:55 UTC by Report Bug Copy Issue Report The method `updateSchedules` does only exist in `Comodojo\Extender\Schedule\Manager`, but not in `Comodojo\Extender\Queue\Manager`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
71
72		}
73
74		$this->wakeup_time = $this->job_manager->getNextCycleTimestamp();
		0 ignored issues – show Bug introduced 2017-08-04 23:55 UTC by Report Bug Copy Issue Report The method `getNextCycleTimestamp` does only exist in `Comodojo\Extender\Schedule\Manager`, but not in `Comodojo\Extender\Queue\Manager`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
75
76		}
77
78		public function spindown() {
79
80		unset($this->task_manager);
81		unset($this->job_manager);
82
83		}
84
85		public function refreshPlans() {
86
87		$this->wakeup_time = 0;
88
89		}
90
91		}
92

comodojo / extender.framework

Push — 2.0 ( 76e968...4129d9 )

ScheduleWorker::loop() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like