EntityManagerTrait::setEntityManager() - Code Metrics - Inspection of "working core" - comodojo/extender.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( 76e968...4129d9 )

by Marco

created 2017-08-04 23:42 UTC

EntityManagerTrait::setEntityManager() A

↳ Parent: EntityManagerTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1

<?php namespace Comodojo\Extender\Traits;

use \Doctrine\ORM\EntityManager;

/**
 * @package     Comodojo Extender
 * @author      Marco Giovinazzi <[email protected]>
 * @license     MIT
 *
 * LICENSE:
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

trait EntityManagerTrait {

    /**
     * @var EntityManager
     */
    protected $em;

    /**
     * Get EntityManager
     *
     * @return EntityManager
     */
    public function getEntityManager() {

        return $this->em;

    }

    /**
     * Set EntityManager
     *
     * @param string $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return Schedule
     */
    public function setEntityManager(EntityManager $em) {
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}

        $this->em = $em;

        return $this;

    }

}


1			<?php namespace Comodojo\Extender\Traits;
2
3			use \Doctrine\ORM\EntityManager;
4
5			/**
6			* @package Comodojo Extender
7			* @author Marco Giovinazzi <[email protected]>
8			* @license MIT
9			*
10			* LICENSE:
11			*
12			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
13			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
14			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
15			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
16			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
17			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
18			* THE SOFTWARE.
19			*/
20
21			trait EntityManagerTrait {
22
23			/**
24			* @var EntityManager
25			*/
26			protected $em;
27
28			/**
29			* Get EntityManager
30			*
31			* @return EntityManager
32			*/
33			public function getEntityManager() {
34
35			return $this->em;
36
37			}
38
39			/**
40			* Set EntityManager
41			*
42			* @param string $id
			0 ignored issues – show Bug introduced 2017-08-04 23:55 UTC by Report Bug Copy Issue Report There is no parameter named `$id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
43			* @return Schedule
44			*/
45			public function setEntityManager(EntityManager $em) {
			0 ignored issues – show Bug introduced 2017-08-04 23:55 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$em`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
46
47			$this->em = $em;
48
49			return $this;
50
51			}
52
53			}
54

comodojo / extender.framework

Push — 2.0 ( 76e968...4129d9 )

EntityManagerTrait::setEntityManager() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like