Comodojo\Extender\Schedule\Request

Complexity

Total Complexity

10

Size/Duplication

Total Lines	121
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	getName()	0	5	1
A	setName()	0	7	1
A	getTaskRequest()	0	5	1
A	setTaskRequest()	0	7	1
A	getDescription()	0	5	1
A	setDescription()	0	7	1
A	getExpression()	0	5	1
A	setCronExpression()	0	7	1
A	create()	0	5	1

<?php namespace Comodojo\Extender\Schedule;

use \Comodojo\Extender\Task\Request as TaskRequest;
use \Cron\CronExpression;

/**
* @package     Comodojo Extender
* @author      Marco Giovinazzi <marco.giovinazzi@comodojo.org>
* @license     MIT
*
* LICENSE:
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
 */

class Request {

    /**
     * @var string
     */
    protected $name;

    /**
     * @var string
     */
    protected $description;

    /**
     * @var TaskRequest
     */
    protected $request;

    /**
     * @var string
     */
    protected $expression;

    /**
     * Class constructor
     *
     * @param string $name
     * @param string $task

There is no parameter named $task. Was it maybe removed?

     * @param TaskParameters $parameters

There is no parameter named $parameters. Was it maybe removed?

     */
    public function __construct($name, $expression, TaskRequest $request, $description = null) {

        $this->setName($name)

The method setExpression() does not seem to exist on object<Comodojo\Extender\Schedule\Request>.

            ->setExpression($expression)
            ->setRequest($request)
            ->setDescription($description);

    }

    /**
     * Get request name
     *
     * @return string
     */
    public function getName() {

        return $this->name;

    }

    public function setName($name) {

        $this->name = $name;

        return $this;

    }

    /**
     * Get request associated task
     *
     * @return string
     */
    public function getTaskRequest() {

        return $this->request;

    }

    public function setTaskRequest(TaskRequest $request) {

        $this->request = $request;

        return $this;

    }

    /**
     * Get description
     *
     * @return string
     */
    public function getDescription() {

        return $this->description;

    }

    public function setDescription($description = null) {

        $this->description = $description;

        return $this;

    }

    /**
     * Get parent unique id
     *
     * @return int
     */
    public function getExpression() {

        return $this->expression;

    }

    public function setCronExpression(CronExpression $expression) {

        $this->expression = $expression;

It seems like $expression of type object<Cron\CronExpression> is incompatible with the declared type string of property $expression.

        return $this;

    }

    public static function create($name, $task, TaskParameters $parameters = null) {

        return new Request($name, $task, $parameters);

It seems like $parameters defined by parameter $parameters on line 136 can also be of type null; however, Comodojo\Extender\Schedule\Request::__construct() does only seem to accept object<Comodojo\Extender\Task\Request>, maybe add an additional type check?

    }

}