Manager::remove() - Code Metrics - Inspection of "working on events" - comodojo/extender.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( 8b36d5...0f73ad )

by Marco

created 2017-09-19 22:33 UTC

Manager::remove() A

↳ Parent: Manager

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	1

<?php namespace Comodojo\Extender\Queue;

use \Comodojo\Foundation\Base\Configuration;
use \Comodojo\Foundation\Base\ConfigurationTrait;
use \Comodojo\Foundation\Events\Manager as EventsManager;
use \Comodojo\Foundation\Logging\LoggerTrait;
use \Comodojo\Foundation\Events\EventsTrait;
use \Comodojo\Extender\Components\Database;
use \Comodojo\Extender\Traits\EntityManagerTrait;
use \Comodojo\Extender\Task\Request;
use \Comodojo\Extender\Orm\Entities\Queue;
use \Comodojo\Extender\Events\QueueEvent;
use \Doctrine\ORM\EntityManager;
use \Psr\Log\LoggerInterface;
use \Exception;

/**
* @package     Comodojo Extender
* @author      Marco Giovinazzi <[email protected]>
* @license     MIT
*
* LICENSE:
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
 */

class Manager {

    use ConfigurationTrait;
    use LoggerTrait;
    use EventsTrait;
    use EntityManagerTrait;

    /**
     * Class constructor
     *
     * @param Configuration $configuration
     * @param LoggerInterface $logger
     * @param TasksTable $tasks
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param EventsManager $events
     * @param EntityManager $em
     */
    public function __construct(

        Configuration $configuration,
        LoggerInterface $logger,
        EventsManager $events,
        EntityManager $em = null
    ) {

        $this->setConfiguration($configuration);
        $this->setLogger($logger);
        $this->setEvents($events);

        $em = is_null($em) ? Database::init($configuration)->getEntityManager() : $em;
        $this->setEntityManager($em);

        // $logger->debug("Tasks Manager online", array(

        //     'lagger_timeout' => $this->lagger_timeout,

        //     'multithread' => $this->multithread,

        //     'max_runtime' => $this->max_runtime,

        //     'max_childs' => $this->max_childs

        // ));

    }

    public function get() {

        $em = $this->getEntityManager();

        return $em->getRepository('Comodojo\Extender\Orm\Entities\Queue')->findAll();

    }

    public function flush(array $queue) {

        $this->getEvents()->emit( new QueueEvent('flush', null, $queue) );

        $em = $this->getEntityManager();

        foreach ($queue as $record) {
            $em->remove($record);
        }

        $em->flush();

    }

    public function add(Request $request) {

        $em = $this->getEntityManager();

        $uid = $this->doAddRequest($request, $em);

        $em->flush();

        return $uid;

    }

    public function addBulk(array $queue) {

        $em = $this->getEntityManager();

        $records = [];

        foreach ($queue as $name => $request) {
            $records[] = $request instanceof Request ? $this->doAddRequest($request, $em) : false;
        }

        $em->flush();

        return $records;

    }

    protected function doAddRequest(Request $request, EntityManager $em) {

        $this->getEvents()->emit( new QueueEvent('add', $request) );

        $record = new Queue();
        $record->setName($request->getName())->setRequest($request);

        $em->persist($record);

        return $request->getUid();

    }

}


1		<?php namespace Comodojo\Extender\Queue;
2
3		use \Comodojo\Foundation\Base\Configuration;
4		use \Comodojo\Foundation\Base\ConfigurationTrait;
5		use \Comodojo\Foundation\Events\Manager as EventsManager;
6		use \Comodojo\Foundation\Logging\LoggerTrait;
7		use \Comodojo\Foundation\Events\EventsTrait;
8		use \Comodojo\Extender\Components\Database;
9		use \Comodojo\Extender\Traits\EntityManagerTrait;
10		use \Comodojo\Extender\Task\Request;
11		use \Comodojo\Extender\Orm\Entities\Queue;
12		use \Comodojo\Extender\Events\QueueEvent;
13		use \Doctrine\ORM\EntityManager;
14		use \Psr\Log\LoggerInterface;
15		use \Exception;
16
17		/**
18		* @package Comodojo Extender
19		* @author Marco Giovinazzi <[email protected]>
20		* @license MIT
21		*
22		* LICENSE:
23		*
24		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
25		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
26		* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
27		* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
28		* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
29		* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
30		* THE SOFTWARE.
31		*/
32
33		class Manager {
34
35		use ConfigurationTrait;
36		use LoggerTrait;
37		use EventsTrait;
38		use EntityManagerTrait;
39
40		/**
41		* Class constructor
42		*
43		* @param Configuration $configuration
44		* @param LoggerInterface $logger
45		* @param TasksTable $tasks
		0 ignored issues – show Bug introduced 2017-08-04 23:55 UTC by Report Bug Copy Issue Report There is no parameter named `$tasks`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
46		* @param EventsManager $events
47		* @param EntityManager $em
48		*/
49	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2017-08-04 23:55 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		Configuration $configuration,
51		LoggerInterface $logger,
52		EventsManager $events,
53		EntityManager $em = null
54		) {
55
56		$this->setConfiguration($configuration);
57		$this->setLogger($logger);
58		$this->setEvents($events);
59
60		$em = is_null($em) ? Database::init($configuration)->getEntityManager() : $em;
61		$this->setEntityManager($em);
62
63		// $logger->debug("Tasks Manager online", array(
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 23:55 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
64		// 'lagger_timeout' => $this->lagger_timeout,
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 23:55 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
65		// 'multithread' => $this->multithread,
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 23:55 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
66		// 'max_runtime' => $this->max_runtime,
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 23:55 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
67		// 'max_childs' => $this->max_childs
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 23:55 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
68		// ));
69
70		}
71
72		public function get() {
73
74		$em = $this->getEntityManager();
75
76		return $em->getRepository('Comodojo\Extender\Orm\Entities\Queue')->findAll();
77
78		}
79
80		public function flush(array $queue) {
81
82		$this->getEvents()->emit( new QueueEvent('flush', null, $queue) );
83
84		$em = $this->getEntityManager();
85
86		foreach ($queue as $record) {
87		$em->remove($record);
88		}
89
90		$em->flush();
91
92		}
93
94		public function add(Request $request) {
95
96		$em = $this->getEntityManager();
97
98		$uid = $this->doAddRequest($request, $em);
99
100		$em->flush();
101
102		return $uid;
103
104		}
105
106		public function addBulk(array $queue) {
107
108		$em = $this->getEntityManager();
109
110		$records = [];
111
112		foreach ($queue as $name => $request) {
113		$records[] = $request instanceof Request ? $this->doAddRequest($request, $em) : false;
114		}
115
116		$em->flush();
117
118		return $records;
119
120		}
121
122		protected function doAddRequest(Request $request, EntityManager $em) {
123
124		$this->getEvents()->emit( new QueueEvent('add', $request) );
125
126		$record = new Queue();
127		$record->setName($request->getName())->setRequest($request);
128
129		$em->persist($record);
130
131		return $request->getUid();
132
133		}
134
135		}
136

comodojo / extender.framework

Push — 2.0 ( 8b36d5...0f73ad )

Manager::remove() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like