comodojo / extender.framework

src/Comodojo/Extender/Components/Database.php

Doc Comments +3 added lines

@@ -58,6 +58,9 @@
 
     }
 
+    /**
+     * @return \Doctrine\ORM\EntityManagerInterface
+     */
     public function getEntityManager() {
 
         if ( $this->entity_manager === null ) {

Spacing +3 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
                 false
             ];
 
-            switch (strtoupper($metadata_mode)) {
+            switch ( strtoupper($metadata_mode) ) {
 
                 case 'YAML':
                     $db_config = Setup::createYAMLMetadataConfiguration(...$config_args);
@@ -178,7 +178,7 @@ 
         $repos = $configuration->get('database-repositories');
 
         return array_map(function($repo) use ($base_folder) {
-            return substr($repo, 0, 1 ) === "/" ? $repo : "$base_folder/$repo";
+            return substr($repo, 0, 1) === "/" ? $repo : "$base_folder/$repo";
         }, $repos);
 
     }
@@ -188,7 +188,7 @@ 
         $base_folder = $configuration->get('base-path');
         $folder = $configuration->get('database-proxies');
 
-        return substr($folder, 0, 1 ) === "/" ? $folder : "$base_folder/$folder";
+        return substr($folder, 0, 1) === "/" ? $folder : "$base_folder/$folder";
 
     }
 

src/Comodojo/Extender/Queue/Manager.php

Doc Comments -1 removed lines

@@ -41,7 +41,6 @@
      *
      * @param Configuration $configuration
      * @param LoggerInterface $logger
-     * @param TasksTable $tasks
      * @param EventsManager $events
      * @param EntityManager $em
      */

Spacing +4 added lines, -4 removed lines

@@ -79,11 +79,11 @@ 
 
     public function flush(array $queue) {
 
-        $this->getEvents()->emit( new QueueEvent('flush', null, $queue) );
+        $this->getEvents()->emit(new QueueEvent('flush', null, $queue));
 
         $em = $this->getEntityManager();
 
-        foreach ($queue as $record) {
+        foreach ( $queue as $record ) {
             $em->remove($record);
         }
 
@@ -109,7 +109,7 @@ 
 
         $records = [];
 
-        foreach ($queue as $name => $request) {
+        foreach ( $queue as $name => $request ) {
             $records[] = $request instanceof Request ? $this->doAddRequest($request, $em) : false;
         }
 
@@ -121,7 +121,7 @@ 
 
     protected function doAddRequest(Request $request, EntityManager $em) {
 
-        $this->getEvents()->emit( new QueueEvent('add', $request) );
+        $this->getEvents()->emit(new QueueEvent('add', $request));
 
         $record = new Queue();
         $record->setName($request->getName())->setRequest($request);

src/Comodojo/Extender/Task/Manager.php

Doc Comments +9 added lines, -2 removed lines

@@ -75,12 +75,10 @@ 
     /**
      * Class constructor
      *
-     * @param string $manager_name
      * @param Configuration $configuration
      * @param LoggerInterface $logger
      * @param TasksTable $tasks
      * @param EventsManager $events
-     * @param EntityManager $em
      */
     public function __construct(
         Locker $locker,
@@ -413,6 +411,9 @@ 
 
     }
 
+    /**
+     * @param string $message
+     */
     private function generateSyntheticResult($uid, $message, $jid = null, $success = true) {
 
         return new Result([
@@ -437,6 +438,9 @@ 
 
     }
 
+    /**
+     * @param null|integer $pid
+     */
     private function updateTrackerSetRunning($uid, $pid) {
 
         $this->tracker->setRunning($uid, $pid);
@@ -466,6 +470,9 @@ 
 
     }
 
+    /**
+     * @param Result $result
+     */
     private function updateTrackerSetAborted($uid, $result) {
 
         $this->tracker->setAborted($uid, $result);

Spacing +4 added lines, -4 removed lines

@@ -128,9 +128,9 @@ 
 
     public function addBulk(array $requests) {
 
-        foreach ($requests as $id => $request) {
+        foreach ( $requests as $id => $request ) {
 
-            if ($request instanceof \Comodojo\Extender\Task\Request) {
+            if ( $request instanceof \Comodojo\Extender\Task\Request ) {
                 $this->add($request);
             } else {
                 $this->logger->error("Skipping invalid request with local id $id: class mismatch");
@@ -163,7 +163,7 @@ 
 
         $this->installErrorHandler();
 
-        foreach ($this->tracker->getQueued() as $uid => $request) {
+        foreach ( $this->tracker->getQueued() as $uid => $request ) {
 
             if ( $this->multithread === false ) {
 
@@ -191,7 +191,7 @@ 
 
                 if ( $this->max_childs > 0 && $this->tracker->countRunning() >= $this->max_childs ) {
 
-                    while( $this->tracker->countRunning() >= $this->max_childs ) {
+                    while ( $this->tracker->countRunning() >= $this->max_childs ) {
 
                         $this->catcher();
 

src/Comodojo/Extender/Task/Runner.php

Doc Comments +12 added lines

@@ -190,6 +190,15 @@ 
 
     }
 
+    /**
+     * @param integer $uid
+     * @param integer $puid
+     * @param string $name
+     * @param integer $jid
+     * @param string $task
+     * @param TaskParameters $parameters
+     * @param \DateTime $start
+     */
     protected function openWorklog(
         $uid,
         $puid,
@@ -221,6 +230,9 @@ 
 
     }
 
+    /**
+     * @param \DateTime $end
+     */
     protected function closeWorklog(
         $status,
         $result,

Spacing +9 added lines, -9 removed lines

@@ -89,7 +89,7 @@ 
 
             $thetask = $this->table->get($task)->getInstance($name, $parameters);
 
-            $this->events->emit( new TaskEvent('start', $thetask) );
+            $this->events->emit(new TaskEvent('start', $thetask));
 
             $pid = $thetask->getPid();
 
@@ -112,7 +112,7 @@ 
 
                 $status = Worklog::STATUS_COMPLETE;
 
-                $this->events->emit( new TaskEvent('complete', $thetask) );
+                $this->events->emit(new TaskEvent('complete', $thetask));
 
             } catch (TaskException $te) {
 
@@ -120,7 +120,7 @@ 
 
                 $result = $te->getMessage();
 
-                $this->events->emit( new TaskEvent('abort', $thetask) );
+                $this->events->emit(new TaskEvent('abort', $thetask));
 
             } catch (Exception $e) {
 
@@ -128,13 +128,13 @@ 
 
                 $result = $e->getMessage();
 
-                $this->events->emit( new TaskEvent('error', $thetask) );
+                $this->events->emit(new TaskEvent('error', $thetask));
 
             }
 
             $this->restoreErrorHandler();
 
-            $this->events->emit( new TaskEvent('stop', $thetask) );
+            $this->events->emit(new TaskEvent('stop', $thetask));
 
             $this->stopwatch->stop();
 
@@ -168,7 +168,7 @@ 
 
         ob_end_clean();
 
-        $this->events->emit( new TaskEvent(self::statusToEvent($status), $thetask, $result) );
+        $this->events->emit(new TaskEvent(self::statusToEvent($status), $thetask, $result));
 
         return $result;
 
@@ -227,7 +227,7 @@ 
                 $worklog->setJid($schedule);
             }
 
-            $this->events->emit( new WorklogEvent('open', $worklog) );
+            $this->events->emit(new WorklogEvent('open', $worklog));
 
             $em->persist($worklog);
             $em->flush();
@@ -266,7 +266,7 @@ 
                 $worklog->setJid($schedule);
             }
 
-            $this->events->emit( new WorklogEvent('close', $worklog) );
+            $this->events->emit(new WorklogEvent('close', $worklog));
 
             $em->persist($worklog);
             $em->flush();
@@ -281,7 +281,7 @@ 
 
     protected function statusToEvent($status) {
 
-        switch ($status) {
+        switch ( $status ) {
             case Worklog::STATUS_COMPLETE:
                 return 'complete';
                 break;

src/Comodojo/Extender/Task/Tracker.php

Doc Comments -1 removed lines

@@ -44,7 +44,6 @@
     /**
      * Tracker constructor
      *
-     * @param string $name
      * @param Configuration $configuration
      * @param LoggerInterface $logger
      */

src/Comodojo/Extender/Schedule/Manager.php

Doc Comments -1 removed lines

@@ -41,7 +41,6 @@
      *
      * @param Configuration $configuration
      * @param LoggerInterface $logger
-     * @param TasksTable $tasks
      * @param EventsManager $events
      * @param EntityManager $em
      */

Spacing +10 added lines, -10 removed lines

@@ -129,7 +129,7 @@ 
 
         $schedule->setFirstrun($schedule->getNextPlannedRun($time));
 
-        $this->getEvents()->emit( new ScheduleEvent('add', $schedule) );
+        $this->getEvents()->emit(new ScheduleEvent('add', $schedule));
 
         $em = $this->getEntityManager();
 
@@ -147,13 +147,13 @@ 
         $records = [];
         $em = $this->getEntityManager();
 
-        foreach ($schedules as $key => $schedule) {
+        foreach ( $schedules as $key => $schedule ) {
 
             try {
 
                 $schedule->setFirstrun($schedule->getNextPlannedRun($time));
 
-                $this->getEvents()->emit( new ScheduleEvent('add', $schedule) );
+                $this->getEvents()->emit(new ScheduleEvent('add', $schedule));
 
                 $em->persist($schedule);
 
@@ -187,7 +187,7 @@ 
 
         if ( empty($old_schedule) ) throw new Exception("Cannot find schedule with id $id");
 
-        $this->getEvents()->emit( new ScheduleEvent('edit', $schedule, $old_schedule) );
+        $this->getEvents()->emit(new ScheduleEvent('edit', $schedule, $old_schedule));
 
         $old_schedule->merge($schedule);
 
@@ -207,7 +207,7 @@ 
 
         if ( is_null($schedule) ) throw new Exception("Cannot find scheule $id");
 
-        $this->getEvents()->emit( new ScheduleEvent('remove', $schedule) );
+        $this->getEvents()->emit(new ScheduleEvent('remove', $schedule));
 
         $em->remove($schedule);
 
@@ -225,7 +225,7 @@ 
 
         if ( is_null($schedule) ) throw new Exception("Cannot find scheule $name");
 
-        $this->getEvents()->emit( new ScheduleEvent('remove', $schedule) );
+        $this->getEvents()->emit(new ScheduleEvent('remove', $schedule));
 
         $em->remove($schedule);
 
@@ -243,7 +243,7 @@ 
 
         if ( is_null($schedule) ) throw new Exception("Cannot find scheule $id");
 
-        $this->getEvents()->emit( new ScheduleEvent('enable', $schedule) );
+        $this->getEvents()->emit(new ScheduleEvent('enable', $schedule));
 
         $schedule->setEnabled(true);
 
@@ -263,7 +263,7 @@ 
 
         if ( is_null($schedule) ) throw new Exception("Cannot find scheule $name");
 
-        $this->getEvents()->emit( new ScheduleEvent('enable', $schedule) );
+        $this->getEvents()->emit(new ScheduleEvent('enable', $schedule));
 
         $schedule->setEnabled(true);
 
@@ -283,7 +283,7 @@ 
 
         if ( is_null($schedule) ) throw new Exception("Cannot find scheule $id");
 
-        $this->getEvents()->emit( new ScheduleEvent('disable', $schedule) );
+        $this->getEvents()->emit(new ScheduleEvent('disable', $schedule));
 
         $schedule->setEnabled(false);
 
@@ -303,7 +303,7 @@ 
 
         if ( is_null($schedule) ) throw new Exception("Cannot find scheule $name");
 
-        $this->getEvents()->emit( new ScheduleEvent('disable', $schedule) );
+        $this->getEvents()->emit(new ScheduleEvent('disable', $schedule));
 
         $schedule->setEnabled(false);
 

src/Comodojo/Extender/Schedule/Updater.php

Doc Comments -2 removed lines

@@ -38,9 +38,7 @@
     *
     * @param Configuration $configuration
     * @param LoggerInterface $logger
-    * @param TasksTable $tasks
     * @param EventsManager $events
-    * @param EntityManager $em
     */
     public function __construct(
         Configuration $configuration,

Indentation +8 added lines, -8 removed lines

@@ -34,14 +34,14 @@
     use EventsTrait;
 
     /**
-    * Class constructor
-    *
-    * @param Configuration $configuration
-    * @param LoggerInterface $logger
-    * @param TasksTable $tasks
-    * @param EventsManager $events
-    * @param EntityManager $em
-    */
+     * Class constructor
+     *
+     * @param Configuration $configuration
+     * @param LoggerInterface $logger
+     * @param TasksTable $tasks
+     * @param EventsManager $events
+     * @param EntityManager $em
+     */
     public function __construct(
         Configuration $configuration,
         LoggerInterface $logger,

Spacing +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
 
         $em = Database::init($this->getConfiguration())->getEntityManager();
 
-        foreach ($results as $result) {
+        foreach ( $results as $result ) {
 
             $id = $result->jid;
 
@@ -93,7 +93,7 @@ 
         $date = new DateTime();
         $timestamps = [];
 
-        foreach ($items as $schedule) {
+        foreach ( $items as $schedule ) {
 
             $timestamps[] = $schedule->getNextPlannedRun($date)->getTimestamp();
 

src/Comodojo/Extender/Task/Table.php

Spacing +1 added lines, -1 removed lines

@@ -139,7 +139,7 @@
 
         $result = [];
 
-        foreach($tasks as $name => $task) {
+        foreach ( $tasks as $name => $task ) {
 
             if ( empty($task['class']) ) {
 

src/Comodojo/Extender/Workers/QueueWorker.php

Spacing +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
 
         if ( !empty($queue) ) {
 
-            $events->emit( new QueueEvent('process', null, $queue) );
+            $events->emit(new QueueEvent('process', null, $queue));
 
             $requests = $this->jobsToRequests($queue);